]>
git.ipfire.org Git - thirdparty/systemd.git/log
Philip Withnall [Fri, 11 May 2018 09:58:00 +0000 (10:58 +0100)]
man: Fix a minor typo in systemctl(1)
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Zbigniew Jędrzejewski-Szmek [Fri, 11 May 2018 09:48:05 +0000 (11:48 +0200)]
Merge pull request #8924 from yuwata/fix-3682
resolve: allow whitespaces in the digest
Zbigniew Jędrzejewski-Szmek [Fri, 11 May 2018 08:40:18 +0000 (10:40 +0200)]
Merge pull request #8961 from yuwata/fix-8960
network: make route_update() accept NULL
Yu Watanabe [Fri, 11 May 2018 06:43:04 +0000 (15:43 +0900)]
network: make route_update() accept NULL
This also fixes a wrong argument for route_configure().
Fixes #8960.
Yu Watanabe [Fri, 11 May 2018 03:36:15 +0000 (12:36 +0900)]
network: fix indentation
Lennart Poettering [Thu, 10 May 2018 18:29:11 +0000 (11:29 -0700)]
tmpfiles: remove newline that shouldn't be there
We should really keep "else" branches together with their "if", hence
drop the double newline here...
Lennart Poettering [Thu, 10 May 2018 18:28:33 +0000 (11:28 -0700)]
terminal-util: add a function that shows a pretty separator line
Follow-up for #8824
Yu Watanabe [Fri, 11 May 2018 06:01:35 +0000 (15:01 +0900)]
test: do not call alloca() inside the list of arguments
Lennart Poettering [Fri, 11 May 2018 05:51:17 +0000 (22:51 -0700)]
Merge pull request #8953 from yuwata/bus-macro
core: simplify dbus properties
Yu Watanabe [Thu, 10 May 2018 14:17:50 +0000 (23:17 +0900)]
test-execute: remove state directories before running tests
Fixes #8679.
Yu Watanabe [Thu, 10 May 2018 15:17:38 +0000 (00:17 +0900)]
units: set RestrictNamespaces=yes to networkd and resolved
Closes #8949.
Yu Watanabe [Fri, 11 May 2018 05:44:03 +0000 (14:44 +0900)]
sd-dhcp: drop deserialize_dhcp_option() as it is equivalent to unhexmem()
Yu Watanabe [Wed, 9 May 2018 03:50:27 +0000 (12:50 +0900)]
resolve: allow whitespaces in the DS digest or DNSKEY key data
Fixes #3682.
Yu Watanabe [Fri, 11 May 2018 04:56:28 +0000 (13:56 +0900)]
hexdecoct: drop an unnecessary check
Yu Watanabe [Fri, 11 May 2018 04:55:28 +0000 (13:55 +0900)]
basic: fix comment style
Yu Watanabe [Fri, 11 May 2018 05:36:22 +0000 (14:36 +0900)]
hexdecoct: ignore whitespace within the input hexadecimal text of unhexmem()
Joost Heitbrink [Thu, 10 May 2018 13:28:10 +0000 (15:28 +0200)]
test: add testcase for environment file variables with backslashes
systemd silently strips out backslashes in variables from environment
files. Add a testcase that explicitly tests for this behaviour.
Yu Watanabe [Fri, 11 May 2018 03:42:46 +0000 (12:42 +0900)]
Merge pull request #8964 from MikhailKasimov/patch-2
man: systemd-journal-upload: rsa 2048
Mikhail Kasimov [Thu, 10 May 2018 23:43:00 +0000 (02:43 +0300)]
Update systemd-journal-upload.service.xml
Security note on 2048 bits is added.
Mikhail Kasimov [Thu, 10 May 2018 23:17:27 +0000 (02:17 +0300)]
man: systemd-journal-upload: rsa 2048
rsa:2048 is currently in use as minimal recommended key length on cert/key generating. Specifying rsa:1024 is not recommended for security reasons.
Lennart Poettering [Thu, 10 May 2018 18:14:23 +0000 (11:14 -0700)]
Merge pull request #8824 from keszybz/analyze-show-config
systemd-analyze show-config
Lennart Poettering [Tue, 24 Apr 2018 15:50:01 +0000 (17:50 +0200)]
mtd: some basic code cleanups
While looking at our exit() invocations I noticed that the mtd_probe
stuff uses 'exit(-1)' at various places, which is not really a good
idea, as exit codes of processes on Linux are supposed to be in the
range of 0…255.
This patch cleans that up a bit, and fixes a number of other things:
1. Let's always let main() exit, nothing intermediary. We generally
don't like code that invokes exit() on its own.
2. Close the file descriptors opened.
3. Some logging for errors is added, mostly on debug level.
Please review this with extra care. As I don't have the right hardware
to test this patch I only did superficial testing.
Susant Sahani [Sun, 29 Apr 2018 04:02:22 +0000 (09:32 +0530)]
Networkd tests: add bridge link properties to test
Test the "[Bridge]" section keys
```
[Bridge]
UnicastFlood=true
HairPin=true
UseBPDU=true
FastLeave=true
AllowPortToBeRoot=true
Cost=555
Priority=23
```
```
test_bridge_init (__main__.BridgeTest) ... ok
test_bridge_port_priority (__main__.BridgeTest) ... ok
test_bridge_port_priority_set_zero (__main__.BridgeTest)
It should be possible to set the bridge port priority to 0 ... ok
test_bridge_port_property (__main__.BridgeTest)
Test the "[Bridge]" section keys ... ok
```
Mikhail Kasimov [Thu, 10 May 2018 16:58:12 +0000 (19:58 +0300)]
man: journal-gatewayd.service: links on {rem,upl}
While set of systemd-journal-{gatewayd,remote,upload}.service services presents single subsystem on journald logs network transmission, systemd-journal-gatewayd.service description should also contain links to other parts of this subsystem: systemd-journal-remote.service and systemd-journal-upload.service.
Yu Watanabe [Thu, 10 May 2018 16:55:46 +0000 (01:55 +0900)]
string-util: rename strdash_if_empty() to empty_to_dash()
Yu Watanabe [Thu, 10 May 2018 16:47:33 +0000 (01:47 +0900)]
path-util: introduce empty_to_root() and use it many places
Yu Watanabe [Thu, 10 May 2018 16:41:06 +0000 (01:41 +0900)]
core: merge duplicated functions
Yu Watanabe [Thu, 10 May 2018 16:22:49 +0000 (01:22 +0900)]
core: send NULL instead of empty string
Yu Watanabe [Thu, 10 May 2018 15:39:52 +0000 (00:39 +0900)]
core: use offsetof() for Syslog{Level,Facility} dbus properties
Zbigniew Jędrzejewski-Szmek [Thu, 10 May 2018 15:23:40 +0000 (17:23 +0200)]
Merge pull request #8950 from dtardon/cleanup
use automatic cleanup more
Zbigniew Jędrzejewski-Szmek [Thu, 10 May 2018 07:01:22 +0000 (09:01 +0200)]
github: use multiple issue templates
Github now has issue templates in the web interface, and allows
more than one to be specified. Let's split our single template
in two: bug report and RFE.
Yu Watanabe [Thu, 10 May 2018 14:22:38 +0000 (23:22 +0900)]
Merge pull request #8943 from keszybz/coverity-fixes
Coverity fixes
Yu Watanabe [Thu, 10 May 2018 14:02:57 +0000 (23:02 +0900)]
core: use bus_property_get_*() functions instead of NULL
David Tardon [Thu, 10 May 2018 13:55:56 +0000 (15:55 +0200)]
sd-bus: use automatic cleanup more
Yu Watanabe [Thu, 10 May 2018 13:36:13 +0000 (22:36 +0900)]
core: drop property_get_syscall_errno()
Yu Watanabe [Thu, 10 May 2018 13:31:47 +0000 (22:31 +0900)]
core: drop property_get_{capability_bounding_set,ambient_capabilities}()
Yu Watanabe [Thu, 10 May 2018 13:26:59 +0000 (22:26 +0900)]
core: use BUS_DEFINE_PROPERTY_GET_ENUM() macro
Yu Watanabe [Thu, 10 May 2018 13:26:27 +0000 (22:26 +0900)]
core: drop 'bus_' prefix from bus_property_get_protect_{home,system}()
Yu Watanabe [Thu, 10 May 2018 13:25:00 +0000 (22:25 +0900)]
core: simplify property_get_cpu_affinity()
David Tardon [Thu, 10 May 2018 12:10:53 +0000 (14:10 +0200)]
basic: use automatic cleanup more
David Tardon [Thu, 10 May 2018 12:08:35 +0000 (14:08 +0200)]
basic: use automatic cleanup more
David Tardon [Thu, 10 May 2018 12:04:30 +0000 (14:04 +0200)]
basic: use automatic cleanup more
David Tardon [Thu, 10 May 2018 11:42:36 +0000 (13:42 +0200)]
journal: use automatic cleanup more
Mikhail Kasimov [Thu, 10 May 2018 03:47:03 +0000 (06:47 +0300)]
man: systemd-networkd-wait-online: systemd.service (#8945)
* man: systemd-networkd-wait-online: systemd.service
While service type is mentioned (is a oneshot system service), link on systemd.service is added. 'See Also' section is also updated with link on systemd.service man-page.
Mikhail Kasimov [Thu, 10 May 2018 03:15:55 +0000 (06:15 +0300)]
man: systemd-escape: add missed short keys (#8944)
Added short keys -u and -m for --unescape and --mangle respectively. These short keys are present in systemd-escape --help output and are absent in man systemd-escape page.
Filipe Brandenburger [Thu, 10 May 2018 01:10:07 +0000 (18:10 -0700)]
conf-parser: accept trailing backslash at the end of the file (#8941)
This makes it behave the same whether there is a blank line or not at
the end of the file. This is also consistent with the behavior of the
shell on a shell script that ends on a trailing backslash at the last
line.
Added tests to test_config_parse(), which only pass if the corresponding
change to config_parse() is included.
Mikhail Kasimov [Thu, 10 May 2018 00:18:59 +0000 (03:18 +0300)]
add journal-upload.conf refentrytitle (#8942)
Add journal-upload.conf refentrytitle to have the same format to systemd-journal-remote.service description, which contains refentrytitle on journal-remote.conf in 'See Also' section.
Zbigniew Jędrzejewski-Szmek [Thu, 10 May 2018 00:03:23 +0000 (02:03 +0200)]
core/mount-setup: remove part of check which is always true
k was set to join_controllers at this point and only incremented, so
it cannot be null at this point.
CID #
1390949 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 23:55:05 +0000 (01:55 +0200)]
basic/fs-util: remove logically dead code
We can jump to chase_one from two places. In the first 'todo' is set to
'buffer', which comes from path_make_absolute_cwd() and is nonnull In the
second 'todo' is set to 'joined' which is checked to be nonull a few lines
above the jump. So let's kill the code that deals with null todo there.
CID #
1390941 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 23:49:01 +0000 (01:49 +0200)]
udevadm: fix null dererefence on allocation error
CID #
1390936 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 23:45:20 +0000 (01:45 +0200)]
localed: fix memleak in error path
CID #
1390929 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 23:34:33 +0000 (01:34 +0200)]
logind: fix borked r check
CID #
1390947 , #
1390952 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 23:22:29 +0000 (01:22 +0200)]
basic/format-table: add missing va_end()
CID #
1390930 , #
1390940 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 23:16:03 +0000 (01:16 +0200)]
Introduce _cleanup_(strbuf_cleanupp) and use it to fix null deref on error
catalog_update() would call strbuf_cleanup(NULL) on allocation error.
CID #
1390928 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 23:04:53 +0000 (01:04 +0200)]
shared/sleep-config: fix memleak of strv, add test
CID #
1390921 , #
1390951 .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 22:39:36 +0000 (00:39 +0200)]
Merge pull request #8689 from davide125/static
meson: add support for building static libsystemd and libudev
Igor Gnatenko [Wed, 9 May 2018 18:55:26 +0000 (20:55 +0200)]
Merge pull request #8939 from yuwata/fix-comment
several cleanups
Yu Watanabe [Wed, 9 May 2018 15:59:47 +0000 (00:59 +0900)]
timedate: use free_and_strdup()
Yu Watanabe [Wed, 9 May 2018 15:34:46 +0000 (00:34 +0900)]
tree-wide: use strv_free_and_replace() macro
Yu Watanabe [Wed, 9 May 2018 13:50:07 +0000 (22:50 +0900)]
time-util: fix indentation for comments
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 12:12:33 +0000 (14:12 +0200)]
Merge pull request #8923 from yuwata/resolvectl-drop-funcs
resolvectl: drop service_family_{from,to}_string()
Yu Watanabe [Wed, 9 May 2018 08:54:30 +0000 (17:54 +0900)]
Merge pull request #8938 from keszybz/sd-bus-automatic-cleanup
Use automatic cleanup more in sd-bus
David Tardon [Wed, 9 May 2018 08:33:28 +0000 (10:33 +0200)]
use max. message size allowed by DBus spec (#8936)
C.f. https://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-messages.
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 08:31:24 +0000 (10:31 +0200)]
Merge pull request #8934 from yuwata/fix-8913
bus-util: print a friendly message when PID1 is not systemd
Yu Watanabe [Wed, 9 May 2018 08:06:46 +0000 (17:06 +0900)]
bus-util: print a friendly message when PID1 is not systemd
Follow-up for
861f16d2679eeda79e8185057cef24653913e300 .
Fixes #8913.
Yu Watanabe [Wed, 9 May 2018 05:56:40 +0000 (14:56 +0900)]
analyze: merge acquire_full_bus() and acquire_systemd_bus()
Follow-up for
5c69b31c137ffa24bca5a4628f9b4879d0f4e84a .
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 07:44:37 +0000 (09:44 +0200)]
sd-bus: add bus_freep and use _cleanup_
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 07:35:01 +0000 (09:35 +0200)]
sd-bus: use automatic cleanup more
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 07:25:03 +0000 (09:25 +0200)]
sd-bus: trivial simplification
Yu Watanabe [Wed, 9 May 2018 07:17:37 +0000 (16:17 +0900)]
man: fix invalid option name --devpath in 'udevadm info' (#8935)
Yu Watanabe [Wed, 9 May 2018 07:00:55 +0000 (16:00 +0900)]
man: --debug option is implied in udev test and test-builtin commands (#8933)
Zbigniew Jędrzejewski-Szmek [Wed, 9 May 2018 06:35:26 +0000 (08:35 +0200)]
Merge pull request #8902 from yuwata/link-multiple-mac
network,link: make MACAddress= in [Match] section can take multiple MAC addresses
Yu Watanabe [Fri, 4 May 2018 08:56:34 +0000 (17:56 +0900)]
network,udev: sort included headers
Yu Watanabe [Wed, 9 May 2018 03:00:16 +0000 (12:00 +0900)]
man: document that MACAddress= in [Match] section can take multiple MAC addresses
Yu Watanabe [Wed, 9 May 2018 02:59:18 +0000 (11:59 +0900)]
network,udev: make MACAddress= in [Match] section take multiple MAC addresses
Yu Watanabe [Sun, 6 May 2018 04:51:30 +0000 (13:51 +0900)]
test: add tests for config_parse_hwaddrs()
Yu Watanabe [Sun, 6 May 2018 04:47:15 +0000 (13:47 +0900)]
libsystemd-network: introduce config_parse_hwaddrs()
Yu Watanabe [Sun, 6 May 2018 16:30:00 +0000 (01:30 +0900)]
ether-addr-util: add hash_ops functions for struct ether_addr
Yu Watanabe [Fri, 4 May 2018 08:36:40 +0000 (17:36 +0900)]
ether-addr-util: make ether_addr_from_string() stricter
Zbigniew Jędrzejewski-Szmek [Wed, 25 Apr 2018 13:29:48 +0000 (15:29 +0200)]
meson: recompile all sources for install_libudev_static and install_libsystemd_static
This means that when those targets are built, all the sources are built again,
instead of reusing the work done to create libbasic.a and other convenience static
libraries. It would be nice to not do this, but there seems to be no support in
our toolchain for joining multiple static libraries into one. When linking
a static library, any -l arguments are simply ignored by ar/gcc-ar, and .a
libraries given as positional arguments are copied verbatim into the archive
so they objects in them cannot be accessed.
https://stackoverflow.com/questions/
2157629 /linking-static-libraries-to-other-static-libraries
suggests either unzipping all the archives and putting them back togather,
or using a linker script. Unzipping and zipping back together seems ugly.
The other option is not very nice. The linker script language does not
allow "+" to appear in the filenames, and filenames that meson generates
use that, so files would have to be renamed before a linker script was used.
And we would have to generate the linker script on the fly. Either way, this
doesn't seem attractive. Since those static libraries are a niche use case,
it seems reasonable to just go with the easiest and safest solution and
recompile all the source files. Thanks to ccache, this is probably almost as
cheap as actually reusing the convenience .a libraries.
test-libsystemd-sym.c and test-libudev-sym.c compile fine with the generated
static libs, so it seems that they indeed provide all the symbols they should.
Davide Cavalca [Tue, 24 Apr 2018 20:34:48 +0000 (13:34 -0700)]
meson: only build test-lib{systemd,udev}-static-sym for pic
Zbigniew Jędrzejewski-Szmek [Mon, 23 Apr 2018 11:49:27 +0000 (13:49 +0200)]
meson: add test-lib{systemd,udev}-static-sym
This is the same as test-lib{systemd,udev}-sym, but linked to the static
variants of those libraries.
Davide Cavalca [Mon, 9 Apr 2018 09:43:35 +0000 (02:43 -0700)]
meson: add support for building static libsystemd and libudev
Zbigniew Jędrzejewski-Szmek [Tue, 8 May 2018 15:00:19 +0000 (17:00 +0200)]
tools/oss-fuzz: install private shared library non-executable (#8927)
Apparently oss-fuzz's "bad build check" is confused by the library.
Let's make it non-executable, so the checker ignores it.
Should fix https://github.com/google/oss-fuzz/issues/1330.
Alan Jenkins [Tue, 8 May 2018 14:53:41 +0000 (15:53 +0100)]
man/systemd.special: fix network v.s. LSB scripts (#8930)
$network is converted to network-online.target, not network-target.
See https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
and the implementation at `src/sysv-generator/sysv-generator.c`.
Michael Biebl [Tue, 8 May 2018 13:03:27 +0000 (15:03 +0200)]
Merge pull request #8915 from yuwata/fix-8904
login: do not wall message on cancelling shutdown when Manager.enable_wall_messages is false
Susant Sahani [Tue, 8 May 2018 11:03:41 +0000 (16:33 +0530)]
link: Add support to configure channels of the specified network device (#8882)
closes #8856
Zbigniew Jędrzejewski-Szmek [Tue, 8 May 2018 10:54:58 +0000 (12:54 +0200)]
Merge pull request #8898 from poettering/nspawn-mount-block
some nspawn cgroup and mount lock-down fixes
Yu Watanabe [Tue, 8 May 2018 08:56:51 +0000 (17:56 +0900)]
Merge pull request #8926 from keszybz/man-journal-remote
Small additions to sd-journal-{remote,upload}.service man pages
Yu Watanabe [Tue, 8 May 2018 08:53:52 +0000 (17:53 +0900)]
man: fix title of systemd-networkd-wait-online(8) (#8925)
Yu Watanabe [Tue, 8 May 2018 08:52:36 +0000 (17:52 +0900)]
resolvectl: drop service_family_{from,to}_string()
These functions are used only for checking the validity of input string.
Hence, this drops them and introduces a simple checking function.
Yu Watanabe [Tue, 8 May 2018 03:09:31 +0000 (12:09 +0900)]
man: add missing 'query' command in examples of resolvectl
Zbigniew Jędrzejewski-Szmek [Tue, 8 May 2018 08:39:18 +0000 (10:39 +0200)]
man: add a bit more text about systemd-journal-upload.service
Zbigniew Jędrzejewski-Szmek [Tue, 8 May 2018 08:37:09 +0000 (10:37 +0200)]
man: add a bit more text about systemd-journal-remote.service
Zbigniew Jędrzejewski-Szmek [Tue, 8 May 2018 08:31:50 +0000 (10:31 +0200)]
Merge pull request #8922 from yuwata/fix-8920-8921
man: update references to systemd-journal-{remote,upload}
Yu Watanabe [Tue, 8 May 2018 03:41:59 +0000 (12:41 +0900)]
man: fix typo
Yu Watanabe [Tue, 8 May 2018 02:58:16 +0000 (11:58 +0900)]
man: mention that --url option of journal-upload can specify the port number
Yu Watanabe [Tue, 8 May 2018 02:57:28 +0000 (11:57 +0900)]
man: mention the default port number of journal-remote
Yu Watanabe [Tue, 8 May 2018 01:14:02 +0000 (10:14 +0900)]
man: update references to systemd-journal-{remote,upload}
Fixes #8920 and #8921.
Zbigniew Jędrzejewski-Szmek [Fri, 27 Apr 2018 16:20:17 +0000 (18:20 +0200)]
Eliminate config_dirs vars which hold a static strv