]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
3 years agomachined: refactor UID/GID machine translation
Lennart Poettering [Tue, 7 Jul 2020 09:58:06 +0000 (11:58 +0200)] 
machined: refactor UID/GID machine translation

Let's move the heavy lifting out of the bus call implemntations, and
into generic code.

This allows us to expose them easily via Varlink too in a later commit.

3 years agoprocess-util: make sure procfs_file_alloca() works for non-literal field names too
Lennart Poettering [Tue, 14 Jul 2020 14:59:22 +0000 (16:59 +0200)] 
process-util: make sure procfs_file_alloca() works for non-literal field names too

3 years agodocs: permit user/group services that do not support enumeration
Lennart Poettering [Tue, 7 Jul 2020 09:55:21 +0000 (11:55 +0200)] 
docs: permit user/group services that do not support enumeration

sssd people don't like enumeration and for some other cases it's not
nice to support either, in particular when synthesizing records for
container/userns UID/GID ranges.

Hence, let's make enumeration optional.

3 years agoupdate TODO
Lennart Poettering [Tue, 14 Jul 2020 13:06:29 +0000 (15:06 +0200)] 
update TODO

3 years agoanalyze: make testing ConditionPathExistsGlob= work
Lennart Poettering [Tue, 14 Jul 2020 10:21:47 +0000 (12:21 +0200)] 
analyze: make testing ConditionPathExistsGlob= work

Fixes: #16439
Alternative-To: #16440
3 years agoupdate TODO
Lennart Poettering [Fri, 10 Jul 2020 07:53:26 +0000 (09:53 +0200)] 
update TODO

3 years agoudevadm: beef up deprecation log warning
Lennart Poettering [Wed, 8 Jul 2020 15:51:55 +0000 (17:51 +0200)] 
udevadm: beef up deprecation log warning

Let's add a catalog entry explaining further details.

Most importantly though: talk to PID 1 directly, via the private D-Bus
socket, so that this actually works correctly during early boot, where
D-Bus is not around.

3 years agomeson: do not install testdata when -Dinstall-tests=false
Zbigniew Jędrzejewski-Szmek [Tue, 14 Jul 2020 09:35:29 +0000 (11:35 +0200)] 
meson: do not install testdata when -Dinstall-tests=false

Fixes #16447.

3 years agoUpdate .clang-format
szb512 [Mon, 13 Jul 2020 15:58:09 +0000 (11:58 -0400)] 
Update .clang-format

3 years agoMake the instructions slightly easier to read
szb512 [Thu, 9 Jul 2020 13:23:32 +0000 (09:23 -0400)] 
Make the instructions slightly easier to read

3 years agoMerge pull request #16437 from systemd/coverity-gcc-10
Evgeny Vereshchagin [Sun, 12 Jul 2020 22:42:39 +0000 (01:42 +0300)] 
Merge pull request #16437 from systemd/coverity-gcc-10

coverity: switch back to Fedora 31

3 years agocoverity: install systemd 16437/head
Evgeny Vereshchagin [Sun, 12 Jul 2020 22:17:50 +0000 (22:17 +0000)] 
coverity: install systemd

Apparently systemd is no longer installed in fedora containers
by default

```
docker: Error response from daemon: OCI runtime create failed: container_linux.go:348:
starting container process caused "exec: \"/sbin/init\": stat /sbin/init: no such file or directory": unknown.
The command "$CI_MANAGERS/fedora.sh SETUP" failed and exited with 127 during .
```

3 years agocoverity: switch back to Fedora 31
Evgeny Vereshchagin [Sun, 12 Jul 2020 22:00:16 +0000 (22:00 +0000)] 
coverity: switch back to Fedora 31

Apparently 6 days ago fedora:latest started to point to fedora:32,
which comes with gcc-10. Coverity doesn't support it yet.

3 years agorepart: include more relevant information in the warning message, fix test
Zbigniew Jędrzejewski-Szmek [Sat, 11 Jul 2020 14:19:03 +0000 (16:19 +0200)] 
repart: include more relevant information in the warning message, fix test

The test would always fail with a long uname. In F33 this is right
now "5.8.0-0.rc2.20200622git625d3449788f.1.fc33.x86_64" which caused the
test to always fail.

3 years agoMerge pull request #16435 from gaoyi1988/master
Yu Watanabe [Sun, 12 Jul 2020 12:46:22 +0000 (21:46 +0900)] 
Merge pull request #16435 from gaoyi1988/master

fix multi matches when use "||"

3 years agoNEWS: mention source mode for MACVLAN or MACVTAP
Yu Watanabe [Sun, 12 Jul 2020 08:13:57 +0000 (17:13 +0900)] 
NEWS: mention source mode for MACVLAN or MACVTAP

3 years agoMerge pull request #16432 from cgzones/selinux_err_fix
Zbigniew Jędrzejewski-Szmek [Sun, 12 Jul 2020 09:55:44 +0000 (11:55 +0200)] 
Merge pull request #16432 from cgzones/selinux_err_fix

SELlinux followup error/logging fixes

3 years agotest: add test case for multi matches when use "||" 16435/head
gaoyi [Sun, 12 Jul 2020 07:27:45 +0000 (03:27 -0400)] 
test: add test case for multi matches when use "||"

Signed-off-by: gaoyi <ymuemc@163.com>
3 years agoudev: specify the end of value
gaoyi [Sun, 12 Jul 2020 07:24:42 +0000 (03:24 -0400)] 
udev: specify the end of value

NULSTR_FOREACH may read the illegal match

Signed-off-by: gaoyi <ymuemc@163.com>
3 years agobus: use bus_log_parse_error to print message
fangxiuning [Sat, 11 Jul 2020 10:13:01 +0000 (18:13 +0800)] 
bus: use bus_log_parse_error to print message

3 years agonamespace: unify logging in mount_tmpfs 16432/head
Christian Göttsche [Sat, 11 Jul 2020 19:12:55 +0000 (21:12 +0200)] 
namespace: unify logging in mount_tmpfs

Fixes: abad72be4df9d5a13ceecd5b4d073adb370882b7
Follow up: #16426

3 years agoshared: fix error handling in make_inaccessible_nodes
Christian Göttsche [Sat, 11 Jul 2020 19:12:08 +0000 (21:12 +0200)] 
shared: fix error handling in make_inaccessible_nodes

_label wrappers return -errno on failure instead of returning -1 and
setting global errno.

Fixes: 8d9cbd809db492df9d94c0c664bd0d2e53416531
Follow up: #16426

3 years agoMerge pull request #16424 from keszybz/cap-bpf-compat
Zbigniew Jędrzejewski-Szmek [Sat, 11 Jul 2020 11:35:34 +0000 (13:35 +0200)] 
Merge pull request #16424 from keszybz/cap-bpf-compat

Handle new capabilities gracefully

3 years agoMerge pull request #16426 from cgzones/run_user_label
Zbigniew Jędrzejewski-Szmek [Sat, 11 Jul 2020 11:32:00 +0000 (13:32 +0200)] 
Merge pull request #16426 from cgzones/run_user_label

selinux: create standard user-runtime nodes with default context

3 years agoman: fix some manvolnum
Anita Zhang [Fri, 10 Jul 2020 22:05:23 +0000 (15:05 -0700)] 
man: fix some manvolnum

3 years agonamespace: fix MAC labels of TemporaryFileSystem= 16426/head
Christian Göttsche [Fri, 10 Jul 2020 20:08:50 +0000 (22:08 +0200)] 
namespace: fix MAC labels of TemporaryFileSystem=

Reproducible with:
  systemd-run -p TemporaryFileSystem=/root -t /bin/bash
    ls -dZ /root

Prior:
  root:object_r:tmpfs_t:s0 /root
Past:
  root:object_r:user_home_dir_t:s0 /root

3 years agoselinux: create standard user-runtime nodes with default context
Christian Göttsche [Fri, 10 Jul 2020 19:48:02 +0000 (21:48 +0200)] 
selinux: create standard user-runtime nodes with default context

Currently systemd-user-runtime-dir does not create the files in
/run/user/$UID/systemd/inaccessible with the default SELinux label.
The user and role part of these labels should be based on the user
related to $UID and not based on the process context of
systemd-user-runtime-dir.

Since v246-rc1 (9664be199af6) /run/user/$UID/systemd is also created by
systemd-user-runtime-dir and should also be created with the default
SELinux context.

3 years agobasic: add helper function mknod_label()
Christian Göttsche [Fri, 10 Jul 2020 19:37:44 +0000 (21:37 +0200)] 
basic: add helper function mknod_label()

3 years agoNEWS: grammar improvements (#16413)
Clinton Roy [Fri, 10 Jul 2020 16:58:30 +0000 (02:58 +1000)] 
NEWS: grammar improvements (#16413)

3 years agoAdded MSI Prestige15 A10SC specific keycodes
Filippo Falezza [Thu, 9 Jul 2020 17:12:20 +0000 (19:12 +0200)] 
Added MSI Prestige15 A10SC specific keycodes

This commit enables the microphone mute button and the screen rotate button, even if the latter is improperly linked. I have documented how to achieve this in https://wiki.archlinux.org/index.php/MSI_P15#Fn_Keys .

3 years agoAdd support for HP Elitebook x360 1040 G6 micmute button
Surhud More [Thu, 9 Jul 2020 19:14:29 +0000 (00:44 +0530)] 
Add support for HP Elitebook x360 1040 G6 micmute button

3 years agoExplain how to determine hierarchy type from shell
Florian Mayer [Fri, 10 Jul 2020 16:40:36 +0000 (18:40 +0200)] 
Explain how to determine hierarchy type from shell

This makes it easier for people than just recommending the syscall.

3 years agobasic/cap-list: reduce scope of variables 16424/head
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jul 2020 21:23:07 +0000 (23:23 +0200)] 
basic/cap-list: reduce scope of variables

3 years agobasic/capability-util: let cap_last_cap() return unsigned integer
Zbigniew Jędrzejewski-Szmek [Fri, 10 Jul 2020 14:53:51 +0000 (16:53 +0200)] 
basic/capability-util: let cap_last_cap() return unsigned integer

We never return anything higher than 63, so using "long unsigned"
as the type only confused the reader. (We can still use "long unsigned"
and safe_atolu() to parse the kernel file.)

3 years agobasic/cap-list: parse/print numerical capabilities
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jul 2020 21:15:47 +0000 (23:15 +0200)] 
basic/cap-list: parse/print numerical capabilities

We would refuse to print capabilities which were didn't have a name
for. The kernel adds new capabilities from time to time, most recently
cap_bpf. 'systmectl show -p CapabilityBoundingSet ...' would fail with
"Failed to parse bus message: Invalid argument" because
capability_set_to_string_alloc() would fail with -EINVAL. So let's
print such capabilities in hexadecimal:

CapabilityBoundingSet=cap_chown cap_dac_override cap_dac_read_search
  cap_fowner cap_fsetid cap_kill cap_setgid cap_setuid cap_setpcap
  cap_linux_immutable cap_net_bind_service cap_net_broadcast cap_net_admin
  cap_net_raw cap_ipc_lock cap_ipc_owner 0x10 0x11 0x12 0x13 0x14 0x15 0x16
  0x17 0x18 0x19 0x1a ...

For symmetry, also allow capabilities that we don't know to be specified.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1853736.

3 years agoinstall: fix wrong data type
fangxiuning [Wed, 8 Jul 2020 14:04:08 +0000 (22:04 +0800)] 
install: fix wrong data type

3 years agoNEWS: drop duplicate entry, add --image= entry
Lennart Poettering [Fri, 10 Jul 2020 08:04:37 +0000 (10:04 +0200)] 
NEWS: drop duplicate entry, add --image= entry

3 years agoNEWS: add date v246-rc1
Zbigniew Jędrzejewski-Szmek [Thu, 9 Jul 2020 06:33:39 +0000 (08:33 +0200)] 
NEWS: add date

3 years agouserdb: fix dlopen call
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 20:23:24 +0000 (22:23 +0200)] 
userdb: fix dlopen call

The call would always fail with:
systemd-userwork[780]: Failed to dlopen(libnss_systemd.so.2), ignoring: /usr/lib64libnss_systemd.so.2: cannot open shared object file: No such file or directory

3 years agoMerge pull request #16411 from ddstreet/bridge_without_carrier_fails
Yu Watanabe [Thu, 9 Jul 2020 05:01:45 +0000 (14:01 +0900)] 
Merge pull request #16411 from ddstreet/bridge_without_carrier_fails

Bridge without carrier fails

3 years agoNEWS: add blurb about os-release and $container_host_*
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 22:02:55 +0000 (00:02 +0200)] 
NEWS: add blurb about os-release and $container_host_*

3 years agoMerge pull request #15891 from bluca/host_os_release
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 21:52:13 +0000 (23:52 +0200)] 
Merge pull request #15891 from bluca/host_os_release

Container Interface: expose the host's os-release metadata to nspawn and portable guests

3 years agotest-netowrk: in test_bridge_configure_without_carrier, avoid strange test failures 16411/head
Dan Streetman [Wed, 8 Jul 2020 21:05:03 +0000 (17:05 -0400)] 
test-netowrk: in test_bridge_configure_without_carrier, avoid strange test failures

For some reason the wait-online is failing intermittently; it's unclear
exactly why, but this hopefully avoids the failure for unrelated PR.

This is a workaround (not fix) for #16105

3 years agoMerge pull request #16405 from sipraga/master
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 20:31:42 +0000 (22:31 +0200)] 
Merge pull request #16405 from sipraga/master

3 years agoMerge pull request #15955 from anitazha/nullorempty
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 20:18:17 +0000 (22:18 +0200)] 
Merge pull request #15955 from anitazha/nullorempty

core: check null_or_empty_path for masked units instead of /dev/null

3 years agotest-network: don't print networkctl output for passing subtests
Dan Streetman [Wed, 8 Jul 2020 20:13:14 +0000 (16:13 -0400)] 
test-network: don't print networkctl output for passing subtests

This just clutters up the logs.

3 years agoMerge pull request #16404 from keszybz/release-246-prep
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 20:10:44 +0000 (22:10 +0200)] 
Merge pull request #16404 from keszybz/release-246-prep

Prepare v246-rc1

3 years agotest: bump the TEST-47 sleeps once again
Frantisek Sumsal [Wed, 8 Jul 2020 12:42:43 +0000 (14:42 +0200)] 
test: bump the TEST-47 sleeps once again

Several recent failed runs show that the test is still racy in two ways:

1) Sometimes it takes a while before the PID file is created, leading
   to:

```
[   10.950540] testsuite-47.sh[308]: ++ cat /leakedtestpid
[   10.959712] testsuite-47.sh[308]: cat: /leakedtestpid: No such file or directory
[   10.959824] testsuite-47.sh[298]: + leaked_pid=
```

2) Again, sometimes we check the leaked PID before the unit is actually
   stopped, leading to a false negative:

```
[   18.099599] testsuite-47.sh[346]: ++ cat /leakedtestpid
[   18.116462] testsuite-47.sh[333]: + leaked_pid=342
[   18.117101] testsuite-47.sh[333]: + systemctl stop testsuite-47-repro
...
[   20.033907] testsuite-47.sh[333]: + ps -p 342
[   20.080050] testsuite-47.sh[351]:     PID TTY          TIME CMD
[   20.080050] testsuite-47.sh[351]:     342 ?        00:00:00 sleep
[   20.082040] testsuite-47.sh[333]: + exit 42
```

3 years agonetwork: add support for MACVLAN source mode 16405/head
Alvin Šipraga [Wed, 8 Jul 2020 13:52:23 +0000 (15:52 +0200)] 
network: add support for MACVLAN source mode

Add support for creating a MACVLAN interface in "source" mode by
specifying Mode=source in the [MACVLAN] section of a .netdev file.

A list of allowed MAC addresses for the corresponding MACVLAN can also
be specified with the SourceMACAddress= option of the [MACVLAN] section.

An example .netdev file:

    [NetDev]
    Name=macvlan0
    Kind=macvlan
    MACAddress=02:DE:AD:BE:EF:00

    [MACVLAN]
    Mode=source
    SourceMACAddress=02:AB:AB:AB:AB:01 02:CD:CD:CD:CD:01
    SourceMACAddress=02:EF:EF:EF:EF:01

The same keys can also be specified in [MACVTAP] for MACVTAP kinds of
interfaces, with the same semantics.

3 years agomeson: bump version numbers for v246 16404/head
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 15:35:54 +0000 (17:35 +0200)] 
meson: bump version numbers for v246

3 years agoNEWS: update contributors list for v246-rc
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 15:33:36 +0000 (17:33 +0200)] 
NEWS: update contributors list for v246-rc

3 years agogit-contrib: simplify implementation a bit
Zbigniew Jędrzejewski-Szmek [Wed, 8 Jul 2020 15:31:43 +0000 (17:31 +0200)] 
git-contrib: simplify implementation a bit

3 years agoMerge pull request #16385 from JackFangXN/master
Lennart Poettering [Wed, 8 Jul 2020 10:12:29 +0000 (12:12 +0200)] 
Merge pull request #16385 from JackFangXN/master

table add table_log_xx_error()

3 years agosd-device: use log_device_debug_errno()
Yu Watanabe [Wed, 8 Jul 2020 01:35:45 +0000 (10:35 +0900)] 
sd-device: use log_device_debug_errno()

3 years agotable use table_log_print_error() instead of table_log_show_error 16385/head
fangxiuning [Wed, 8 Jul 2020 07:16:52 +0000 (15:16 +0800)] 
table use table_log_print_error() instead of table_log_show_error

3 years agotable add table_log_sort_error()
fangxiuning [Tue, 7 Jul 2020 02:29:14 +0000 (10:29 +0800)] 
table add table_log_sort_error()

3 years agotable add table_log_show_error()
fangxiuning [Tue, 7 Jul 2020 02:13:13 +0000 (10:13 +0800)] 
table add table_log_show_error()

3 years agoMerge pull request #16379 from yuwata/network-dhcp6-delegated-prefix-address-handler
Yu Watanabe [Wed, 8 Jul 2020 01:22:08 +0000 (10:22 +0900)] 
Merge pull request #16379 from yuwata/network-dhcp6-delegated-prefix-address-handler

network: fix assertion in assigning dhcp6 delegated prefix

3 years agodocs: update information where to file bugs against RHEL/CentOS versions of systemd
Lukas Nykryn [Tue, 7 Jul 2020 18:42:04 +0000 (20:42 +0200)] 
docs: update information where to file bugs against RHEL/CentOS versions of systemd

3 years agoMerge pull request #16143 from fbuihuu/fstab-generator-fix
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 18:06:18 +0000 (20:06 +0200)] 
Merge pull request #16143 from fbuihuu/fstab-generator-fix

fstab-generator: make sure explicit deps configured via mount options apply to .mount, not .automount unit

3 years agoadd error message when bind mount src missing
Alan Perry [Fri, 26 Jun 2020 05:37:39 +0000 (05:37 +0000)] 
add error message when bind mount src missing

3 years agonetwork: make address_handler() static 16379/head
Yu Watanabe [Mon, 6 Jul 2020 23:39:14 +0000 (08:39 +0900)] 
network: make address_handler() static

3 years agonetwork: introduce own address handler for dhcp6 delegated prefix
Yu Watanabe [Mon, 6 Jul 2020 23:38:37 +0000 (08:38 +0900)] 
network: introduce own address handler for dhcp6 delegated prefix

Fixes #16365.

3 years agoMerge pull request #16301 from poettering/firstboot-image
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 17:44:12 +0000 (19:44 +0200)] 
Merge pull request #16301 from poettering/firstboot-image

Add --image= switch to firstboot, similar to --root= but with support for operating on disk image

3 years agoMerge pull request #16388 from keszybz/xdg-desktop-fuzz-case
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 17:41:31 +0000 (19:41 +0200)] 
Merge pull request #16388 from keszybz/xdg-desktop-fuzz-case

xdg-desktop fuzz case

3 years agoMerge pull request #16390 from keszybz/coverity-and-typos
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 17:40:10 +0000 (19:40 +0200)] 
Merge pull request #16390 from keszybz/coverity-and-typos

One coverity-inspired fix and spelling

3 years agoxdg-autostart: ignore all empty entries in multi-string entries 16388/head
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 09:31:17 +0000 (11:31 +0200)] 
xdg-autostart: ignore all empty entries in multi-string entries

The desktop file specification allows entries like ";;;;;;", full of empty strings.
But looking at the actual list of supported keys [1], empty entries are meaningless
(unless we would allow e.g. the desktop name to be the empty string. But that doesn't
seem very useful either). So let's just simplify our life and skip any empty substrings
entirely.

This would also resolve the fuzzer case:
$ valgrind build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812
test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812... ok
==2899241== HEAP SUMMARY:
==2899241==     in use at exit: 0 bytes in 0 blocks
==2899241==   total heap usage: 484,385 allocs, 484,385 frees, 12,411,330 bytes allocated

==2899650== HEAP SUMMARY:
==2899650==     in use at exit: 0 bytes in 0 blocks
==2899650==   total heap usage: 1,325 allocs, 1,325 frees, 1,463,602 bytes allocated

3 years agoman: match parentheses
Topi Miettinen [Mon, 6 Jul 2020 17:46:01 +0000 (20:46 +0300)] 
man: match parentheses

Files found with:
for f in *; do \
    l=`tr -d '[^(]' < $f | wc -c`; \
    r=`tr -d '[^)]' < $f | wc -c`; \
    if [ $l -ne $r ]; then \
       echo $f $l $r; \
    fi; \
done

3 years agoxdg-autostart: avoid quadratic behaviour in strv parsing
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 09:24:36 +0000 (11:24 +0200)] 
xdg-autostart: avoid quadratic behaviour in strv parsing

The fuzzer test case has a giant line with ";;;;;;;;;;;..." which is turned into
a strv of empty strings. Unfortunately, when pushing each string, strv_push() needs
to walk the whole array, which leads to quadratic behaviour. So let's use
greedy_allocation here and also keep location in the string to avoid iterating.

build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812  51.10s user 0.01s system 99% cpu 51.295 total

build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812  0.07s user 0.01s system 96% cpu 0.083 total

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22812.

Other minor changes:
- say "was already defined" instead of "defined multiple times" to make it
  clear that we're ignoring this second definition, and not all definitions
  of the key
- unescaping needs to be done also for the last entry

3 years agojournald: minor wording tweak in message 16390/head
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 10:14:41 +0000 (12:14 +0200)] 
journald: minor wording tweak in message

For a user "from the kernel" might be rather unclear.

3 years agotree-wide: more repeated words
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 10:08:22 +0000 (12:08 +0200)] 
tree-wide: more repeated words

3 years agonetworkd: use capitalized "IP" and "TOS" in messages
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 09:51:29 +0000 (11:51 +0200)] 
networkd: use capitalized "IP" and "TOS" in messages

3 years agojournal/compress: drop "future" code in zstd compression
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 09:56:32 +0000 (11:56 +0200)] 
journal/compress: drop "future" code in zstd compression

We generally don't include stuff that is not used. This can be
easily ressurected if ever needed.

Fixes CID#1430210.

3 years agoall: fix minor typos
Yuri Chornoivan [Sat, 4 Jul 2020 08:37:01 +0000 (11:37 +0300)] 
all: fix minor typos

[thaller@redhat.com: original patch by Yuri, extracted from [1]]

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/565

3 years agoupdate NEWS
Lennart Poettering [Tue, 7 Jul 2020 09:48:45 +0000 (11:48 +0200)] 
update NEWS

3 years agoupdate TODO
Lennart Poettering [Tue, 7 Jul 2020 09:33:18 +0000 (11:33 +0200)] 
update TODO

3 years agoTODO 16301/head
Lennart Poettering [Sat, 27 Jun 2020 09:15:19 +0000 (11:15 +0200)] 
TODO

3 years agofirstboot: add option to turn off welcome text display
Lennart Poettering [Sun, 28 Jun 2020 09:59:00 +0000 (11:59 +0200)] 
firstboot: add option to turn off welcome text display

3 years agoman: document the new --image= switch of systemd-firstboot
Lennart Poettering [Sat, 27 Jun 2020 09:09:41 +0000 (11:09 +0200)] 
man: document the new --image= switch of systemd-firstboot

3 years agofirstboot: add --image= switch
Lennart Poettering [Mon, 30 Mar 2020 13:39:43 +0000 (15:39 +0200)] 
firstboot: add --image= switch

This is like --root=, but takes an image file path or device node path
and dissects the image directly, mounting it internally.

3 years agomount-util: use UMOUNT_NOFOLLOW in recursive umounter
Lennart Poettering [Sat, 27 Jun 2020 09:13:01 +0000 (11:13 +0200)] 
mount-util: use UMOUNT_NOFOLLOW in recursive umounter

When we only want to unmount mount points below some path then it is
against our interest to follow symlinks. Hence don't.

3 years agomount-util: add destructor helper that umounts + rmdirs a path
Lennart Poettering [Sat, 27 Jun 2020 08:38:07 +0000 (10:38 +0200)] 
mount-util: add destructor helper that umounts + rmdirs a path

3 years agonamespace-util: introduce helper for combining unshare() + MS_SLAVE remount
Lennart Poettering [Sun, 2 Feb 2020 17:56:12 +0000 (18:56 +0100)] 
namespace-util: introduce helper for combining unshare() + MS_SLAVE remount

We have multiple places we do these two non-trivial operations together,
let's introduce a unified helper for doing both at once.

3 years agofuzz: add test case that should already be resolved
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 08:26:28 +0000 (10:26 +0200)] 
fuzz: add test case that should already be resolved

3 years agocore: refresh unit cache when building a transaction if UNIT_NOT_FOUND
Luca Boccassi [Fri, 3 Jul 2020 17:45:19 +0000 (18:45 +0100)] 
core: refresh unit cache when building a transaction if UNIT_NOT_FOUND

When a command asks to load a unit directly and it is in state
UNIT_NOT_FOUND, and the cache is outdated, we refresh it and
attempto to load again.
Use the same logic when building up a transaction and a dependency in
UNIT_NOT_FOUND state is encountered.
Update the unit test to exercise this code path.

3 years agosleep: one spelling unification
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 08:02:02 +0000 (10:02 +0200)] 
sleep: one spelling unification

We use "writable" everywhere else.

3 years agoMerge pull request #16380 from yuwata/network-dhcp6-update-prefix-route
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 07:05:08 +0000 (09:05 +0200)] 
Merge pull request #16380 from yuwata/network-dhcp6-update-prefix-route

Network: update acquired dhcp6 prefix routes

3 years agoMerge pull request #16381 from yuwata/dhcp4-renewing
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 06:59:35 +0000 (08:59 +0200)] 
Merge pull request #16381 from yuwata/dhcp4-renewing

dhcp4: fixes around renewing address

3 years agoMerge pull request #16383 from yuwata/network-dhcp6-radv-update-prefix
Zbigniew Jędrzejewski-Szmek [Tue, 7 Jul 2020 06:53:31 +0000 (08:53 +0200)] 
Merge pull request #16383 from yuwata/network-dhcp6-radv-update-prefix

network: do not restart radv engine when adding prefix

3 years agohwdb: Add Google Pixel Slate (nocturne) (#16377)
satmandu [Tue, 7 Jul 2020 06:45:31 +0000 (02:45 -0400)] 
hwdb: Add Google Pixel Slate (nocturne) (#16377)

3 years agonetwork: fix memleak
Yu Watanabe [Tue, 7 Jul 2020 03:17:46 +0000 (12:17 +0900)] 
network: fix memleak

If init() is failed, the allocated memory was leaked.

3 years agonetwork: do not restart radv engine when adding prefix 16383/head
Yu Watanabe [Tue, 7 Jul 2020 02:19:49 +0000 (11:19 +0900)] 
network: do not restart radv engine when adding prefix

Replaces d469cea3bde53bc39317c8b433c825bb4790cbe5.

3 years agonetwork: fix indentation
Yu Watanabe [Tue, 7 Jul 2020 02:18:28 +0000 (11:18 +0900)] 
network: fix indentation

3 years agoRevert "network: Don't send RA with zero router lifetime when restarting radv"
Yu Watanabe [Tue, 7 Jul 2020 02:06:08 +0000 (11:06 +0900)] 
Revert "network: Don't send RA with zero router lifetime when restarting radv"

This reverts commit d469cea3bde53bc39317c8b433c825bb4790cbe5.

3 years agofix typo
Tomer Shechner [Tue, 7 Jul 2020 01:35:35 +0000 (04:35 +0300)] 
fix typo

I was thoroughly reading your nice coding style page and found out that you guys missed an 's'.

😁

3 years agonetwork: Don't send RA with zero router lifetime when restarting radv
Michael Marley [Sun, 5 Jul 2020 10:46:27 +0000 (06:46 -0400)] 
network: Don't send RA with zero router lifetime when restarting radv
While investigating https://github.com/systemd/systemd/issues/16356, I
discovered that networkd stops the radv service before adding or updating
prefixes and then starts it again.  This causes networkd to send an RA with
a router lifetime of zero, causing the routes to flap on systems receiving
the RA for a fraction of a second before radv is started again and proper
RAs are sent.  That has the potential to cause issues with latency-sensitive
traffic like gaming or VoIP.  This patch adds a boolean argument to the
sd_radv_stop() function to control this behavior.  The zero lifetime RA is
still sent whenever radv is actually being stopped, but when it is being
restarted for a prefix update (from networkd-dhcp6.c), the final RA is no
longer sent to avoid the route flapping.

3 years agodhcp4: do not try to renew address when client has no lease 16381/head
Yu Watanabe [Tue, 7 Jul 2020 01:04:42 +0000 (10:04 +0900)] 
dhcp4: do not try to renew address when client has no lease

3 years agodhcp4: do not renew address if client is not running yet
Yu Watanabe [Tue, 7 Jul 2020 00:43:10 +0000 (09:43 +0900)] 
dhcp4: do not renew address if client is not running yet

3 years agonetwork: always update acquired prefix route 16380/head
Yu Watanabe [Tue, 7 Jul 2020 00:20:39 +0000 (09:20 +0900)] 
network: always update acquired prefix route

Otherwise, routes become lifetime 0.

Fixes #16356.

3 years agonetwork: decrease indentation level
Yu Watanabe [Tue, 7 Jul 2020 00:14:21 +0000 (09:14 +0900)] 
network: decrease indentation level