]>
git.ipfire.org Git - thirdparty/systemd.git/log
Lennart Poettering [Mon, 3 Dec 2018 16:59:44 +0000 (17:59 +0100)]
Merge pull request #10920 from yuwata/hashmap-destructor
hashmap: make hashmap_free() call destructors of key or value
Lennart Poettering [Mon, 3 Dec 2018 16:55:00 +0000 (17:55 +0100)]
Merge pull request #10976 from yuwata/typesafe-netlink-call
netlink: introduce typesafe netlink functions
Yu Watanabe [Mon, 3 Dec 2018 09:22:05 +0000 (10:22 +0100)]
network: drop unnecessary buffers
Lennart Poettering [Mon, 3 Dec 2018 10:09:04 +0000 (11:09 +0100)]
Merge pull request #10992 from yuwata/follow-up-10948
network: make fib rule accept arbitrary ip protocol
Yu Watanabe [Sun, 2 Dec 2018 15:27:02 +0000 (16:27 +0100)]
missing: split network related entries
Also adds comments which kernel version added the entries.
Closes #10553.
Harald Hoyer [Mon, 3 Dec 2018 09:27:26 +0000 (10:27 +0100)]
sd-boot: remove Stall() call (#11029)
This is left-over from debugging.
Susant Sahani [Sun, 2 Dec 2018 13:04:06 +0000 (18:34 +0530)]
vxlan: minor coding style fixes.
Yu Watanabe [Sun, 2 Dec 2018 17:04:31 +0000 (02:04 +0900)]
Merge pull request #11011 from poettering/tmpfile-util
split up fileio.c a bit
Lennart Poettering [Sun, 2 Dec 2018 12:22:14 +0000 (13:22 +0100)]
resolved: sort headers again
Lennart Poettering [Fri, 30 Nov 2018 21:08:41 +0000 (22:08 +0100)]
util-lib: split out env file parsing code into env-file.c
It's quite complex, let's split this out.
No code changes, just some file rearranging.
Lennart Poettering [Fri, 30 Nov 2018 20:39:12 +0000 (21:39 +0100)]
util-lib: move open_serialization_fd() to serialize.c
It definitely fits better there.
No code changes, just some rearranging.
Lennart Poettering [Fri, 30 Nov 2018 20:12:50 +0000 (21:12 +0100)]
resolved: remove duplicate #include
Lennart Poettering [Fri, 30 Nov 2018 20:18:34 +0000 (21:18 +0100)]
test: remove duplicate #include
Lennart Poettering [Fri, 30 Nov 2018 20:05:27 +0000 (21:05 +0100)]
util-lib: split out all temporary file related calls into tmpfiles-util.c
This splits out a bunch of functions from fileio.c that have to do with
temporary files. Simply to make the header files a bit shorter, and to
group things more nicely.
No code changes, just some rearranging of source files.
Lennart Poettering [Fri, 30 Nov 2018 20:07:21 +0000 (21:07 +0100)]
util-lib: don't include fileio.h from fileio-label.h
There's no reason for doing that, hence simply don't.
Lennart Poettering [Fri, 30 Nov 2018 20:17:20 +0000 (21:17 +0100)]
test: remove unnecessary include
Lennart Poettering [Fri, 30 Nov 2018 20:15:57 +0000 (21:15 +0100)]
test: (void)ify unlink() call
Lennart Poettering [Fri, 30 Nov 2018 20:06:16 +0000 (21:06 +0100)]
fileio: remove unnecessary initialization
Lennart Poettering [Fri, 30 Nov 2018 20:05:49 +0000 (21:05 +0100)]
fileio: include ctype.h with <> rather than ""
It's a system header after all.
Yu Watanabe [Sun, 25 Nov 2018 19:42:36 +0000 (04:42 +0900)]
sysusers: define main through macro
This also fixes possible memleak when uid/gid or user/group name
in database are conflicted.
Yu Watanabe [Sun, 25 Nov 2018 19:41:53 +0000 (04:41 +0900)]
sysusers: use fgetgrent_sane()
Yu Watanabe [Sun, 25 Nov 2018 18:38:48 +0000 (03:38 +0900)]
lldp: rename lldp_neighbor_id_hash_ops and set value destructor
Yu Watanabe [Sun, 25 Nov 2018 18:32:20 +0000 (03:32 +0900)]
udev: use hashmap_clear_free_key() and hashmap_free_free_key()
Yu Watanabe [Wed, 28 Nov 2018 13:55:40 +0000 (22:55 +0900)]
portable: introduce portable_metadata_hash_ops and use it
Yu Watanabe [Wed, 28 Nov 2018 13:55:13 +0000 (22:55 +0900)]
machine: introduce machine_hash_ops and use it
Yu Watanabe [Wed, 28 Nov 2018 13:54:44 +0000 (22:54 +0900)]
machine-image: introduce image_hash_ops and use it
Yu Watanabe [Sun, 25 Nov 2018 16:00:54 +0000 (01:00 +0900)]
tmpfiles: define main through macro
Yu Watanabe [Sun, 25 Nov 2018 15:48:15 +0000 (00:48 +0900)]
tmpfiles: make load_unix_sockets() return negative errno on failure
Yu Watanabe [Sun, 25 Nov 2018 15:19:08 +0000 (00:19 +0900)]
cryptsetup-generator: define main through macro
Yu Watanabe [Sun, 25 Nov 2018 15:04:46 +0000 (00:04 +0900)]
sd-bus: introduce track_item_hash_ops and use it
Yu Watanabe [Sun, 25 Nov 2018 14:58:49 +0000 (23:58 +0900)]
dhcp: introduce dhcp_lease_hash_ops and use it
Yu Watanabe [Sun, 25 Nov 2018 14:55:30 +0000 (23:55 +0900)]
cgtop: use SWAP_TWO() macro
Yu Watanabe [Sun, 25 Nov 2018 14:54:19 +0000 (23:54 +0900)]
cgtop: introduce group_hash_ops and use it
Yu Watanabe [Sun, 25 Nov 2018 12:54:44 +0000 (21:54 +0900)]
test: add tests for destructors of hashmap or set
Yu Watanabe [Tue, 27 Nov 2018 13:25:40 +0000 (22:25 +0900)]
hash-func: add destructors for key and value
If they are set, then they are called in hashmap_clear() or
hashmap_free().
Yu Watanabe [Tue, 27 Nov 2018 13:25:20 +0000 (22:25 +0900)]
tree-wide: make hash_ops typesafe
Yu Watanabe [Sun, 2 Dec 2018 06:46:33 +0000 (07:46 +0100)]
hash-funcs: make basic hash_ops typesafe
Yu Watanabe [Wed, 28 Nov 2018 05:10:04 +0000 (14:10 +0900)]
hash-funcs: introduce macro to create typesafe hash_ops
Yu Watanabe [Tue, 27 Nov 2018 07:33:28 +0000 (16:33 +0900)]
util: define free_func_t
Yu Watanabe [Sun, 25 Nov 2018 13:01:10 +0000 (22:01 +0900)]
hashmap: fix minor coding style issue
Yu Watanabe [Wed, 28 Nov 2018 20:06:52 +0000 (21:06 +0100)]
network: use typesafe netlink_call_async() macro where applicable
Yu Watanabe [Sun, 2 Dec 2018 05:28:04 +0000 (06:28 +0100)]
network: rename ndisc_route_handler() to ndisc_netlink_message_handler()
As it is also called when configuring addresses.
Yu Watanabe [Wed, 28 Nov 2018 20:29:09 +0000 (21:29 +0100)]
network: add assertions
As they do not have default callback functions.
Yu Watanabe [Wed, 28 Nov 2018 20:22:42 +0000 (21:22 +0100)]
network: use route_remove_handler() as the default callback of route_remove()
Yu Watanabe [Wed, 28 Nov 2018 20:22:08 +0000 (21:22 +0100)]
network: use address_remove_handler() as the default callback of address_remove()
Yu Watanabe [Wed, 28 Nov 2018 20:18:16 +0000 (21:18 +0100)]
network: set default callbacks for routing_policy_rule_configure() and routing_policy_rule_remove()
Yu Watanabe [Wed, 28 Nov 2018 20:14:53 +0000 (21:14 +0100)]
network: move address_label_handler() to networkd-address-label.c
And use it as the default callback function of address_label_configure().
Yu Watanabe [Wed, 28 Nov 2018 19:48:34 +0000 (20:48 +0100)]
network: simplify dhcp6_get_prefix_delegation()
Yu Watanabe [Wed, 28 Nov 2018 16:05:32 +0000 (01:05 +0900)]
netlink: add typesafe netlink functions
Yu Watanabe [Wed, 28 Nov 2018 15:32:57 +0000 (00:32 +0900)]
macro: introduce DEFINE_TRIVIAL_DESTRUCTOR() macro
Yu Watanabe [Wed, 28 Nov 2018 15:28:53 +0000 (00:28 +0900)]
libsystemd: introduce _sd_destroy_t
Yu Watanabe [Fri, 30 Nov 2018 03:57:03 +0000 (04:57 +0100)]
core,run: make SocketProtocol= accept protocol name in upper case an protocol number
Yu Watanabe [Thu, 29 Nov 2018 15:43:40 +0000 (16:43 +0100)]
network: make IPProtocol= also accept IP protocol number
Yu Watanabe [Thu, 29 Nov 2018 15:42:39 +0000 (16:42 +0100)]
network: rename Protocol= in [RoutingPolicyRule] to IPProtocol=
Yu Watanabe [Thu, 29 Nov 2018 15:28:33 +0000 (16:28 +0100)]
test: add tests for ip_protocol_{from,to}_name()
Yu Watanabe [Thu, 29 Nov 2018 15:09:30 +0000 (16:09 +0100)]
util: introduce parse_ip_protocol()
Not only protocol name in lower case, but it optionally accepts
IP protocol name in upper case and IP protocol number.
Yu Watanabe [Sun, 2 Dec 2018 04:58:18 +0000 (05:58 +0100)]
util: cast smaller type to large type
Yu Watanabe [Thu, 29 Nov 2018 14:58:43 +0000 (15:58 +0100)]
util: rename socket_protocol_{from,to}_name() to ip_protocol_{from,to}_name()
Lennart Poettering [Fri, 30 Nov 2018 16:38:56 +0000 (17:38 +0100)]
tree-wide: remove various unused functions
All found with "cppcheck --enable=unusedFunction".
Evgeny Vereshchagin [Sun, 2 Dec 2018 00:54:21 +0000 (03:54 +0300)]
Merge pull request #11013 from evverx/travis-clang
travis: also build systemd with clang
Susant Sahani [Sat, 1 Dec 2018 09:44:35 +0000 (15:14 +0530)]
ip rule: fix clang warning.
```
[2/1209] Compiling C object 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o'.
FAILED: src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o
clang -Isrc/network/src@network@@networkd-core@sta -Isrc/network -I../src/network -Isrc/basic -I../src/basic -Isrc/shared -I../src/shared -Isrc/systemd -I../src/systemd -Isrc/journal -I../src/journal -Isrc/journal-remote -I../src/journal-remote -Isrc/nspawn -I../src/nspawn -Isrc/resolve -I../src/resolve -Isrc/timesync -I../src/timesync -I../src/time-wait-sync -Isrc/login -I../src/login -Isrc/udev -I../src/udev -Isrc/libudev -I../src/libudev -Isrc/core -I../src/core -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -Isrc/libsystemd-network -I../src/libsystemd-network -I. -I../ -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -O0 -g -Wextra -Werror=undef -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wfloat-equal -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=missing-declarations -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wmissing-noreturn -Wshadow -Wendif-labels -Wstrict-aliasing=2 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Wdate-time -Wnested-externs -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Wno-error=nonnull -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -fPIE -Wno-typedef-redefinition -Wno-gnu-variable-sized-type-not-at-end -Werror=shadow -include config.h -fPIC -MD -MQ 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o' -MF 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o.d' -o 'src/network/src@network@@networkd-core@sta/networkd-routing-policy-rule.c.o' -c ../src/network/networkd-routing-policy-rule.c
../src/network/networkd-routing-policy-rule.c:1071:33: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->sport.start, rule->sport.end);
^~~~~~~~~~~~~~~~~
../src/network/networkd-routing-policy-rule.c:1071:52: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->sport.start, rule->sport.end);
^~~~~~~~~~~~~~~
../src/network/networkd-routing-policy-rule.c:1078:33: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->dport.start, rule->dport.end);
^~~~~~~~~~~~~~~~~
../src/network/networkd-routing-policy-rule.c:1078:52: error: format specifies type 'unsigned char' but the argument has type '__u16' (aka 'unsigned short') [-Werror,-Wformat]
rule->dport.start, rule->dport.end);
^~~~~~~~~~~~~~~
4 errors generated.
```
Aleksei Timofeyev [Sat, 1 Dec 2018 09:10:08 +0000 (14:10 +0500)]
resolved: add missed io-util.h header to resolved-dnstls-openssl.c
Regression after commit
5cfa2c3dc09ffed1
Evgeny Vereshchagin [Fri, 30 Nov 2018 23:45:35 +0000 (00:45 +0100)]
travis: also build systemd with clang
Evgeny Vereshchagin [Sat, 1 Dec 2018 03:28:50 +0000 (04:28 +0100)]
travis: use latest instead of rawhide
Lennart Poettering [Fri, 30 Nov 2018 23:47:22 +0000 (00:47 +0100)]
Merge pull request #11006 from poettering/conf-file-fix
minor fixes for conf-files.c
Lennart Poettering [Fri, 30 Nov 2018 23:44:58 +0000 (00:44 +0100)]
Merge pull request #11002 from keszybz/path_join-merging
Path join merging
Lennart Poettering [Fri, 30 Nov 2018 23:01:11 +0000 (00:01 +0100)]
Merge pull request #11004 from keszybz/remove-fixme-comment
socket-util: drop obsolete FIXME comment and add test
Zbigniew Jędrzejewski-Szmek [Fri, 30 Nov 2018 10:06:24 +0000 (11:06 +0100)]
path-util: allow NULLs in arguments to path_join()
This removes the need to remember to put strempty() in places, thus reducing
the likelihood of a stupid mistake.
Lennart Poettering [Fri, 30 Nov 2018 18:34:17 +0000 (19:34 +0100)]
networkd: refuse IPv6 RADV prefixes that lack Prefix= setting
Fixes: #9589
Zbigniew Jędrzejewski-Szmek [Fri, 30 Nov 2018 10:54:42 +0000 (11:54 +0100)]
basic/socket-util: use c-escaping to print unprintable socket paths
We are pretty careful to reject abstract sockets that are too long to fit in
the address structure as a NUL-terminated string. And since we parse sockets as
strings, it is not possible to embed a NUL in the the address either. But we
might receive an external socket (abstract or not), and we want to be able to
print its address in all cases. We would call socket_address_verify() and
refuse to print various sockets that the kernel considers legit.
Let's do the strict verification only in case of socket addresses we parse and
open ourselves, and do less strict verification when printing addresses of
existing sockets, and use c-escaping to print embedded NULs and such.
More tests are added.
This should make LGTM happier because on FIXME comment is removed.
Zbigniew Jędrzejewski-Szmek [Fri, 30 Nov 2018 14:17:25 +0000 (15:17 +0100)]
shared/socket-util: do not print empty CID
That's just ugly.
Zbigniew Jędrzejewski-Szmek [Fri, 30 Nov 2018 14:13:32 +0000 (15:13 +0100)]
test-socket-util: add test for socket_address_print
Zbigniew Jędrzejewski-Szmek [Fri, 30 Nov 2018 13:23:19 +0000 (14:23 +0100)]
test-socket-util: the usual modernization
Lennart Poettering [Fri, 30 Nov 2018 18:41:59 +0000 (19:41 +0100)]
Merge pull request #10701 from poettering/analyze-security
systemd-analyze: add a new "security" verb for analyzing unit sandboxing options
Lennart Poettering [Fri, 30 Nov 2018 15:56:35 +0000 (16:56 +0100)]
conf-files: remove unused function
Lennart Poettering [Fri, 30 Nov 2018 15:55:57 +0000 (16:55 +0100)]
conf-files: remove misplaced log_oom()
The caller should log in this case (and all callers in fact already do),
hence let's remove the duplicate logging here.
Lennart Poettering [Fri, 30 Nov 2018 15:55:33 +0000 (16:55 +0100)]
conf-files: improve algorithm O(n²) → O(n)
Lennart Poettering [Wed, 7 Nov 2018 16:41:55 +0000 (17:41 +0100)]
update TODO
Lennart Poettering [Fri, 9 Nov 2018 11:19:30 +0000 (12:19 +0100)]
man: document systemd-analyze security
Lennart Poettering [Thu, 8 Nov 2018 08:32:17 +0000 (09:32 +0100)]
analyze: add new security verb
Lennart Poettering [Wed, 14 Nov 2018 17:39:37 +0000 (18:39 +0100)]
format-table: make sure we never call memcmp() with NULL parameters
Lennart Poettering [Fri, 9 Nov 2018 10:38:12 +0000 (11:38 +0100)]
format-table: add calls to query the data in a specific cell
Lennart Poettering [Thu, 8 Nov 2018 20:39:28 +0000 (21:39 +0100)]
format-table: always underline header line
Lennart Poettering [Thu, 8 Nov 2018 20:21:09 +0000 (21:21 +0100)]
format-table: add an API for getting the cell at a specific row/column
Lennart Poettering [Thu, 8 Nov 2018 20:17:47 +0000 (21:17 +0100)]
format-table: add table_update() to update existing entries
Lennart Poettering [Wed, 7 Nov 2018 16:41:32 +0000 (17:41 +0100)]
format-table: optionally allow reversing the sort order for a column
Lennart Poettering [Wed, 7 Nov 2018 14:25:51 +0000 (15:25 +0100)]
format-table: add option to store/format percent and uint64_t values in cells
Lennart Poettering [Tue, 6 Nov 2018 17:37:21 +0000 (18:37 +0100)]
format-table: before outputting a color, check if colors are available
This is in many cases redundant, as a similar check is done by various
callers already, but in other cases (where we read the color from a
static table for example), it's nice to let the color check be done by
the table code itself, and since it doesn't hurt in the other cases just
do it again.
Lennart Poettering [Tue, 6 Nov 2018 11:06:14 +0000 (12:06 +0100)]
format-table: optionally make specific cells clickable links
Lennart Poettering [Thu, 8 Nov 2018 20:16:23 +0000 (21:16 +0100)]
format-table: when duplicating a cell, also copy the color
Lennart Poettering [Wed, 7 Nov 2018 10:09:03 +0000 (11:09 +0100)]
terminal-util: split out file:// generation from terminal_urlify_path()
This way we can use it at other places, for example when preparing URLs
for format_table_set_url()
Lennart Poettering [Fri, 9 Nov 2018 10:37:21 +0000 (11:37 +0100)]
macro: update DIV_ROUND_UP() so that it can be called nested
Lennart Poettering [Tue, 6 Nov 2018 11:06:45 +0000 (12:06 +0100)]
parse-util: allow parse_boolean() to take a NULL argument
It's pretty useful to allow parse_boolean() to take a NULL argument and
return an error in that case, rather than abort. i.e. making this a
runtime rather than programming error allows us to shorten code
elsewhere.
Lennart Poettering [Tue, 6 Nov 2018 11:05:26 +0000 (12:05 +0100)]
analyze: use strv_skip() where appropriate
Lennart Poettering [Tue, 6 Nov 2018 11:04:23 +0000 (12:04 +0100)]
analyze: remove unnecessary negation of bus_error_message() error number parameter
Lennart Poettering [Tue, 6 Nov 2018 11:02:55 +0000 (12:02 +0100)]
analyze: fix include order
Lennart Poettering [Thu, 8 Nov 2018 19:13:54 +0000 (20:13 +0100)]
seccomp-util: drop process_vm_readv from @debug group
it's already part of @ipc, no need to have it in both. Given that @ipc
is much more popular (as it is part of @system-service for example),
let's not define it a second time.
Lennart Poettering [Tue, 6 Nov 2018 16:59:58 +0000 (17:59 +0100)]
locale-util: add logic to output smiley emojis at various happiness levels
Zbigniew Jędrzejewski-Szmek [Fri, 30 Nov 2018 09:43:57 +0000 (10:43 +0100)]
tree-wide: rename path_join_many() to path_join()
$ git grep -e path_join_many -l|xargs sed -r -i 's/path_join_many/path_join/g'
The two test functions are merged into one.
Zbigniew Jędrzejewski-Szmek [Fri, 30 Nov 2018 09:40:38 +0000 (10:40 +0100)]
tree-wide: replace path_join with path_join_many