10 months agoupdate TODO 16678/head
Lennart Poettering [Thu, 6 Aug 2020 08:41:20 +0000 (10:41 +0200)] 
update TODO

10 months agoloop-util: use new LOOP_CONFIGURE ioctl
Lennart Poettering [Thu, 6 Aug 2020 07:47:14 +0000 (09:47 +0200)] 
loop-util: use new LOOP_CONFIGURE ioctl

LOOP_CONFIGURE allows us to configure a loopback device in one ioctl
instead of two, which is not just faster but also removes the race that
udev might start probing the device before we adjusted things properly.

Unfortunately LOOP_CONFIGURE is broken in regards to LO_FLAGS_PARTSCAN
as of kernel 5.8.0. This patch contains a work-around for that, to
fallback to old behaviour if partition scanning is requested but does
not work. Sucks a bit.

Proposed upstream fix for that issue:

10 months agodissect: use new blockdev_partscan_enabled() API where appropriate
Lennart Poettering [Thu, 6 Aug 2020 08:35:29 +0000 (10:35 +0200)] 
dissect: use new blockdev_partscan_enabled() API where appropriate

10 months agoblockdev-util: add correct API for detecting if block device has partition scanning...
Lennart Poettering [Thu, 6 Aug 2020 08:31:19 +0000 (10:31 +0200)] 
blockdev-util: add correct API for detecting if block device has partition scanning enabled

Instead of checking the loopback ioctls, let's check sysfs, so that we
catch all kinds of block devices, not just loopback block devices.

10 months agoMerge pull request #16690 from poettering/userdb-group-desc
Anita Zhang [Tue, 11 Aug 2020 07:27:54 +0000 (00:27 -0700)] 
Merge pull request #16690 from poettering/userdb-group-desc

description field for group records

10 months agounits: order volatile-root after repart
Lennart Poettering [Mon, 10 Aug 2020 17:56:17 +0000 (19:56 +0200)] 
units: order volatile-root after repart

Let's make sure systemd-repart can still see the real device before we
replace its mount with an overlay mount, and thus order repart before


10 months agoMerge pull request #16697 from yuwata/network-fix-suspend-issue
Lennart Poettering [Mon, 10 Aug 2020 18:09:36 +0000 (20:09 +0200)] 
Merge pull request #16697 from yuwata/network-fix-suspend-issue

network: fix suspend issue

10 months agoMerge pull request #16684 from keszybz/assorted-cleanups
Lennart Poettering [Mon, 10 Aug 2020 17:28:05 +0000 (19:28 +0200)] 
Merge pull request #16684 from keszybz/assorted-cleanups

Assorted cleanups

10 months agohwdb: Add ACCEL_MOUNT_MATRIX quirk for Asus M80TA
Nicholas Narsing [Sun, 9 Aug 2020 04:43:26 +0000 (21:43 -0700)] 
hwdb: Add ACCEL_MOUNT_MATRIX quirk for Asus M80TA

10 months agonetwork: wait for previous address removal before configuring static addresses 16697/head
Yu Watanabe [Sat, 8 Aug 2020 03:36:18 +0000 (12:36 +0900)] 
network: wait for previous address removal before configuring static addresses

Fixes #16696.

10 months agonetwork: drop unnecessary bracket
Yu Watanabe [Sat, 8 Aug 2020 03:31:59 +0000 (12:31 +0900)] 
network: drop unnecessary bracket

10 months agonetwork: only process non-error message
Yu Watanabe [Sat, 8 Aug 2020 03:31:12 +0000 (12:31 +0900)] 
network: only process non-error message

10 months agoMerge pull request #16682 from poettering/userdb-gecos-fix
Lennart Poettering [Fri, 7 Aug 2020 20:57:41 +0000 (22:57 +0200)] 
Merge pull request #16682 from poettering/userdb-gecos-fix

userdb: mangle GECOS field if necessary

10 months agouser-record: deal with invalid GECOS fields gracefully 16682/head
Lennart Poettering [Thu, 6 Aug 2020 15:00:07 +0000 (17:00 +0200)] 
user-record: deal with invalid GECOS fields gracefully

Let's fix up invalid GECOS fields both when we convert from NSS to JSON
and the other way round.

Kinda sucks we have to do that, but NSS does it when writing data to
/etc/passwd, so let's do the same.

Fixes: #16668

10 months agouser-util: add mangle_gecos() call for turning strings into fields suitable as GECOS...
Lennart Poettering [Thu, 6 Aug 2020 14:46:18 +0000 (16:46 +0200)] 
user-util: add mangle_gecos() call for turning strings into fields suitable as GECOS fields

10 months agofix typo in systemctl help
Matt Fenwick [Fri, 7 Aug 2020 14:43:11 +0000 (10:43 -0400)] 
fix typo in systemctl help

10 months agoMerge pull request #16604 from poettering/tmpfiles-image
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2020 08:08:42 +0000 (10:08 +0200)] 
Merge pull request #16604 from poettering/tmpfiles-image

add --image= switch to tmpfiles, sysusers, journalctl

10 months agojournalctl: in "-o cat" mode show color
Lennart Poettering [Thu, 6 Aug 2020 22:00:26 +0000 (00:00 +0200)] 
journalctl: in "-o cat" mode show color

Let's provide a modicum of niceness, even in this barebones mode.

Fixes: #16232

10 months agounits: order systemd-user-sessions.service after home.mount
Lennart Poettering [Thu, 6 Aug 2020 21:33:29 +0000 (23:33 +0200)] 
units: order systemd-user-sessions.service after home.mount

This should make /home as automount work reasonably well.

If /home is an automount this has little effect at boot, because if the
automount is not triggered it doesn't matter how the associated mount is

It does matter at shutdown however, where home.mount is likely active
now. There the ordering means we'll end sessions first, and only then
deactivate home.mount.

Fixes: #16291

10 months agoupdate TODO 16690/head
Lennart Poettering [Thu, 6 Aug 2020 15:46:56 +0000 (17:46 +0200)] 
update TODO

10 months agodocs: document new description field
Lennart Poettering [Thu, 6 Aug 2020 15:44:57 +0000 (17:44 +0200)] 
docs: document new description field

Also, explain GECOS syntax requirements.

10 months agocore,home,machined: generate description fields for all groups we synthesize
Lennart Poettering [Thu, 6 Aug 2020 15:41:05 +0000 (17:41 +0200)] 
core,home,machined: generate description fields for all groups we synthesize

10 months agouserdb: add "description" field to group records
Lennart Poettering [Thu, 6 Aug 2020 15:35:34 +0000 (17:35 +0200)] 
userdb: add "description" field to group records

User records have the realname/gecos fields, groups never had that, but
it would really be useful to have it, hence let's add it with similar

We enforce the same syntax as for GECOS, since it's better to start with
strict rules and losen them later instead of the opposite.

10 months agoupdate TODO
Lennart Poettering [Thu, 6 Aug 2020 22:02:17 +0000 (00:02 +0200)] 
update TODO

10 months agoman: clarify that LogNamespace= is for system services only
Lennart Poettering [Thu, 6 Aug 2020 13:27:00 +0000 (15:27 +0200)] 
man: clarify that LogNamespace= is for system services only

Fixes: #16638

10 months agoMerge pull request #16321 from bluca/mount_images
Zbigniew Jędrzejewski-Szmek [Thu, 6 Aug 2020 16:23:03 +0000 (18:23 +0200)] 
Merge pull request #16321 from bluca/mount_images

core: new feature MountImages

10 months ago_sd-common.h: avoid parsing errors with Coverity
Kamil Dudka [Wed, 5 Aug 2020 21:53:40 +0000 (23:53 +0200)] 
_sd-common.h: avoid parsing errors with Coverity

The commit 1070d271fa8fa553d57dd5f74dd1e3f60732d0b9 which was supposed
too fix this does not seem to take effect any more.  We get again 34%
compilation success rate while scanning systemd itself.  Moreover, the
installed header file breaks compilation of programs that include it:

"/usr/include/systemd/_sd-common.h", line 23: error #35: #error directive: "Do
          not include _sd-common.h directly; it is a private header."
  #  error "Do not include _sd-common.h directly; it is a private header."

10 months agoupdate TODO
Lennart Poettering [Thu, 6 Aug 2020 12:08:25 +0000 (14:08 +0200)] 
update TODO

10 months agocore: new feature MountImages 16321/head
Luca Boccassi [Tue, 14 Jul 2020 15:18:41 +0000 (16:18 +0100)] 
core: new feature MountImages

Follows the same pattern and features as RootImage, but allows an
arbitrary mount point under / to be specified by the user, and
multiple values - like BindPaths.

Original implementation by @topimiettinen at:
Reworked to use dissect's logic instead of bare libmount() calls
and other review comments.
Thanks Topi for the initial work to come up with and implement
this useful feature.

10 months agostrv: add strv_split_colon_pairs function
Luca Boccassi [Tue, 7 Jul 2020 16:12:48 +0000 (17:12 +0100)] 
strv: add strv_split_colon_pairs function

Given a string in the format 'one:two three four:five', returns a string
vector with each word. If the second element of the tuple is not
present, an empty string is returned in its place, so that the vector
can be processed in pairs.

This way we do escaping exactly once and in normal strict mode.]

10 months agobasic/extract-word: add EXTRACT_UNESCAPE_SEPARATORS mode
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 17:06:16 +0000 (19:06 +0200)] 
basic/extract-word: add EXTRACT_UNESCAPE_SEPARATORS mode

This allows separators to be escaped, for example to allow
"a\:b:c", to be treated as "a:b", "c" with ":" as the separator.

10 months agoupdate TODO 16604/head
Lennart Poettering [Tue, 28 Jul 2020 16:31:48 +0000 (18:31 +0200)] 
update TODO

10 months agoman: document the new --image= switches in journalctl/sysusers/tmpfiles
Lennart Poettering [Tue, 28 Jul 2020 17:28:43 +0000 (19:28 +0200)] 
man: document the new --image= switches in journalctl/sysusers/tmpfiles

10 months agojournalctl: add --image= switch
Lennart Poettering [Tue, 28 Jul 2020 17:18:05 +0000 (19:18 +0200)] 
journalctl: add --image= switch

10 months agosysusers: add support for a --image= switch
Lennart Poettering [Tue, 28 Jul 2020 16:32:07 +0000 (18:32 +0200)] 
sysusers: add support for a --image= switch

10 months agotmpfiles: support --image= similar to --root=
Lennart Poettering [Tue, 28 Jul 2020 16:22:53 +0000 (18:22 +0200)] 
tmpfiles: support --image= similar to --root=

10 months agofirstboot: move --image= logic into common code
Lennart Poettering [Tue, 28 Jul 2020 16:16:19 +0000 (18:16 +0200)] 
firstboot: move --image= logic into common code

That way we can reuse it in tmpfiles/sysusers/journalctl and so on.

10 months agotest: add another test case for extract_many_words
Luca Boccassi [Tue, 7 Jul 2020 16:10:47 +0000 (17:10 +0100)] 
test: add another test case for extract_many_words

Covers some functionality that we want to use for config tuples

10 months agotmpfiles: properly prefix paths in debug outputs
Lennart Poettering [Tue, 28 Jul 2020 15:53:21 +0000 (17:53 +0200)] 
tmpfiles: properly prefix paths in debug outputs

This is otherwise very confusing...

10 months agotmpfiles: we don't support the combination of --root and --user, hence refuse it
Lennart Poettering [Tue, 28 Jul 2020 15:52:48 +0000 (17:52 +0200)] 
tmpfiles: we don't support the combination of --root and --user, hence refuse it

--user only really works with certain env vars such as XDG_RUNTIME_DIR
set, but that's just weird if --root= is used.

10 months agotmpfiles: add new switch -E for quickly excluding /proc, /dev, /sys and /run
Lennart Poettering [Tue, 28 Jul 2020 15:52:23 +0000 (17:52 +0200)] 
tmpfiles: add new switch -E for quickly excluding /proc, /dev, /sys and /run

10 months agoanalyze: fix 'cat-config systemd/zram-generator.conf'
Zbigniew Jędrzejewski-Szmek [Sat, 1 Aug 2020 10:25:56 +0000 (12:25 +0200)] 
analyze: fix 'cat-config systemd/zram-generator.conf'

Also makes this work for various systemd config files that support .d.

10 months agoselinux: improve comment about getcon_raw semantics
Axel Rasmussen [Mon, 3 Aug 2020 16:19:49 +0000 (09:19 -0700)] 
selinux: improve comment about getcon_raw semantics

This code was changed in this pull request:

After some discussion and more investigation, we better understand
what's going on. So, update the comment, so things are more clear
to future readers.

10 months agoUpdate
Marc Kleine-Budde [Wed, 5 Aug 2020 12:10:21 +0000 (14:10 +0200)] 

This patch fixes a typo in the link to the systemd-id128 documentation.

10 months agoman: fix typo 16684/head
Zbigniew Jędrzejewski-Szmek [Wed, 5 Aug 2020 17:44:53 +0000 (19:44 +0200)] 
man: fix typo

10 months agodocs: rework awkward sentence in AUTOMATIC_BOOT_ASSESSMENT
Zbigniew Jędrzejewski-Szmek [Wed, 5 Aug 2020 17:44:37 +0000 (19:44 +0200)] 
docs: rework awkward sentence in AUTOMATIC_BOOT_ASSESSMENT

10 months agobless-boot: add missing verb to --help
Zbigniew Jędrzejewski-Szmek [Wed, 5 Aug 2020 10:16:03 +0000 (12:16 +0200)] 
bless-boot: add missing verb to --help

There is also "help" verb which duplicates the --help option. I don't
think we should advertise it.

10 months agotest-nss: do not assume all symbols are defined
Zbigniew Jędrzejewski-Szmek [Tue, 4 Aug 2020 18:14:00 +0000 (20:14 +0200)] 
test-nss: do not assume all symbols are defined

It is OK for some symbols to be missing. With this change, "test-nss sss" can
be used to test nss-sss without crashing.

$ build-rawhide/test-nss sss
======== sss ========
_nss_sss_gethostbyname4_r not defined

_nss_sss_gethostbyname3_r not defined

_nss_sss_gethostbyname3_r not defined

_nss_sss_gethostbyname3_r not defined

_nss_sss_gethostbyname3_r not defined

_nss_sss_gethostbyname2_r("", AF_INET) → status=NSS_STATUS_NOTFOUND
                   errno=0/--- h_errno=-1/Resolver internal error

_nss_sss_gethostbyname2_r("", AF_INET6) → status=NSS_STATUS_NOTFOUND
                   errno=0/--- h_errno=-1/Resolver internal error

_nss_sss_gethostbyname2_r("", *) → status=NSS_STATUS_UNAVAIL
                   errno=97/EAFNOSUPPORT h_errno=-1/Resolver internal error

_nss_sss_gethostbyname2_r("", AF_UNIX) → status=NSS_STATUS_UNAVAIL
                   errno=97/EAFNOSUPPORT h_errno=-1/Resolver internal error

_nss_sss_gethostbyname_r("") → status=NSS_STATUS_NOTFOUND
                   errno=0/--- h_errno=-1/Resolver internal error

10 months agotest-seccomp: minor simpification
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 15:46:48 +0000 (17:46 +0200)] 
test-seccomp: minor simpification

10 months agotest-nss: modernize a bit and print path to the loaded so file
Zbigniew Jędrzejewski-Szmek [Tue, 4 Aug 2020 15:47:00 +0000 (17:47 +0200)] 
test-nss: modernize a bit and print path to the loaded so file

This makes it easier to figure out if we're looking at the right

10 months agojournalctl: reshuffle console message about fss keys
Zbigniew Jędrzejewski-Szmek [Tue, 4 Aug 2020 13:20:08 +0000 (15:20 +0200)] 
journalctl: reshuffle console message about fss keys

We talked about the verification key, then about sealing keys, and then
about the verification key again. Let's shorten things a bit, and divide
the output in three paragraphs: one about the machine, one about the sealing
keys, and one about verification keys and the qr code with them.

10 months agoMerge pull request #16556 from keszybz/test-terminal-colors
Lennart Poettering [Wed, 5 Aug 2020 07:35:16 +0000 (09:35 +0200)] 
Merge pull request #16556 from keszybz/test-terminal-colors

Test terminal colors

10 months agoMerge pull request #16650 from keszybz/two-doc-updates
Anita Zhang [Wed, 5 Aug 2020 01:05:38 +0000 (18:05 -0700)] 
Merge pull request #16650 from keszybz/two-doc-updates

Two doc updates

10 months agoMerge pull request #16652 from eliroca/adapt-tests-for-SUSE
Zbigniew Jędrzejewski-Szmek [Tue, 4 Aug 2020 15:13:28 +0000 (17:13 +0200)] 
Merge pull request #16652 from eliroca/adapt-tests-for-SUSE

Adapt tests to work on SUSE

10 months agoupdate TODO
Lennart Poettering [Tue, 4 Aug 2020 14:46:19 +0000 (16:46 +0200)] 
update TODO

10 months agoMerge pull request #16596 from poettering/event-time-rel
Zbigniew Jędrzejewski-Szmek [Tue, 4 Aug 2020 14:07:03 +0000 (16:07 +0200)] 
Merge pull request #16596 from  poettering/event-time-rel

Conflict in src/libsystemd-network/test-ndisc-rs.c fixed manually.

10 months agoMerge pull request #16260 from poettering/pcre2-dlopen
Zbigniew Jędrzejewski-Szmek [Tue, 4 Aug 2020 13:37:48 +0000 (15:37 +0200)] 
Merge pull request #16260 from poettering/pcre2-dlopen

turn pcre2 dependency into dlopen() dependency

10 months agoMerge pull request #16145 from poettering/qrcode-dlopen
Zbigniew Jędrzejewski-Szmek [Tue, 4 Aug 2020 13:25:50 +0000 (15:25 +0200)] 
Merge pull request #16145 from poettering/qrcode-dlopen

journalctl: make libqrencode a weak (dlopen() style) dependency

10 months agohome: use ID128_UUID_STRING_MAX where appropriate
Lennart Poettering [Tue, 4 Aug 2020 06:57:13 +0000 (08:57 +0200)] 
home: use ID128_UUID_STRING_MAX where appropriate

10 months agodocs: spelling fixes
Joerg Behrmann [Tue, 4 Aug 2020 09:31:44 +0000 (11:31 +0200)] 
docs: spelling fixes

10 months agoupdate TODO
Lennart Poettering [Tue, 4 Aug 2020 06:56:46 +0000 (08:56 +0200)] 
update TODO

10 months agocore: reset bus error before reuse
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 09:39:25 +0000 (11:39 +0200)] 
core: reset bus error before reuse

From a report in Failed to load configuration: No such file or directory Failed to load configuration: No such file or directory Trying to enqueue job Failed to load configuration: No such file or directory
Assertion '!bus_error_is_dirty(e)' failed at src/libsystemd/sd-bus/bus-error.c:239, function bus_error_setfv(). Ignoring.
sys-devices-platform-soc-2100000.bus-2184000.usb-ci_hdrc.0-udc-ci_hdrc.0.device: Failed to enqueue SYSTEMD_WANTS= job, ignoring: Unit not found.

I *think* this is the place where the reuse occurs: we call
bus_unit_validate_load_state(unit, e) twice in a row.

10 months agotest: adapt TEST-13-NSPAWN-SMOKE for SUSE 16652/head
Elisei Roca [Mon, 3 Aug 2020 15:41:29 +0000 (17:41 +0200)] 
test: adapt TEST-13-NSPAWN-SMOKE for SUSE

10 months agotest: adapt TEST-21-SYSUSERS for SUSE
Elisei Roca [Wed, 29 Jul 2020 20:03:58 +0000 (22:03 +0200)] 
test: adapt TEST-21-SYSUSERS for SUSE

10 months agoMerge pull request #16595 from bengal/bg/dhcpv6-fqdn
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 13:17:00 +0000 (15:17 +0200)] 
Merge pull request #16595 from bengal/bg/dhcpv6-fqdn

dhcp6: parse the FQDN option

10 months agodoc: Put proot under "container" section
Chris Down [Mon, 3 Aug 2020 10:35:11 +0000 (11:35 +0100)] 
doc: Put proot under "container" section

Missed in #15426. Otherwise, it ends up only taking the first two rows
of the table, in no section.

10 months agodocs: reword intro in DISCOVERABLE PARTITIONS 16650/head
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 12:49:24 +0000 (14:49 +0200)] 
docs: reword intro in DISCOVERABLE PARTITIONS

This specification is useful independently of UEFI, so avoid making assertions
about UEFI. Also reword the intro to say what this is about in the very first
sentence. Closes #16570.

10 months agoman: describe that changing Storage= does not move existing data
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 11:22:01 +0000 (13:22 +0200)] 
man: describe that changing Storage= does not move existing data

Fixes #16384.

10 months agoMerge pull request #16258 from hunger/master
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 08:05:32 +0000 (10:05 +0200)] 
Merge pull request #16258 from hunger/master

systemd-repart: Add an option to generate a JSON report

10 months agoMerge pull request #16308 from bluca/root_image_options
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 08:04:36 +0000 (10:04 +0200)] 
Merge pull request #16308 from bluca/root_image_options

service: add new RootImageOptions feature

10 months agomachine: Pass machine, user, program values to polkit on OpenMachineShell
Marti Raudsepp [Thu, 23 Jul 2020 16:17:38 +0000 (19:17 +0300)] 
machine: Pass machine, user, program values to polkit on OpenMachineShell

This allows more granular access control in PolicyKit rules, similar to
/etc/sudoers, for polkit actions:

Example configuration, place in /etc/polkit-1/rules.d/

polkit.addRule(function(action, subject) {
    if ( == ""
        && subject.user == "my-user"
        && action.lookup("user") == "target-user") {
            return polkit.Result.YES;

10 months agoMerge pull request #16609 from poettering/initrd-unit-fixes
Zbigniew Jędrzejewski-Szmek [Mon, 3 Aug 2020 08:01:30 +0000 (10:01 +0200)] 
Merge pull request #16609 from poettering/initrd-unit-fixes

units: some initrd unit fixes

10 months agokernel-install/90-loaderentry: fix when /boot is not mountpoint
Kir Kolyshkin [Sat, 1 Aug 2020 02:24:15 +0000 (19:24 -0700)] 
kernel-install/90-loaderentry: fix when /boot is not mountpoint

I happen to have a machine where /boot is not a separate mountpoint,
but rather just a directory under /. After upgrade to recent Fedora,
I found out that grub2 can't find any new kernels.

This happens because loadentry script generates kernel and initrd file
paths relative to /boot, while grub2 expects path to be relative to the
root of filesystem on which they are residing.

This commit fixes this issue by using stat's %m to find the mount point
of a partition holding the images, and using it as a prefix to be
removed from ENTRY_DIR_ABS.

Note that %m for stat requires coreutils 8.6, released in Oct 2010.

Signed-off-by: Kir Kolyshkin <>
10 months agonspawn: Fix incorrect usage of putenv
Daan De Meyer [Sat, 1 Aug 2020 14:05:01 +0000 (15:05 +0100)] 
nspawn: Fix incorrect usage of putenv

strv_env_get only returns the environment variable value. putenv expects
KEY=VALUE format strings. Use setenv instead to fix the use.

10 months agodhcp6: parse the FQDN option 16595/head
Beniamino Galvani [Tue, 28 Jul 2020 05:48:11 +0000 (07:48 +0200)] 
dhcp6: parse the FQDN option

Parse option 39 (Client Fully Qualified Domain Name, RFC 4704) from the DHCP
reply, which specifies the FQDN assigned by the server to the client.

10 months agotest: convert ubuntu-ci to use deny-list
Dan Streetman [Fri, 10 Jul 2020 20:13:31 +0000 (16:13 -0400)] 
test: convert ubuntu-ci to use deny-list

Follows #16262

10 months agoman: fix typo in systemd.service
Etienne Doms [Sat, 1 Aug 2020 10:47:17 +0000 (12:47 +0200)] 
man: fix typo in systemd.service

10 months agonetwork: fix DHCPv6 Prefix Delegation example after option rename
Florian Klink [Fri, 31 Jul 2020 09:35:15 +0000 (11:35 +0200)] 
network: fix DHCPv6 Prefix Delegation example after option rename

99e015e28c8322bf714f45cd1defcf20ac2103c5 missed to update the example
below - DHCPv6.AssignAcquiredDelegatedPrefixAddress was moved to

As it already defaulted to true since it's introduction in
9efa8a3cff9948d3a78597b74dca75c805716de4, there's no need to explicitly
list it at all.

10 months agoNEWS: last rites v246
Zbigniew Jędrzejewski-Szmek [Thu, 30 Jul 2020 18:57:50 +0000 (20:57 +0200)] 
NEWS: last rites

10 months agoloop-device: implicitly sync device on detach
Lennart Poettering [Thu, 30 Jul 2020 16:42:13 +0000 (18:42 +0200)] 
loop-device: implicitly sync device on detach

Apparently, if IO is still in flight at the moment we invoke LOOP_CLR_FD
it is likely simply dropped (probably because yanking physical storage,
such as a USB stick would drop it too). Let's protect ourselves against
that and always sync explicitly before we invoke it.

10 months agoMerge pull request #16624 from keszybz/timesync-retry-interval
Zbigniew Jędrzejewski-Szmek [Thu, 30 Jul 2020 18:47:41 +0000 (20:47 +0200)] 
Merge pull request #16624 from keszybz/timesync-retry-interval

Make timesyncd retry interval grow more slowly

10 months agoudev: fix codesonar warnings
Amitanand.Chikorde [Thu, 30 Jul 2020 13:18:48 +0000 (18:48 +0530)] 
udev: fix codesonar warnings

Fixed below systemd codesonar warning.
isprint() is invoked here with an argument of signed
type char, but only has defined behavior for int arguments that are
either representable as unsigned char or equal to the value
of macro EOF(-1).

As per codesonar report, in a number of libc implementations, isprint()
function implemented using lookup tables (arrays): passing in a
negative value can result in a read underrun.

10 months agopid1: stop limiting size of /dev/shm
Zbigniew Jędrzejewski-Szmek [Thu, 30 Jul 2020 11:36:10 +0000 (13:36 +0200)] 
pid1: stop limiting size of /dev/shm

The explicit limit is dropped, which means that we return to the kernel default
of 50% of RAM. See 362a55fc14 for a discussion why that is not as much as it
seems. It turns out various applications need more space in /dev/shm and we
would break them by imposing a low limit.

While at it, rename the define and use a single macro for various tmpfs mounts.
We don't really care what the purpose of the given tmpfs is, so it seems
reasonable to use a single macro.

This effectively reverts part of 7d85383edbab7. Fixes #16617.

10 months agopath-util: make use of TAKE_PTR() where we can
Lennart Poettering [Wed, 29 Jul 2020 17:09:48 +0000 (19:09 +0200)] 
path-util: make use of TAKE_PTR() where we can

10 months agohwdb: Add EliteBook to use micmute hotkey
Kai-Heng Feng [Tue, 16 Jun 2020 05:24:27 +0000 (13:24 +0800)] 
hwdb: Add EliteBook to use micmute hotkey

Like HP ZBooks, all EliteBooks use the same micmute scancode.

10 months agotest-repart: also print json output 16258/head
Zbigniew Jędrzejewski-Szmek [Thu, 30 Jul 2020 14:03:53 +0000 (16:03 +0200)] 
test-repart: also print json output

This doesn't really "test" anything, but a human can look at it.

10 months agorepart: adjust --help and test output width
Zbigniew Jędrzejewski-Szmek [Thu, 30 Jul 2020 14:02:45 +0000 (16:02 +0200)] 
repart: adjust --help and test output width

10 months agorepart: log fixes
Lennart Poettering [Wed, 29 Jul 2020 17:20:39 +0000 (19:20 +0200)] 
repart: log fixes

10 months agotimesync: increase retry interval more slowly 16624/head
Zbigniew Jędrzejewski-Szmek [Thu, 30 Jul 2020 13:15:11 +0000 (15:15 +0200)] 
timesync: increase retry interval more slowly

The new retry intervals are [15, 20, 26, 34, 45, 60, 80, 106, 141, 188, 250,
333, 360, ...]. This should allow graceful response if a transient network
failure is encountered. Growth is exponential, but with a small power and
capped to a non-too-large value so that we resynchronize within a few minutes
after network is restored. I made the minimum 15 s to make sure that we never
send packets more often than that.

Fixes #16492.

10 months agobasic/terminal-util: rename our replacement highlight-yellow and test both the origin... 16556/head
Zbigniew Jędrzejewski-Szmek [Thu, 23 Jul 2020 08:53:48 +0000 (10:53 +0200)] 
basic/terminal-util: rename our replacement highlight-yellow and test both the original and replacement

The fact that we cannot use the "real" yellow color and need to use some other
color is essentially a bug. In this particular case the issue is in urxvt, see
a9009769de43b7f29d05017f4219e18c1e42a273. While we work around this by using a
different color, let's not forget that this is just a (hopefullly temporary)

10 months agotest-terminal-util: print paragraphs of text in different colors
Zbigniew Jędrzejewski-Szmek [Thu, 23 Jul 2020 08:14:20 +0000 (10:14 +0200)] 
test-terminal-util: print paragraphs of text in different colors

10 months agoadded alternative version of SurfTab Twin
Benjamin Dahlhoff [Wed, 29 Jul 2020 18:02:55 +0000 (20:02 +0200)] 
added alternative version of SurfTab Twin

10 months agoRepart: Add support for machine readably report
Tobias Hunger [Sun, 28 Jun 2020 16:19:05 +0000 (18:19 +0200)] 
Repart: Add support for machine readably report

Add --json command line argument that prints all relevant information
in a machine-readable format.

10 months agonetwork: fix use of uninitialized value
Yu Watanabe [Thu, 30 Jul 2020 03:45:36 +0000 (12:45 +0900)] 
network: fix use of uninitialized value

Follow-up for 6e537f62d71edea5bfcd2e2675c35ee840ffdc1f.

10 months agonetwork: Fix "Unknown section 'DHCPv6PrefixDelegation'." message
Michael Marley [Wed, 29 Jul 2020 19:13:35 +0000 (15:13 -0400)] 
network: Fix "Unknown section 'DHCPv6PrefixDelegation'." message

Follow-up for

10 months agoNEWS: mention about [DHCPv6PrefixDelegation] section
Yu Watanabe [Wed, 29 Jul 2020 16:02:52 +0000 (01:02 +0900)] 
NEWS: mention about [DHCPv6PrefixDelegation] section

Follow-up for 99e015e28c8322bf714f45cd1defcf20ac2103c5.

10 months agomeson: run 'ninja man/update-man-rules' again
Lennart Poettering [Wed, 29 Jul 2020 13:50:22 +0000 (15:50 +0200)] 
meson: run 'ninja man/update-man-rules' again

10 months agoservice: add new RootImageOptions feature 16308/head
Luca Boccassi [Mon, 29 Jun 2020 12:19:31 +0000 (13:19 +0100)] 
service: add new RootImageOptions feature

Allows to specify mount options for RootImage.
In case of multi-partition images, the partition number can be prefixed
followed by colon. Eg:

RootImageOptions=1:ro,dev 2:nosuid nodev

In absence of a partition number, 0 is assumed.

10 months agobasic/list: add LIST_JOIN helper
Luca Boccassi [Fri, 17 Jul 2020 17:26:51 +0000 (18:26 +0100)] 
basic/list: add LIST_JOIN helper

Joins together two lists, tail to head.

a -> b
c -> d

a -> b -> c -> d

10 months agoman: fix link markup
Lennart Poettering [Wed, 29 Jul 2020 15:37:33 +0000 (17:37 +0200)] 
man: fix link markup