]>
git.ipfire.org Git - thirdparty/systemd.git/log
Tom Gundersen [Thu, 10 Mar 2016 13:38:42 +0000 (14:38 +0100)]
Merge pull request #2818 from vinaykul/master
DHCP DUID and IAID configurability
Daniel Mack [Thu, 10 Mar 2016 12:43:48 +0000 (13:43 +0100)]
Merge pull request #2820 from lnykryn/test-ipcrm
test-ipcrm: fix log message
Daniel Mack [Thu, 10 Mar 2016 12:31:59 +0000 (13:31 +0100)]
Merge pull request #2819 from bachradsusi/mac_selinux_bind-do-not-rely-on-errno
socket_address_listen - do not rely on errno
Lukas Nykryn [Thu, 10 Mar 2016 11:43:00 +0000 (12:43 +0100)]
test-ipcrm: fix log message
Petr Lautrbach [Thu, 10 Mar 2016 09:19:56 +0000 (10:19 +0100)]
socket_address_listen - do not rely on errno
Currently socket_address_listen() calls mac_selinux_bind() to bind a UNIX
socket and checks its return value and errno for EADDRINUSE. This is not
correct. When there's an SELinux context change made for the new socket,
bind() is not the last function called in mac_selinux_bind(). In that
case the last call is setfscreatecon() from libselinux which can change
errno as it uses access() to check if /proc/thread-self is available.
It fails on kernels before 3.17 and errno is set to ENOENT.
It's safe to check only the return value at it's set to -errno.
Vinay Kulkarni [Thu, 10 Mar 2016 05:58:44 +0000 (21:58 -0800)]
DHCP DUID and IAID configurability
Zbigniew Jędrzejewski-Szmek [Thu, 10 Mar 2016 04:53:54 +0000 (23:53 -0500)]
Merge pull request #2792 from ronnychevalier/rc/tests_movev2
tests: move out unrelated tests from test-util to their own file
Zbigniew Jędrzejewski-Szmek [Thu, 10 Mar 2016 04:47:00 +0000 (23:47 -0500)]
Merge pull request #2816 from rhatdan/selinux
/dev/console must be labeled with SELinux label in containers
Zbigniew Jędrzejewski-Szmek [Thu, 10 Mar 2016 04:41:24 +0000 (23:41 -0500)]
Merge pull request #2793 from fbuihuu/fstab-generator-automount-option
fstab-generator: fix automounts to not mount automatically
Martin Pitt [Wed, 9 Mar 2016 17:21:42 +0000 (18:21 +0100)]
Merge pull request #2755 from keszybz/more-tests
Enable more tests by default, and even more with `--enable-tests=unsafe`
Dan Walsh [Wed, 9 Mar 2016 14:29:25 +0000 (09:29 -0500)]
/dev/console must be labeled with SELinux label
If the user specifies an selinux_apifs_context all content created in
the container including /dev/console should use this label.
Currently when this uses the default label it gets labeled user_devpts_t,
which would require us to write a policy allowing container processes to
manage user_devpts_t. This means that an escaped process would be allowed
to attack all users terminals as well as other container terminals. Changing
the label to match the apifs_context, means the processes would only be allowed
to manage their specific tty.
This change fixes a problem preventing RKT containers from working with systemd-nspawn.
Daniel Mack [Mon, 7 Mar 2016 13:50:08 +0000 (14:50 +0100)]
Merge pull request #2768 from benjarobin/fix-2718
systemctl: Replace check_one_unit() by get_state_one_unit()
Ronny Chevalier [Sun, 6 Mar 2016 20:20:49 +0000 (21:20 +0100)]
Merge pull request #2803 from 0xAX/lacess-tree-wide
firstboot: use laccess macro instead of facessat()
Alexander Kuleshov [Sun, 6 Mar 2016 07:27:59 +0000 (13:27 +0600)]
firstboot: use laccess macro instead of facessat()
Zbigniew Jędrzejewski-Szmek [Sat, 5 Mar 2016 16:22:45 +0000 (11:22 -0500)]
README: bump kernel version to 3.12
It is required for %P is sysctl kernel.core_pattern.
Fixes #2800.
Zbigniew Jędrzejewski-Szmek [Sat, 5 Mar 2016 15:31:04 +0000 (10:31 -0500)]
Merge pull request #2791 from 0xAX/clear-flag-macro
tree-wide: use SET_FLAG() macro to make code more clear
Zbigniew Jędrzejewski-Szmek [Sat, 5 Mar 2016 15:19:25 +0000 (10:19 -0500)]
Merge pull request #2795 from jhol/replace-irreversibly-on-failure
core/failure-action: set job-modes to replace-irreversibly
Zbigniew Jędrzejewski-Szmek [Sat, 5 Mar 2016 15:16:50 +0000 (10:16 -0500)]
Merge pull request #2801 from ronnychevalier/rc/systemctl_error_msg
systemctl: improve error message when starting a unit failed
Alexander Kuleshov [Thu, 3 Mar 2016 17:30:37 +0000 (23:30 +0600)]
tree-wide: use SET_FLAG() macro to make code more clear
Ronny Chevalier [Sat, 5 Mar 2016 11:47:21 +0000 (12:47 +0100)]
systemctl: improve error message when starting a unit failed
Fixes #2798
Zbigniew Jędrzejewski-Szmek [Sat, 5 Mar 2016 02:46:47 +0000 (21:46 -0500)]
test-compress-benchmark: skip loop iteration if size is 0
Otherwise we would hit an assert in the compression code.
Zbigniew Jędrzejewski-Szmek [Thu, 3 Mar 2016 16:39:02 +0000 (11:39 -0500)]
test-selinux: use yes_no() and strnull()
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 20:43:41 +0000 (15:43 -0500)]
networkctl: avoid reading past end of input buffer
name is IFNAMSIZ bytes, but we would copy sizeof(info->name) bytes,
which is IFNAMSIZ + 1. In effect we would go outside of the source
buffer and possibly leave a non-null terminated string in info->name.
CID #
1351754 .
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 20:43:30 +0000 (15:43 -0500)]
networkctl: use ETHER_ADDR_NULL in one more place
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 20:29:36 +0000 (15:29 -0500)]
lldp: fix memleak
in_addr_to_string returned 0, which was treated as error by the calling
code, which expects 1 on success.
CID #
1351757 , #
1351758 .
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 02:50:41 +0000 (21:50 -0500)]
test-journal-enum: enable by default
It will get at most ten values, I don't know why we wouldn't
always run this test.
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 02:44:08 +0000 (21:44 -0500)]
test-libudev: disable monitor mode by default and add to automatic tests
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 02:40:56 +0000 (21:40 -0500)]
test-libudev: modernization
Zbigniew Jędrzejewski-Szmek [Sat, 27 Feb 2016 15:35:46 +0000 (10:35 -0500)]
build-sys: ignore Python 2 bytecode files
We ignored __pycache__ which works for Python 3, but the rule
for Python 2 got lost somehow.
Zbigniew Jędrzejewski-Szmek [Fri, 26 Feb 2016 23:39:20 +0000 (18:39 -0500)]
Enable test-ipcrm, test-hostname in unsafe tests
Zbigniew Jędrzejewski-Szmek [Fri, 26 Feb 2016 14:10:48 +0000 (09:10 -0500)]
Enable test-daemon, test-log, test-watchdog by default
Those should be safe to run, resulting in some messages in logs.
Zbigniew Jędrzejewski-Szmek [Sat, 27 Feb 2016 16:30:22 +0000 (11:30 -0500)]
shared/acpi-fpdt: use ENODATA for missing data and skip test
This data is simply missing on non-UEFI systems, and it is useful
to distinguish that from corrupted data.
Zbigniew Jędrzejewski-Szmek [Fri, 26 Feb 2016 14:06:10 +0000 (09:06 -0500)]
Rename test-boot-timestamp to test-boot-timestamps and enable by default
The source file name and the binary name were mismatched.
Rename binary to match.
Make the test exit with TEST_SKIP if the data is missing or we
have no permissions. Otherwise, the data will be printed, which
should be safe to enable by default.
Zbigniew Jędrzejewski-Szmek [Fri, 26 Feb 2016 14:00:33 +0000 (09:00 -0500)]
Move test-loopback to normal tests
In the normal case lo should be already configured and this should be
a noop, even when run under root.
Franck Bui [Tue, 1 Dec 2015 17:01:44 +0000 (18:01 +0100)]
fstab-generator: fix automount option and don't start associated mount unit at boot
Without this patch applied the mount unit with 'automount' option was still
pulled by local-fs.target and thus was activated during the boot process which
defeats the purpose of the 'automount' option:
$ grep /mnt /etc/fstab
/dev/vdb1 /mnt ext2 defaults,x-systemd.automount 0 0
$ reboot
...
$ mount | grep mnt
systemd-1 on /mnt type autofs (rw,relatime,fd=34,pgrp=1,timeout=0,minproto=5,maxproto=5,direct)
/dev/vdb1 on /mnt type ext2 (rw,relatime)
$ systemctl status mnt.mount | grep Active
Active: active (mounted) since Thu 2016-03-03 21:36:22 CET; 42s ago
With the patch applied:
$ reboot
...
$ mount | grep mnt
systemd-1 on /mnt type autofs (rw,relatime,fd=22,pgrp=1,timeout=0,minproto=5,maxproto=5,direct)
$ systemctl status mnt.mount | grep Active
Active: inactive (dead)
$ ls /mnt
lost+found
$ systemctl status mnt.mount | grep Active
Active: active (mounted) since Thu 2016-03-03 21:47:32 CET; 4s ago
Joel Holdsworth [Thu, 3 Mar 2016 20:40:01 +0000 (20:40 +0000)]
core/failure-action: Set job-modes to replace-irreversibly
Up until now, the failure action has launched reboot.target and
poweroff.target with a less aggressive job mode than
"systemctl reboot" does. This has meant that the reboot and power-
off operations can stall if there are any conflicts with the target
during rebooting.
Ronny Chevalier [Wed, 2 Mar 2016 23:39:47 +0000 (00:39 +0100)]
test-util: remove now unused includes
Ronny Chevalier [Wed, 2 Mar 2016 23:35:36 +0000 (00:35 +0100)]
tests: move xattr-util related tests to test-xattr-util.c
Ronny Chevalier [Wed, 2 Mar 2016 23:31:23 +0000 (00:31 +0100)]
tests: move glob-util related tests to test-glob-util.c
Ronny Chevalier [Wed, 2 Mar 2016 23:28:29 +0000 (00:28 +0100)]
tests: move io-util related tests to test-io-util
Ronny Chevalier [Wed, 2 Mar 2016 23:23:30 +0000 (00:23 +0100)]
tests: move proc-cmdline related tests to test-proc-cmdline.c
Ronny Chevalier [Wed, 2 Mar 2016 23:16:52 +0000 (00:16 +0100)]
tests: move fstab-util related tests to test-fstab-util.c
Ronny Chevalier [Wed, 2 Mar 2016 23:14:18 +0000 (00:14 +0100)]
tests: move fs-util related tests to test-fs-util.c
Ronny Chevalier [Wed, 2 Mar 2016 23:08:10 +0000 (00:08 +0100)]
tests: move conf-parser related tests to test-conf-parser.c
Ronny Chevalier [Wed, 2 Mar 2016 23:06:17 +0000 (00:06 +0100)]
tests: move fd-util related tests to test-fd-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:58:48 +0000 (23:58 +0100)]
tests: move user-util related tests to test-user-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:54:35 +0000 (23:54 +0100)]
tests: move path-util related tests to test-path-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:50:21 +0000 (23:50 +0100)]
tests: move fileio related tests to test-fileio.c
Ronny Chevalier [Wed, 2 Mar 2016 22:43:25 +0000 (23:43 +0100)]
tests: move stat-util related tests to test-stat-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:36:50 +0000 (23:36 +0100)]
tests: move signal-util related tests to test-signal-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:29:49 +0000 (23:29 +0100)]
tests: move cpu-set-util related tests to test-cpu-set-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:23:55 +0000 (23:23 +0100)]
tests: move web-util related tests to test-web-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:19:55 +0000 (23:19 +0100)]
tests: move alloc related tests to test-alloc-util.c
Ronny Chevalier [Wed, 2 Mar 2016 22:10:11 +0000 (23:10 +0100)]
tests: move escape related tests to test-escape.c
Ronny Chevalier [Wed, 2 Mar 2016 22:01:38 +0000 (23:01 +0100)]
tests: move strv related tests to test-strv.c
Ronny Chevalier [Wed, 2 Mar 2016 21:57:20 +0000 (22:57 +0100)]
tests: move string related tests to test-string-util.c
Ronny Chevalier [Wed, 2 Mar 2016 21:44:04 +0000 (22:44 +0100)]
tests: move hexdecoct tests to test-hexdecoct.c
Zbigniew Jędrzejewski-Szmek [Thu, 3 Mar 2016 17:32:12 +0000 (12:32 -0500)]
Merge pull request #2790 from ronnychevalier/rc/systemctl_missing_oom_check
systemctl: add missing OOM check
Ronny Chevalier [Thu, 3 Mar 2016 17:15:24 +0000 (18:15 +0100)]
systemctl: add missing OOM check
Lennart Poettering [Thu, 3 Mar 2016 16:46:56 +0000 (17:46 +0100)]
Merge pull request #2781 from keszybz/selinux-and-warnings
Selinux loading fix and warning cleanups
Zbigniew Jędrzejewski-Szmek [Thu, 3 Mar 2016 16:34:09 +0000 (11:34 -0500)]
Merge pull request #2787 from ronnychevalier/rc/systemctl_edit_rm_empty_dropin_dirs
systemctl: rm empty dropin dirs after cancelled edit
Ronny Chevalier [Wed, 2 Mar 2016 21:06:47 +0000 (22:06 +0100)]
systemctl: rm empty dropin dirs after cancelled edit
Fixes #2734
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 17:08:02 +0000 (12:08 -0500)]
Redefine 32bit time_t format to signed
It seems that it is signed both on i386 and arm.
Avoids a stupid gcc warning on arm:
src/udev/udevadm-monitor.c: In function ‘print_device’:
src/udev/udevadm-monitor.c:44:16: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘__time_t {aka long int}’ [-Wformat=]
printf("%-6s[%"PRI_TIME".%06ld] %-8s %s (%s)\n",
^
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 16:52:03 +0000 (11:52 -0500)]
test-sizeof: add a helper which prints variable sizes and signedness
This helps to understand misleading gcc warnings about type mismatches.
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 14:17:03 +0000 (09:17 -0500)]
test-selinux: add some simple tests which call functions and print the results and timings
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 15:16:39 +0000 (10:16 -0500)]
selinux: use raw variants of security_compute_create and setfscreatecon
As suggested by Evgeny Vereshchagin as a follow up for
https://github.com/systemd/systemd/pull/2781#issuecomment-
191043402 .
Daniel Mack [Wed, 2 Mar 2016 08:16:08 +0000 (09:16 +0100)]
Merge pull request #2779 from 0xAX/openat-opath-excess-flags
tree-wide: no need to pass excess flags to open()/openat() if O_PATH …
Daniel Mack [Wed, 2 Mar 2016 08:14:59 +0000 (09:14 +0100)]
Merge pull request #2782 from AOSC-Dev/master
po/zh_CN: attempt to refresh zh_CN translation
Mingcong Bai [Wed, 2 Mar 2016 03:40:18 +0000 (20:40 -0700)]
po/zh_CN: attempt to refresh zh_CN translation
Zbigniew Jędrzejewski-Szmek [Wed, 2 Mar 2016 01:35:55 +0000 (20:35 -0500)]
selinux: always try to load the full selinux db
https://github.com/systemd/systemd/pull/2508#issuecomment-
190901170
Maybe fixes https://bugzilla.redhat.com/show_bug.cgi?id=
1308771 .
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 21:03:32 +0000 (16:03 -0500)]
Merge pull request #2754 from eworm-de/ask-password
ask-password: do no print password when storing in keyring
Martin Pitt [Tue, 1 Mar 2016 18:49:39 +0000 (19:49 +0100)]
Merge pull request #2777 from martinpitt/keymap
keymap fixes
Alexander Kuleshov [Tue, 1 Mar 2016 18:25:09 +0000 (00:25 +0600)]
tree-wide: no need to pass excess flags to open()/openat() if O_PATH is passed
As described in the documentation:
When O_PATH is specified in flags, flag bits other than O_CLOEXEC,
O_DIRECTORY, and O_NOFOLLOW are ignored.
So, we can remove unnecessary flags in a case when O_PATH is passed
to the open() or openat().
Christian Hesse [Mon, 29 Feb 2016 20:04:02 +0000 (21:04 +0100)]
ask-password: add option --no-output to not print password to stdout
systemd-ask-password can store passwords in kernel keyring. However it
uses to print the passwords to standard output nevertheless. Depending
on where systemd-ask-password is called passwords may end on display
or in log, leaking sensitive information.
This allows to make systemd-ask-password quiet, effectively disabling
printing passwords to standard output.
Martin Pitt [Tue, 1 Mar 2016 13:51:29 +0000 (14:51 +0100)]
keymap: Some HP refactoring, add Probook 440 G3 keys
Apparently the vendor string for newer models now uses "svnHP" instead of
"svnHewlett-Packard", so add this alternative match to the global HP map.
Generalize matches for micmute key on ProBook 4xx.
Silence two hardwired keys on the ProBook 440 G3 that should not produce evdev
events. Thanks to Hermann Kraus for those! (See PR #2679)
Martin Pitt [Tue, 1 Mar 2016 13:43:43 +0000 (14:43 +0100)]
keymap: Add HP ZBook
https://launchpad.net/bugs/
1535219
Daniel Mack [Tue, 1 Mar 2016 09:06:51 +0000 (10:06 +0100)]
Merge pull request #2773 from eliasp/type-warnings
Use `PRIu64` to print `uint64_t` in log msgs
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 04:18:16 +0000 (23:18 -0500)]
Merge pull request #2702 from poettering/resolved-iterate-fix
resolved iteration fix
Zbigniew Jędrzejewski-Szmek [Tue, 1 Mar 2016 01:45:42 +0000 (20:45 -0500)]
Merge pull request #2767 from benjarobin/fix-warn
systemctl: Fix warn: action_to_runlevel() is not used
Elias Probst [Mon, 29 Feb 2016 21:42:43 +0000 (22:42 +0100)]
Use `PRIu64` to print `uint64_t` in log msgs
Lennart Poettering [Mon, 29 Feb 2016 19:33:51 +0000 (20:33 +0100)]
Merge pull request #2771 from 0xAX/core-kernel-timestamp-cleanup
core: use DUAL_TIMESTAMP_NULL to reset kernel_timestamp
Lennart Poettering [Mon, 29 Feb 2016 19:32:02 +0000 (20:32 +0100)]
Merge pull request #2769 from martinpitt/adjtime
Fixes for adjtime parsing
Martin Pitt [Mon, 29 Feb 2016 16:40:08 +0000 (17:40 +0100)]
test-clock: fix FILE* leak
Close the FILE* instead of the underlying fd.
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 15:10:55 +0000 (10:10 -0500)]
Merge pull request #2752 from eliasp/no-container-name-escaping
Don't escape the name of the container nspawn service
Lennart Poettering [Mon, 29 Feb 2016 15:05:48 +0000 (16:05 +0100)]
Merge pull request #2763 from tblume/shorten-hostname-before-removing-dots
shorten hostname before checking for trailing dot
Lennart Poettering [Mon, 29 Feb 2016 15:03:32 +0000 (16:03 +0100)]
Merge pull request #2756 from thom311/master
core: avoid compiler warning when compiling with -fexceptions
Martin Pitt [Mon, 29 Feb 2016 14:16:11 +0000 (15:16 +0100)]
test-clock: fix assertions
Use assert_se() to ensure that they don't get optimized away.
Martin Pitt [Mon, 29 Feb 2016 14:16:03 +0000 (15:16 +0100)]
timedated: trivial stylistic fix
Don't use {} for single-line "then" blocks.
Martin Pitt [Mon, 29 Feb 2016 14:19:10 +0000 (15:19 +0100)]
Merge pull request #2766 from keszybz/coverity
test-clock: fix fd "leak"
Benjamin ROBIN [Mon, 29 Feb 2016 14:07:09 +0000 (15:07 +0100)]
systemctl: Fix warn: action_to_runlevel() is not used
If HAVE_SYSV_COMPAT is not defined: ‘action_to_runlevel’ defined but not used
Benjamin ROBIN [Mon, 29 Feb 2016 13:25:16 +0000 (14:25 +0100)]
systemctl: Replace check_one_unit() by get_state_one_unit()
The get_state_one_unit returns the enum of the active state of the unit
Do not rely on the string value of the active state.
Fix #2718 since the refactoring allow to handle more case
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 13:03:32 +0000 (08:03 -0500)]
test-clock: fix fd "leak"
CID #
1352301 .
Alexander Kuleshov [Mon, 29 Feb 2016 12:56:57 +0000 (18:56 +0600)]
core: use DUAL_TIMESTAMP_NULL to reset kernel_timestamp
instead of direct reset of kernel_timestamp fields.
Ronny Chevalier [Mon, 29 Feb 2016 11:23:55 +0000 (12:23 +0100)]
Merge pull request #2764 from benjarobin/fix-stdio-bridge
stdio-bridge: Correctly propagate error
Benjamin Robin [Mon, 29 Feb 2016 09:36:11 +0000 (10:36 +0100)]
stdio-bridge: Correctly propagate error
Return EXIT_FAILURE and print the correct errno code if sd_bus_get_fd() or sd_bus_get_events() fail
Thomas Blume [Mon, 29 Feb 2016 09:19:01 +0000 (10:19 +0100)]
shorten hostname before checking for trailing dot
Shortening can lead to a hostname that has a trailing dot.
Therefore it should be done before checking from trailing dots.
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 00:23:29 +0000 (19:23 -0500)]
Merge pull request #2746 from daurnimator/patch-1
ISSUE_TEMPLATE: Use a list for submission type so that it appears as a checkbox
Zbigniew Jędrzejewski-Szmek [Mon, 29 Feb 2016 00:12:31 +0000 (19:12 -0500)]
Merge pull request #2753 from phomes/trivial-fixes2
Trivial fixes
Zbigniew Jędrzejewski-Szmek [Sun, 28 Feb 2016 23:56:07 +0000 (18:56 -0500)]
Merge pull request #2749 from martinpitt/adjtime
Thomas Haller [Sat, 27 Feb 2016 12:40:50 +0000 (13:40 +0100)]
core: avoid compiler warning when compiling with -fexceptions
Initialize auto variables with cleanup attribute, otherwise we
get a compiler warning with -fexceptions.
./configure CFLAGS='-Wmaybe-uninitialized -fexceptions -O2'