]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
4 days agotime-util: define TIMESPEC_OMIT
Yu Watanabe [Fri, 10 May 2024 01:10:48 +0000 (10:10 +0900)] 
time-util: define TIMESPEC_OMIT

Follow-up for 34c3d574742e867ef97e79509e4051a82f1b7d9b.

4 days agojournalctl: several cleanups for parse_boot_descriptor()
Yu Watanabe [Sat, 27 Apr 2024 08:44:49 +0000 (17:44 +0900)] 
journalctl: several cleanups for parse_boot_descriptor()

- rename to parse_id_descriptor(), to make it usable for other kind of
  ID later.
- add missing assertions,
- prefix arguments for storing results with 'ret_',
- drop unnecessary 'else'.

4 days agologs-show: add missing strempty()
Yu Watanabe [Sat, 27 Apr 2024 08:50:49 +0000 (17:50 +0900)] 
logs-show: add missing strempty()

Follow-up for 8e976dc9209853d5d4d2db3016289f2a5ab99fd9.

4 days agologs-show: drop uid argument from add_matches_for_user_units()
Yu Watanabe [Thu, 25 Apr 2024 03:44:49 +0000 (12:44 +0900)] 
logs-show: drop uid argument from add_matches_for_user_units()

It is always equivalent to getuid(). Let's call getuid() in the
function instead.

5 days agobasic/linux: Copy netfilter.h to the source tree
Florian Fainelli [Mon, 6 May 2024 17:40:29 +0000 (10:40 -0700)] 
basic/linux: Copy netfilter.h to the source tree

This fixes build with old toolchains prior to Linux < 4.2 which do not
have a definition for NFPROTO_NETDEV.

5 days agoshell-completion: on zsh, systemd-cat is a precommand
hydrargyrum [Tue, 30 Apr 2024 14:02:22 +0000 (16:02 +0200)] 
shell-completion: on zsh, systemd-cat is a precommand

_precommand lets zsh complete other commands and their arguments
e.g. it can complete grep with "systemd-cat gr" and complete grep options
with "systemd-cat grep -"

5 days agonetwork: Add missing IPv6AcceptRA to list of config sections
Daan De Meyer [Tue, 7 May 2024 09:00:57 +0000 (11:00 +0200)] 
network: Add missing IPv6AcceptRA to list of config sections

5 days agoMerge pull request #32689 from YHNdnzj/cred-missing
Luca Boccassi [Thu, 9 May 2024 11:21:44 +0000 (13:21 +0200)] 
Merge pull request #32689 from YHNdnzj/cred-missing

core/exec-credential: complain louder if inherited credential is missing

5 days agoMerge pull request #32694 from weblate/weblate-systemd-main
Luca Boccassi [Thu, 9 May 2024 11:12:37 +0000 (13:12 +0200)] 
Merge pull request #32694 from weblate/weblate-systemd-main

Translations update from Fedora Weblate

5 days agoMerge pull request #32733 from YHNdnzj/core-some-cleanup
Daan De Meyer [Thu, 9 May 2024 10:45:50 +0000 (12:45 +0200)] 
Merge pull request #32733 from YHNdnzj/core-some-cleanup

core: minor cleanups

5 days agopo: Added translation using Weblate (Hindi) 32694/head
Scrambled 777 [Wed, 8 May 2024 20:02:52 +0000 (22:02 +0200)] 
po: Added translation using Weblate (Hindi)

Co-authored-by: Scrambled 777 <weblate.scrambled777@simplelogin.com>
5 days agopo: Translated using Weblate (German)
Jarne Förster [Wed, 8 May 2024 20:02:51 +0000 (22:02 +0200)] 
po: Translated using Weblate (German)

Currently translated at 97.8% (228 of 233 strings)

Co-authored-by: Jarne Förster <fedora@mymailclient.de>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/de/
Translation: systemd/main

5 days agomkosi: Drop usage of updates-testing for Fedora 40
Daan De Meyer [Thu, 9 May 2024 08:21:01 +0000 (10:21 +0200)] 
mkosi: Drop usage of updates-testing for Fedora 40

The util-linux update we need has migrated to the stable repositories.

5 days agoTEST-46-HOMED: Ignore "Disk Usage" field as well
Daan De Meyer [Thu, 9 May 2024 07:40:16 +0000 (09:40 +0200)] 
TEST-46-HOMED: Ignore "Disk Usage" field as well

This can change between the call to homectl inspect and userdbctl
user so let's ignore it along with the other disk fields.

Fixes #32727

5 days agocore/namespace: take char* const* for strv, use FOREACH_ARRAY 32733/head
Mike Yuan [Thu, 9 May 2024 08:48:26 +0000 (16:48 +0800)] 
core/namespace: take char* const* for strv, use FOREACH_ARRAY

5 days agopath-util: take char* const* for strv where appropriate
Mike Yuan [Thu, 9 May 2024 08:46:48 +0000 (16:46 +0800)] 
path-util: take char* const* for strv where appropriate

5 days agocore/unit: use FOREACH_ARRAY at one more place
Mike Yuan [Thu, 9 May 2024 06:28:25 +0000 (14:28 +0800)] 
core/unit: use FOREACH_ARRAY at one more place

5 days agocore/unit: cast unused retval to void
Mike Yuan [Thu, 9 May 2024 06:25:24 +0000 (14:25 +0800)] 
core/unit: cast unused retval to void

5 days agocore/dbus-unit: correct argument alignment for SD_BUS_METHOD_WITH_ARGS
Mike Yuan [Wed, 8 May 2024 16:58:42 +0000 (00:58 +0800)] 
core/dbus-unit: correct argument alignment for SD_BUS_METHOD_WITH_ARGS

5 days agoMerge pull request #32729 from DaanDeMeyer/kernel-command-line
Luca Boccassi [Thu, 9 May 2024 08:53:40 +0000 (10:53 +0200)] 
Merge pull request #32729 from DaanDeMeyer/kernel-command-line

mkosi: Extend kernel command line

5 days agoMerge pull request #32701 from bluca/vmspawn/machinectl-shell
Zbigniew Jędrzejewski-Szmek [Thu, 9 May 2024 08:23:42 +0000 (10:23 +0200)] 
Merge pull request #32701 from bluca/vmspawn/machinectl-shell

vmspawn: implement machinectl shell for vm class machines and send termination signal via D-Bus-over-SSH

5 days agomkosi: Make sure the kernel fails loudly on oops/panic/softlockup 32729/head
Daan De Meyer [Thu, 9 May 2024 07:57:12 +0000 (09:57 +0200)] 
mkosi: Make sure the kernel fails loudly on oops/panic/softlockup

Helps with noticing kernel related failures.

5 days agomkosi: Add raid=noautodetect to kernel command line
Daan De Meyer [Thu, 9 May 2024 07:56:06 +0000 (09:56 +0200)] 
mkosi: Add raid=noautodetect to kernel command line

Should speed up boot times a little.

5 days agovmspawn: forward signals to VM PID 1 via D-BUS when available 32701/head
Sam Leonard [Thu, 25 Apr 2024 16:16:20 +0000 (17:16 +0100)] 
vmspawn: forward signals to VM PID 1 via D-BUS when available

Allow to gracefully shutdown by initiating the operation from
the guest

5 days agovmspawn: register with io.systemd.Machine.Register
Sam Leonard [Tue, 9 Apr 2024 16:27:21 +0000 (17:27 +0100)] 
vmspawn: register with io.systemd.Machine.Register

When available, use varlink to register the VM, so that we can talk
over SSH to the guest. Enables 'machinectl shell' for vmspawn guests.

5 days agovmspawn: add a dropin override to sshd-vsock@.service
Sam Leonard [Wed, 10 Apr 2024 15:21:12 +0000 (16:21 +0100)] 
vmspawn: add a dropin override to sshd-vsock@.service

5 days agosystemctl-show: make show_memory_available cover memory_available itself
Mike Yuan [Wed, 8 May 2024 17:12:17 +0000 (01:12 +0800)] 
systemctl-show: make show_memory_available cover memory_available itself

Follow-up for f380473edfa899706d630bb64750ab50c5c04961

This cleans up the code a bit. Also, before this commit,
if MemoryAvailable is set but show_memory_available
is false, and we have nothing else to output, empty
parenthesis is shown. This can be easily reproduced
on -.slice:

> systemctl status -- -.slice
> ...
> Memory: 1.8G ()
> ...

6 days agoMerge pull request #32717 from keszybz/very-important-fixes
Luca Boccassi [Wed, 8 May 2024 15:21:27 +0000 (17:21 +0200)] 
Merge pull request #32717 from keszybz/very-important-fixes

Whitespace adjustments and comments

6 days agodocs,man: Avoid some ambiguous uses of "may not"
Colin Watson [Wed, 8 May 2024 14:01:01 +0000 (15:01 +0100)] 
docs,man: Avoid some ambiguous uses of "may not"

Like much English text, the systemd documentation uses "may not" in the
sense of both "will possibly not" and "is forbidden to".  In many cases
this is OK because the context makes it clear, but in others I felt it
was possible to read the "is forbidden to" sense by mistake: in
particular, I tripped over "the target file may not exist" in
systemd.unit(5) before realizing the correct interpretation.

Use "might not" or "may choose not to" in these cases to make it clear
which sense we mean.

6 days agopidfd: properly detect if libc offers pidfd syscalls and make use of them then
Lennart Poettering [Wed, 8 May 2024 10:27:38 +0000 (12:27 +0200)] 
pidfd: properly detect if libc offers pidfd syscalls and make use of them then

We never updated the meson checks when glibc finally learned about these
syscalls, address that.

6 days agonspawn: whitespace 32717/head
Zbigniew Jędrzejewski-Szmek [Wed, 8 May 2024 12:59:14 +0000 (14:59 +0200)] 
nspawn: whitespace

6 days agorepart,measure: reword help descriptions
Zbigniew Jędrzejewski-Szmek [Wed, 8 May 2024 10:57:33 +0000 (12:57 +0200)] 
repart,measure: reword help descriptions

This is a follow-up/extension for ec361ea9ce0344321a6877d4d69a85db0c5bca4a.

6 days agoshared: fix comment
Zbigniew Jędrzejewski-Szmek [Wed, 8 May 2024 10:40:31 +0000 (12:40 +0200)] 
shared: fix comment

Follow-up for 90db1582a97d048769198ee1c0f367d003eeb130.

6 days agovmspawn: indentation
Zbigniew Jędrzejewski-Szmek [Wed, 8 May 2024 10:05:41 +0000 (12:05 +0200)] 
vmspawn: indentation

6 days agofirewall-util-iptables: update ELF note to mention "iptables"
Mike Yuan [Wed, 8 May 2024 12:13:19 +0000 (20:13 +0800)] 
firewall-util-iptables: update ELF note to mention "iptables"

Follow-up for cd7c2077954d86d23eafdedf3e258b365622779d

6 days agoMerge pull request #32709 from bluca/machined_ssh
Luca Boccassi [Wed, 8 May 2024 12:37:55 +0000 (14:37 +0200)] 
Merge pull request #32709 from bluca/machined_ssh

machined: add GetMachineSSHInfo method and varlink interface to register machines

6 days agoMerge pull request #32708 from DaanDeMeyer/fix-race
Luca Boccassi [Wed, 8 May 2024 12:21:37 +0000 (14:21 +0200)] 
Merge pull request #32708 from DaanDeMeyer/fix-race

Fix race conditions in tests

6 days agohwdb: Add a Logitech MX Master 3S (connected via Bolt Receiver)
Maciej S. Szmigiero [Tue, 7 May 2024 20:51:46 +0000 (22:51 +0200)] 
hwdb: Add a Logitech MX Master 3S (connected via Bolt Receiver)

The mouse technically has settable DPI between 200 and 8000, with a step of
50, but 1000 DPI is the default setting.
And if someone customizes the mouse DPI setting they can make a custom hwdb
rule too.

6 days agoMerge pull request #32705 from YHNdnzj/hibernate-error
Luca Boccassi [Wed, 8 May 2024 12:19:07 +0000 (14:19 +0200)] 
Merge pull request #32705 from YHNdnzj/hibernate-error

hibernate-util: differentiate some errors from the generic ENOSPC; systemctl: adjust the fallback behavior for sleep operations

6 days agoMerge pull request #32710 from YHNdnzj/debug-generator-cleanup
Daan De Meyer [Wed, 8 May 2024 12:09:56 +0000 (14:09 +0200)] 
Merge pull request #32710 from YHNdnzj/debug-generator-cleanup

debug-generator: several cleanups

6 days agoMerge pull request #32234 from poettering/dlopen-name-elf-note
Luca Boccassi [Wed, 8 May 2024 11:56:34 +0000 (13:56 +0200)] 
Merge pull request #32234 from poettering/dlopen-name-elf-note

Expose dlopen() dependencies in an ELF section, and add spec for it

6 days agoUse the correct name of CEL
MaxHearnden [Wed, 8 May 2024 06:02:52 +0000 (07:02 +0100)] 
Use the correct name of CEL

It's Canonical Event Format, not Common

6 days agomachined: add varlink interface for registering machines 32709/head
Sam Leonard [Tue, 23 Apr 2024 09:26:59 +0000 (10:26 +0100)] 
machined: add varlink interface for registering machines

This commit adds the new varlink interface io.systemd.Machine at
/run/systemd/machine/io.systemd.Machine with a single method Register

It supports all combinations of RegisterMachine[WithSSH,WithNetwork] all
under the same method.

6 days agodebug-generator: clean up logging and such for units passed from creds 32710/head
Mike Yuan [Wed, 8 May 2024 10:18:33 +0000 (18:18 +0800)] 
debug-generator: clean up logging and such for units passed from creds

6 days agodebug-generator: don't eat up error if we can't write drop-in
Mike Yuan [Wed, 8 May 2024 10:13:29 +0000 (18:13 +0800)] 
debug-generator: don't eat up error if we can't write drop-in

While at it, prepend the drop-in text with
our usual "Automatically generated by ...".

6 days agodebug-generator: drop unneeded empty_to_root
Mike Yuan [Wed, 8 May 2024 10:41:54 +0000 (18:41 +0800)] 
debug-generator: drop unneeded empty_to_root

6 days agodebug-generator: use RET_GATHER where appropriate
Mike Yuan [Wed, 8 May 2024 10:05:15 +0000 (18:05 +0800)] 
debug-generator: use RET_GATHER where appropriate

6 days agodebug-generator: enclose function call in if statement when retval
Mike Yuan [Wed, 8 May 2024 09:57:28 +0000 (17:57 +0800)] 
debug-generator: enclose function call in if statement when retval
is not used

6 days agoTEST-04-JOURNAL: Sleep more in delegated cgroup filtering script 32708/head
Daan De Meyer [Wed, 8 May 2024 09:44:28 +0000 (11:44 +0200)] 
TEST-04-JOURNAL: Sleep more in delegated cgroup filtering script

We already changed logs-filtering.service to sleep 2 seconds before
exiting to combat flakyness, let's do the same for the delegated
cgroup filtering payload.

Fixes #32696 (hopefully)

6 days agoTEST-81-GENERATORS: Do a lazy unmounts
Daan De Meyer [Wed, 8 May 2024 09:41:04 +0000 (11:41 +0200)] 
TEST-81-GENERATORS: Do a lazy unmounts

Otherwise we might fail if PID 1 is currently accessing these files.

Fixes #32692 (hopefully)

6 days agossh-generator: fix pointer cast type
Mike Yuan [Wed, 8 May 2024 10:12:35 +0000 (18:12 +0800)] 
ssh-generator: fix pointer cast type

6 days agotree-wide: add dlopen ELF notes to all dlopen() deps of ours 32234/head
Lennart Poettering [Thu, 11 Apr 2024 15:50:41 +0000 (17:50 +0200)] 
tree-wide: add dlopen ELF notes to all dlopen() deps of ours

Use 'recommended' priority for the default compression library, to
indicate that it should be prioritized over the other ones, as it
will be used to compress journals/core files.
Also use 'recommended' for kmod, as systems will likely fail to boot
if it's missing from the initrd.
Use 'suggested' for everything else.

There is one dlopen'ed TPM library that has the name generated
at runtime (depending on the driver), so that cannot be added, as it
needs to be known at build time.
Also when we support multiple ABI versions list them all, as for the
same reason we cannot know which one will be used at build time.

$ dlopen-notes.py build/libsystemd.so.0.39.0 build/src/shared/libsystemd-shared-256.so
libarchive.so.13 suggested
libbpf.so.0 suggested
libbpf.so.1 suggested
libcryptsetup.so.12 suggested
libdw.so.1 suggested
libelf.so.1 suggested
libfido2.so.1 suggested
libgcrypt.so.20 suggested
libidn2.so.0 suggested
libip4tc.so.2 suggested
libkmod.so.2 recommended
liblz4.so.1 suggested
liblzma.so.5 suggested
libp11-kit.so.0 suggested
libpcre2-8.so.0 suggested
libpwquality.so.1 suggested
libqrencode.so.3 suggested
libqrencode.so.4 suggested
libtss2-esys.so.0 suggested
libtss2-mu.so.0 suggested
libtss2-rc.so.0 suggested
libzstd.so.1 recommended

Co-authored-by: Luca Boccassi <bluca@debian.org>
6 days agodlfcn: add macro for exporting dlopen() module names in ELF sections
Lennart Poettering [Thu, 11 Apr 2024 15:45:17 +0000 (17:45 +0200)] 
dlfcn: add macro for exporting dlopen() module names in ELF sections

This allows code to declare "weak" dlopen() style deps via an ELF
section following the just added specification.

The idea is that any user of dlopen() will place ELF_NOTE_DLOPEN(…)
somewhere close which will synthesize the note.

Tools such as rpm/dpkg package builders as well as initrd generators
(such as dracut) can then automatically pick up these weak deps of
suggested dependencies for their purposes.

Co-authored-by: Luca Boccassi <bluca@debian.org>
6 days agodocs: add specification for ELF dlopen metadata
Luca Boccassi [Sun, 5 May 2024 15:45:21 +0000 (16:45 +0100)] 
docs: add specification for ELF dlopen metadata

Tool to parse it and to use it for Debian packaging available at
https://github.com/systemd/package-notes

Add 3 levels of priority like Debian does, but using terminology
from RPM as it seems more apt.
We will very likely never use 'required', as we use this functionality
for optional features, but it is worth having it in the spec nonetheless
as we want it to be generalized.

6 days agotmpfiles: Don't fail if file does not exist in item_do()
Daan De Meyer [Wed, 8 May 2024 09:35:21 +0000 (11:35 +0200)] 
tmpfiles: Don't fail if file does not exist in item_do()

If the file was removed by some other program, we should just go
to the next one without failing. item_do() is only used for recursive
globs instead of fixed paths so skipping on missing files makes sense
(unlike if the path was fixed where we should probably fail).

Fixes #32691 (hopefully)

6 days agoTEST-74-AUX-UTILS: Make more robust
Daan De Meyer [Wed, 8 May 2024 09:21:42 +0000 (11:21 +0200)] 
TEST-74-AUX-UTILS: Make more robust

Let's run mkfs on the file we create instead of the loop device and
let's use udevadm wait --settle to wait for udev to settle before
doing anything with the loop device

Fixes #32680 (hopefully)

6 days agomachined: add GetMachineSSHInfo method
Sam Leonard [Wed, 24 Apr 2024 17:08:13 +0000 (18:08 +0100)] 
machined: add GetMachineSSHInfo method

Also adds three properties:
- VsockCid: the VSOCK CID of the VM
- SshAddress: the address of the VM in a format SSH can connect to
- SshPrivateKeyPath: the path to the SSH private key to use to connect
  to the VM.

GetMachineSSHInfo is essentially a convenience method to query both the
SshAddress and SshPrivateKeyPath properties at once.

6 days agomachined: split manager linking out of machine_new into machine_link
Sam Leonard [Wed, 24 Apr 2024 08:57:18 +0000 (09:57 +0100)] 
machined: split manager linking out of machine_new into machine_link

6 days agomachined: expose machine_freep in machine.h
Sam Leonard [Mon, 22 Apr 2024 15:23:13 +0000 (16:23 +0100)] 
machined: expose machine_freep in machine.h

6 days agoshared/json: add json_dispatch_absolute_path
Sam Leonard [Tue, 23 Apr 2024 14:03:34 +0000 (15:03 +0100)] 
shared/json: add json_dispatch_absolute_path

6 days agoTEST-07-PID1: Fix race in aux-scope subtest
Daan De Meyer [Wed, 8 May 2024 08:20:20 +0000 (10:20 +0200)] 
TEST-07-PID1: Fix race in aux-scope subtest

Currently test-aux-scope.service can get killed by the test before
it's had a chance to setup its signal handler. Make it Type=notify
to fix the race.

Fixes #32670 (hopefully)

6 days agoman/run0: remove the --user example for --machine=
Mike Yuan [Wed, 8 May 2024 05:55:00 +0000 (13:55 +0800)] 
man/run0: remove the --user example for --machine=

run0's --user= option is different from other tools,
and the whole point of run0 is to connect to the system
manager. So the example is spurious.

6 days agopreset-all: continue on errors, report more errors
Zbigniew Jędrzejewski-Szmek [Tue, 7 May 2024 16:54:24 +0000 (18:54 +0200)] 
preset-all: continue on errors, report more errors

Firstly, if we encounter an error when iterating over the directory, gather
the error but continue. This is unlikely to happen, but if it happens, then
it doesn't seem very useful to break the preset processing at a random
point. If we can't process a unit — too bad, but since we already might
have processed some units earlier, we might as well try to process the
remaining ones.

Secondly, add missing error codes for units that are in a bad state to the
exclusion list. Those, we report them in the changes list, but consider the
whole operation a success. (-ETXTBSY and -ENOLINK were missing.)

Thirdly, add a message generator for -ENOLINK.

Fixes https://github.com/systemd/systemd/issues/21224.

6 days agosystemctl: do not fall back to StartUnit automatically for sleep operations 32705/head
Mike Yuan [Wed, 8 May 2024 05:41:05 +0000 (13:41 +0800)] 
systemctl: do not fall back to StartUnit automatically for sleep operations

In the majority of cases, this is caused by
sleep_supported() returning error. Hence it's
very likely that it would fail again, so
the fallback is not really useful. Instead,
honor the --force option for these verbs.

6 days agohibernate-util,logind: also differentiate the case of misconfigured resume
Mike Yuan [Wed, 8 May 2024 04:52:35 +0000 (12:52 +0800)] 
hibernate-util,logind: also differentiate the case of misconfigured resume

6 days agohibernate-util,logind: emit a clear error if the specified resume dev is missing
Mike Yuan [Wed, 8 May 2024 04:42:40 +0000 (12:42 +0800)] 
hibernate-util,logind: emit a clear error if the specified resume dev is missing

Currently, SLEEP_NOT_ENOUGH_SWAP_SPACE (ENOSPC) is returned
on all sorts of error conditions. But one important case
that's worth differentiating from that is when the resume device
is manually specified yet missing.

Closes #32644

6 days agoMerge pull request #32684 from YHNdnzj/pr-followups
Luca Boccassi [Tue, 7 May 2024 19:05:04 +0000 (21:05 +0200)] 
Merge pull request #32684 from YHNdnzj/pr-followups

Follow-ups for recently merged PRs

6 days agoMerge pull request #32681 from DaanDeMeyer/skipped-no-journal
Daan De Meyer [Tue, 7 May 2024 18:49:49 +0000 (20:49 +0200)] 
Merge pull request #32681 from DaanDeMeyer/skipped-no-journal

test: Don't keep journals for skipped tests

6 days agotest: Mark TEST-21-DFUZZER as slow and skip it by default 32681/head
Daan De Meyer [Tue, 7 May 2024 13:21:27 +0000 (15:21 +0200)] 
test: Mark TEST-21-DFUZZER as slow and skip it by default

The test is not really useful without sanitizers, so let's mark it
as slow and not run it by default in CI.

6 days agotest: Add infra to mark integration tests as slow
Daan De Meyer [Tue, 7 May 2024 13:20:44 +0000 (15:20 +0200)] 
test: Add infra to mark integration tests as slow

Some integration tests take much more time than others, let's add
a test param that can be used to configure this and integrate it
with the slow-tests meson option.

6 days agoci: Print a helpful link to download and view a failed test's journal
Daan De Meyer [Tue, 7 May 2024 10:24:51 +0000 (12:24 +0200)] 
ci: Print a helpful link to download and view a failed test's journal

6 days agorepart: correct timespec_store usage too 32684/head
Mike Yuan [Tue, 7 May 2024 12:15:57 +0000 (20:15 +0800)] 
repart: correct timespec_store usage too

6 days agobasic/mkdir: use timespec_store instead of _nsec for mkdir_p_root_full
Mike Yuan [Tue, 7 May 2024 12:13:55 +0000 (20:13 +0800)] 
basic/mkdir: use timespec_store instead of _nsec for mkdir_p_root_full

Follow-up for 34c3d574742e867ef97e79509e4051a82f1b7d9b

O_RDONLY is dropped when O_DIRECTORY is specified, since
it's unnecessary and even arguably confusing here, as
the dir is modified.

6 days agocore/service: use switch for service_enter_start
Mike Yuan [Tue, 7 May 2024 11:08:31 +0000 (19:08 +0800)] 
core/service: use switch for service_enter_start

Plus, add an assertion to ensure we're actually
using the start timestamp for the correct pid.

6 days agocore/execute: re-break function declaration of exec_spawn
Mike Yuan [Tue, 7 May 2024 11:02:32 +0000 (19:02 +0800)] 
core/execute: re-break function declaration of exec_spawn

Also rearrange some variable definitions. Note that
DECIMAL_STR_MAX() contains the size of NUL byte,
so +1 is dropped.

6 days agocore/unit: use FOREACH_STRING where appropriate
Mike Yuan [Tue, 7 May 2024 10:58:32 +0000 (18:58 +0800)] 
core/unit: use FOREACH_STRING where appropriate

Follow-up for 61628287bd6d5115d96a4bdbd70964efd7a5940e

6 days agoci: Optimize pull request labeler
Daan De Meyer [Tue, 7 May 2024 13:53:35 +0000 (15:53 +0200)] 
ci: Optimize pull request labeler

We keep running into rate limits, so let's optimize the number of
requests we do in the pull request labeler to hopefully fix that.

7 days agotest: Don't keep journals for skipped tests
Daan De Meyer [Tue, 7 May 2024 09:50:11 +0000 (11:50 +0200)] 
test: Don't keep journals for skipped tests

Let's make sure we don't save journals for tests that were skipped.

7 days agoMerge pull request #32683 from dtardon/fix-error-vars
Luca Boccassi [Tue, 7 May 2024 15:19:54 +0000 (17:19 +0200)] 
Merge pull request #32683 from dtardon/fix-error-vars

More mismatched error variables

7 days agomkosi: Update centos submodule to latest
Daan De Meyer [Tue, 7 May 2024 13:05:53 +0000 (15:05 +0200)] 
mkosi: Update centos submodule to latest

7 days agocore/exec-credential: complain louder if inherited credential is missing 32689/head
Mike Yuan [Tue, 7 May 2024 11:45:06 +0000 (19:45 +0800)] 
core/exec-credential: complain louder if inherited credential is missing

Also document that a missing inherited credential
is not considered fatal.

Closes #32667

7 days agocore/load-fragment: modernize config_parse_load_credential a bit
Mike Yuan [Tue, 7 May 2024 11:44:10 +0000 (19:44 +0800)] 
core/load-fragment: modernize config_parse_load_credential a bit

7 days agoclean-ipc: pass the right error variable 32683/head
David Tardon [Tue, 7 May 2024 11:56:26 +0000 (13:56 +0200)] 
clean-ipc: pass the right error variable

7 days agoudev-rules: pass the right error variable
David Tardon [Tue, 7 May 2024 11:55:02 +0000 (13:55 +0200)] 
udev-rules: pass the right error variable

7 days agohomework-quota: pass the right error variable
David Tardon [Tue, 7 May 2024 11:54:21 +0000 (13:54 +0200)] 
homework-quota: pass the right error variable

7 days agohomework-blob: pass the right error variable
David Tardon [Tue, 7 May 2024 11:50:55 +0000 (13:50 +0200)] 
homework-blob: pass the right error variable

7 days agohomework-fscrypt: pass the right error variable
David Tardon [Tue, 7 May 2024 11:49:31 +0000 (13:49 +0200)] 
homework-fscrypt: pass the right error variable

7 days agohomed-manager: pass the right error variable
David Tardon [Tue, 7 May 2024 11:46:32 +0000 (13:46 +0200)] 
homed-manager: pass the right error variable

7 days agotest-bpf-foreign-programs: pass the right error variable
David Tardon [Tue, 7 May 2024 11:43:09 +0000 (13:43 +0200)] 
test-bpf-foreign-programs: pass the right error variable

7 days agotest-bpf-restrict-fs: pass the right error variable
David Tardon [Tue, 7 May 2024 11:42:29 +0000 (13:42 +0200)] 
test-bpf-restrict-fs: pass the right error variable

7 days agotest-socket-bind: pass the right error variable
David Tardon [Tue, 7 May 2024 11:41:30 +0000 (13:41 +0200)] 
test-socket-bind: pass the right error variable

7 days agonspawn: pass the right error variable
David Tardon [Tue, 7 May 2024 11:40:53 +0000 (13:40 +0200)] 
nspawn: pass the right error variable

7 days agouserns-restrict: pass the right error variable
David Tardon [Tue, 7 May 2024 11:35:55 +0000 (13:35 +0200)] 
userns-restrict: pass the right error variable

7 days agocgroup-show: pass the right error variable
David Tardon [Tue, 7 May 2024 11:30:37 +0000 (13:30 +0200)] 
cgroup-show: pass the right error variable

7 days agomanager: pass the right error variable
David Tardon [Tue, 7 May 2024 11:29:30 +0000 (13:29 +0200)] 
manager: pass the right error variable

7 days agoresolved-dns-stream: pass the right error variable
David Tardon [Tue, 7 May 2024 11:23:01 +0000 (13:23 +0200)] 
resolved-dns-stream: pass the right error variable

7 days agoexec-invoke: pass the right error variable
David Tardon [Tue, 7 May 2024 11:19:42 +0000 (13:19 +0200)] 
exec-invoke: pass the right error variable

7 days agomain: pass the right error variable
David Tardon [Tue, 7 May 2024 11:18:10 +0000 (13:18 +0200)] 
main: pass the right error variable

7 days agobless-boot: pass the right error variable
David Tardon [Tue, 7 May 2024 11:16:30 +0000 (13:16 +0200)] 
bless-boot: pass the right error variable

7 days agojournal-remote-main: pass the right error variable
David Tardon [Tue, 7 May 2024 11:13:24 +0000 (13:13 +0200)] 
journal-remote-main: pass the right error variable