From f766d9af381687237fb1670bab67cf86064d0fba Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Thu, 16 Jul 2020 10:43:49 +0900 Subject: [PATCH] network: dhcp4: add two warnings --- src/network/networkd-dhcp4.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/network/networkd-dhcp4.c b/src/network/networkd-dhcp4.c index f732f385671..b7a8c628fb9 100644 --- a/src/network/networkd-dhcp4.c +++ b/src/network/networkd-dhcp4.c @@ -847,7 +847,9 @@ static void dhcp_address_on_acd(sd_ipv4acd *acd, int event, void *userdata) { (void) in_addr_to_string(AF_INET, &address, &pretty); log_link_warning(link, "DAD conflict. Dropping DHCP4 address %s", strna(pretty)); - (void) sd_dhcp_client_send_decline(link->dhcp_client); + r = sd_dhcp_client_send_decline(link->dhcp_client); + if (r < 0) + log_link_warning_errno(link, r, "Failed to send DHCP DECLINE, ignoring: %m"); if (link->dhcp_lease) { r = dhcp_lease_lost(link); @@ -1263,8 +1265,11 @@ static int dhcp4_handler(sd_dhcp_client *client, int event, void *userdata) { } if (link->dhcp_lease) { - if (link->network->dhcp_send_release) - (void) sd_dhcp_client_send_release(client); + if (link->network->dhcp_send_release) { + r = sd_dhcp_client_send_release(client); + if (r < 0) + log_link_warning_errno(link, r, "Failed to send DHCP RELEASE, ignoring: %m"); + } r = dhcp_lease_lost(link); if (r < 0) { @@ -1586,7 +1591,6 @@ int dhcp4_configure(Link *link) { log_link_debug(link, "DHCP4 CLIENT: Failed to set request flag for '%u' already exists, ignoring.", option); continue; } - if (r < 0) return log_link_error_errno(link, r, "DHCP4 CLIENT: Failed to set request flag for '%u': %m", option); } -- 2.39.2