build-sys: release++ (v2.34-rc2)

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.34-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: update hr.po (from translationproject.org)

libmount: add selinuxfs between pseudo filesystems

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1714826
Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: add bpf between pseudo filesystems

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1714826
Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: fix filters use on --list

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1714826
Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add asan build-sys test

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: add note about -S and -H

It's seems people still follow old advices for SSD/4K devices. Let's
make CHS deprecation more visible at the begin of the man page...

Signed-off-by: Karel Zak <kzak@redhat.com>

ul: make sure buffers are zeroized [coverity scan]

column: make code more robust [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

setpriv: fix memory leak in local scope [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

setarch: avoid NULL dereference [coverity check]

Signed-off-by: Karel Zak <kzak@redhat.com>

rtcwake: terminate mode and excl[]

* terminate string read from /proc
* terminate array for exclusive options

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add info about ASAN

Signed-off-by: Karel Zak <kzak@redhat.com>

renice: make code more readable for static analyzer [coverity scan]

It seems coverity and clag have no clue about relation between argv[]
and argc. Let's make code more readable for them...

Signed-off-by: Karel Zak <kzak@redhat.com>

readprofile: be more explicit with used types [cppcheck]

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: check scols_line_set_data() return value [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lscpu: make lookup() use more consistent [coverity scan]

We usually check lookup() return value. Let's do it in this case too.
It seems static analyzers will be happy with consistent code.

Signed-off-by: Karel Zak <kzak@redhat.com>

mesg: avoid 'ttyname failed: Success' message

The ttyname(3) can fail to access /dev/ path, and that will cause function
to fail without setting errno value with result of rather confusing error
message.  Lets start setting stdin permission via /proc when this happens as
a go-around, with hope kernel following symlink does not fail.  Ok, noted,
that hopes of symlink follow working are pretty slim.

Based on patch from Sami Kerola <kerolasa@iki.fi>.

Reference: https://github.com/lxc/lxd/issues/1724
Signed-off-by: Karel Zak <kzak@redhat.com>

lib/ttyutils: introduce get_terminal_stdfd()

Let's use separate function to detect what is the current terminal.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: remove unneeded fields from struct bcache_super_block

This started as fix to following warning.

    libblkid/src/superblocks/bcache.c:33:3: warning: ISO C99 doesn’t
    support unnamed structs/unions [-Wc99-c11-compat]

But when sent to review Karel told out rather than getting rid of warnings
lets get rid of everything unnecessary.

[kzak@redhat.com: - use original struct member names rather than 'padN']

Reference: https://github.com/karelzak/util-linux/pull/802
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

login: retire use of __FUNCTION__ macro

This fixes following warning about deprecatd __FUNCTION__ that is another
name for __func__ since GCC (pre 2.95, released July 1999).

    login-utils/login.c:860:10: warning: ISO C does not support
    ‘__FUNCTION__’ predefined identifier [-Wpedantic]

Co-Author: Sami Kerola <kerolasa@iki.fi>
Reference: https://c0x.coding-guidelines.com/6.4.2.2.html
Reference: https://github.com/karelzak/util-linux/pull/802
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

ipcs: check return value when read from /proc [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

hwclock: don't use uninitialized value [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

fallocate: make posix_fadvise() use more readable for analyzers

Signed-off-by: Karel Zak <kzak@redhat.com>

dmesg: make strtok() use more robust

Signed-off-by: Karel Zak <kzak@redhat.com>

blkzone: remove never read value

Signed-off-by: Karel Zak <kzak@redhat.com>

whereis: make subdirs scan more robust

* call strchr() only once
* avoid things like strcat(buf, strchr(dir, '*') + 1)
* make it more readable
* improve debug messages

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: make sure __process_one_device() has proper arguments [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: check ul_path_scanf() return value [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: check stat() return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

logger: make code more robust for static analyzer [clang scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

hardlink: avoid uninitialized variables [clang scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: assert if self_pte() returns NULL

The self_pte() can return NULL if partitions array is not large enough,
but that should also be impossible and definitely a bug.

libfdisk/src/dos.c:984:8: warning: potential null pointer dereference [-Wnull-dereference]
libfdisk/src/dos.c:1031:8: warning: potential null pointer dereference [-Wnull-dereference]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libfdisk: (bsd) improve checksum calculation [-Waddress-of-packed-member]

Let's keep compilers and static analyzers happy. The idea is to use
memcpy() to copy from buffer to variable and use all label as unsigned
char rather than vectorize by unsigned short.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: (silicon raid) improve checksum calculation [-Waddress-of-packed-member]

Let's keep compilers and static analyzers happy. The idea is to use
memcpy() to copy from buffer to variable and use all label as unsigned
char rather than vectorize by uint16_t.

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: (sgi) improve checksum calculation [-Waddress-of-packed-member]

Let's keep compilers and static analyzers happy. The idea is to use
memcpy() to copy from buffer to variable and use all label as unsigned
char rather than vectorize by uint32_t.

Signed-off-by: Karel Zak <kzak@redhat.com>

include/c: use __has_attribute

The __has macros are more portable (supported by gcc as well as
clang).

The old __GNUC_PREREQ is deprecated and it should be removed in
future. (Well, the __has macros are supported since gcc 5, so we
should be patient as some old stable distros (e.g. RHEL 7) use gcc
4.x).

This patch helps clang to correctly analyze our xalloc.h stuff.

Signed-off-by: Karel Zak <kzak@redhat.com>

bash-completion: add hardlink completion

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

bash-completion: update options before release

blkid: 5e91d5dd716ebc6144bcb0cabb0ec847a678be9e --no-part-details
lsblk: dc4662f0e755929de9cbe98b1b343b492fd620f4 --dedup
lsblk: 0bd05f5ee4876ffd13c98acd56c2bff9971f28f1 --merge
lscpu: 0e86bc8406959d0d56194d4f404b780e6b70caa4 --caches
lscpu: 2011528bce58dd31d5ee0287f2367da1f2d6cfa9 --bytes

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lib/ismounted: use xstrncpy()

Signed-off-by: Karel Zak <kzak@redhat.com>

zramctl: use xstrncpy()

Signed-off-by: Karel Zak <kzak@redhat.com>

whereis: use xstrncpy()

Signed-off-by: Karel Zak <kzak@redhat.com>

vipw: use xstrncpy()

It's already used by vipw, so use it everywhere.

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/path: use xstrncpy()

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/sysfs: use xstrncpy()

Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: use xstrncpy()

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: use xstrcpy()

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/colors: remove unnecessary goto

Signed-off-by: Karel Zak <kzak@redhat.com>

Merge branch '2019wk19' of https://github.com/kerolasa/util-linux

* '2019wk19' of https://github.com/kerolasa/util-linux:
  lib/colors: remove redundant if statement
  wipefs: fix variable / function shadowing [cppcheck]
  sulogin: fix variable / function shadowing [cppcheck]
  lscpu: remove redundant condition check [cppcheck]
  libmount: avoid possible null pointer dereference [cppcheck]
  lib/mangle: fix possible null pointer dereference [cppcheck]
  sfdisk: remove unnecessary size check [cppcheck]

Merge branch 'lscpu_midr_updates' of https://github.com/jlinton/util-linux

* 'lscpu_midr_updates' of https://github.com/jlinton/util-linux:
  lscpu: Add additional aarch64 models

Merge branch 'lscpu-another' of https://github.com/kerolasa/util-linux

* 'lscpu-another' of https://github.com/kerolasa/util-linux:
  lscpu: fix floating point exception
  include/strutils: fix potential null pointer dereference
  lscpu: remove extra space from field key name

lib/colors: remove redundant if statement

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

wipefs: fix variable / function shadowing [cppcheck]

[misc-utils/wipefs.c:636] -> [misc-utils/wipefs.c:310]: (style) Local
variable usage shadows outer function

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

sulogin: fix variable / function shadowing [cppcheck]

[login-utils/sulogin.c:398] -> [login-utils/sulogin.c:171]: (style) Local
variable set shadows outer function
[login-utils/sulogin.c:398] -> [login-utils/sulogin.c:830]: (style) Local
variable set shadows outer function

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lscpu: remove redundant condition check [cppcheck]

[sys-utils/lscpu.c:1783] -> [sys-utils/lscpu.c:1785]: (warning) Either the
condition 'desc' is redundant or there is possible null pointer dereference: desc.
[sys-utils/lscpu.c:1840] -> [sys-utils/lscpu.c:1842]: (warning) Either the
condition 'desc' is redundant or there is possible null pointer dereference: desc.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libmount: avoid possible null pointer dereference [cppcheck]

[libmount/src/monitor.c:797]: (warning) Possible null pointer dereference: me

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lib/mangle: fix possible null pointer dereference [cppcheck]

Fix effects code that is used when testing util-linux, so quite low impact.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

sfdisk: remove unnecessary size check [cppcheck]

Following warning is false positive.  Size of the buffer is defined using
BUFSIZ, and so the strncpy() will never overwrite the last byte that is
initialized to zero in get_user_reply().

[disk-utils/sfdisk.c:137] -> [disk-utils/sfdisk.c:136]: (warning) Either the
condition 'bufsz!=0' is redundant or strncpy() argument nr 3 can have
invalid value.  The value is -1 but the valid values are '0:'.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lscpu: fix floating point exception

As the title tells this change indeed fixes floating point exception, but
post processing as value overwrite feels a wrong.  Possibly something in
input is making cpu set count to go wrong, but I could not get my head
around what could it be.  Anyway avoiding division by zero seems better than
crashing so lets do this atleast for now.

Caused-by: e5f721132ec8b8c933a396d8dcb3efcb67854f13
Addresses: https://github.com/karelzak/util-linux/issues/788
Reported-by: Lars Wendler <polynomial-c@gentoo.org>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

include/strutils: fix potential null pointer dereference

Recent lscpu fix caused gcc -Wnull-dereference to go off that this change
addresses.

Reference: b94acada9ed0e11a7e82f8f60280c5b6058e4250
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lscpu: remove extra space from field key name

The extra space was more obvious in json output.  But as the expected test
output displays also the standard output can be effected by this change.

    $ lscpu --json | jq '.lscpu | .[].field' | grep ': '
    "L1d cache: "
    "L1i cache: "
    "L2 cache: "
    "L3 cache: "
    "Vulnerability L1tf: "
    "Vulnerability Mds: "
    "Vulnerability Meltdown: "
    "Vulnerability Spec store bypass: "
    "Vulnerability Spectre v1: "
    "Vulnerability Spectre v2: "

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

lscpu: Add additional aarch64 models

ARM has released docs for Cortex-A76, Neoverse-N1 and Neoverse-E1.
That means we know the midr partnums, so we can add them to the
human readable model name table.

Signed-off-by: Jeremy Linton <lintonrjeremy@gmail.com>

findmnt: keep it easy for static analyzers

findmnt: (verify) check mnt_table_next_fs() return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

fincore: remove unused variable [clang scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

cal: make sure months_in_row makes sense [coverity scan]

* avoid divide by zero in mountly() dues to wrong months_in_row
* make sure months_in_row is at least 1

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: improve strcpy() usage [coverity scan]

The old deprecated list output format ("-o list") copies gettex string
into fixed buffer, that's really bad idea.

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: check ftello() return value

Signed-off-by: Karel Zak <kzak@redhat.com>

Merge branch 'lscpu-output-fix' of https://github.com/kerolasa/util-linux

* 'lscpu-output-fix' of https://github.com/kerolasa/util-linux:
  lscpu: move trailing null after removing characters from a string

lscpu: move trailing null after removing characters from a string

From the test input string ':' characters are removed:

    cat x86_64-epyc_7451/sys/devices/system/cpu/vulnerabilities/spectre_v2
    Mitigation: Full AMD retpoline, IBPB: conditional, STIBP: disabled, RSB filling

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

libsmartcols: (groups) improve scols_table_group_lines() args check [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: fix memory leak on error [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: avoid memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: avoid division by zero [clang scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: remove unused code [clang scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: properly check return code of add_to_partitions_array() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: make partitions reference counting more robust [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: don't ignore blkid_probe_set_magic() errors [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix possible uninitialized value use [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/strutils: keep static analyzer happy [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/path: fix resource leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/path: fix possible NULL dereferencing [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/path: fix ul_path_get_dirfd() usage [coverity scan]

ul_path_get_dirfd() returns negative number on error...

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/path: consolidate ul_path_mkpath() usage

* always use errno from ul_path_mkpath()
* keep code simple and short as possible

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/path: fix possible NULL pointer dereferencing [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

column: fix "maybe be" duplication

Signed-off-by: Austin English <austinenglish@gmail.com>

rtcwake: fix "maybe be" duplication

Signed-off-by: Austin English <austinenglish@gmail.com>

mount: fix "maybe be" duplication

Signed-off-by: Austin English <austinenglish@gmail.com>

lsblk: fix "maybe be" duplication

Signed-off-by: Austin English <austinenglish@gmail.com>

libmount: fix "maybe be" duplication

Signed-off-by: Austin English <austinenglish@gmail.com>

lib/colors: fix "maybe be" duplication

Signed-off-by: Austin English <austinenglish@gmail.com>

losetup: keep static analyzer happy [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/colors: keep static analyzer happy [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/canonicalize: verify DM paths [coverity scan]

Now the code only checks that /sys/.../dm/name exists, but never
verify the device node in /dev (because path prefix is never NULL).

The prefix is used to redirect hardcoded paths to /sys dumps (e.g.
lsblk regression tests, etc.)

This bug has been introduced in v2.33. Fortunately, it's probably no
big issue as /dev is always in sync with /sys (thanks to udevd).

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add PKG_INSTALLDIR fallback

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: initialize buffers for get_user_reply() [coverity scan]

It's probably unnecessary, but better be safe than sorry.

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add --with-pkgconfigdir

It seems we need a way how to override the default pkg-config install directory.

default:
$ ./configure
$ grep 'pkgconfigdir ='  Makefile
pkgconfigdir = ${usrlib_execdir}/pkgconfig

user-defined:
$ ./configure --with-pkgconfigdir=/usr/share/pkgconfig
$ grep 'pkgconfigdir ='  Makefile
$ pkgconfigdir = /usr/share/pkgconfig

Addresses: https://github.com/karelzak/util-linux/issues/793
Signed-off-by: Karel Zak <kzak@redhat.com>