From edf9c218c1d8e1c5068dfe82c3fc723a51099510 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Thu, 23 May 2019 15:17:16 +0200 Subject: [PATCH] fallocate: make posix_fadvise() use more readable for analyzers Signed-off-by: Karel Zak --- sys-utils/fallocate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys-utils/fallocate.c b/sys-utils/fallocate.c index 04a3eaff53..15dcbb0a62 100644 --- a/sys-utils/fallocate.c +++ b/sys-utils/fallocate.c @@ -219,8 +219,11 @@ static void dig_holes(int fd, off_t file_off, off_t len) if (file_end && end > file_end) end = file_end; + if (off < 0 || end < 0) + break; + #if defined(POSIX_FADV_SEQUENTIAL) && defined(HAVE_POSIX_FADVISE) - posix_fadvise(fd, off, end, POSIX_FADV_SEQUENTIAL); + (void) posix_fadvise(fd, off, end, POSIX_FADV_SEQUENTIAL); #endif /* * Dig holes in the area @@ -251,7 +254,7 @@ static void dig_holes(int fd, off_t file_off, off_t len) size_t clen = off - cache_start; clen = (clen / cachesz) * cachesz; - posix_fadvise(fd, cache_start, clen, POSIX_FADV_DONTNEED); + (void) posix_fadvise(fd, cache_start, clen, POSIX_FADV_DONTNEED); cache_start = cache_start + clen; } #endif -- 2.39.2