]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
repair: don't double check dir2 sf parent in phase 4
authorBrian Foster <bfoster@redhat.com>
Wed, 5 Aug 2020 18:02:35 +0000 (14:02 -0400)
committerEric Sandeen <sandeen@sandeen.net>
Wed, 5 Aug 2020 18:02:35 +0000 (14:02 -0400)
commit1b0bfeb5e5ef99f2e5e325ef931514c3e86aeb4d
treecc9cc6199f323376058c2a05054ed8aa754149ac
parentba7dd41b85dfa4bcf6a35ff9bef47230b9295757
repair: don't double check dir2 sf parent in phase 4

The shortform parent ino verification code runs once in phase 3
(ino_discovery == true) and once in phase 4 (ino_discovery ==
false). This is unnecessary and leads to duplicate error messages if
repair replaces an invalid parent value with zero because zero is
still an invalid value. Skip the check in phase 4.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
[sandeen: add comments suggested by Darrick during review]
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
repair/dir2.c