]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs: fix superblock inprogress check
authorDave Chinner <dchinner@redhat.com>
Tue, 25 Oct 2016 00:26:46 +0000 (11:26 +1100)
committerDave Chinner <david@fromorbit.com>
Tue, 25 Oct 2016 00:26:46 +0000 (11:26 +1100)
commit85428dd23fd0e4f3c22b9a9d381d6de79e0d6469
tree6a2283a18aeaf7affbe5a98096f9651e3ec395a6
parentae11d3088dd73df1000855102ef90177d102dd52
xfs: fix superblock inprogress check

Source kernel commit: f3d7ebdeb2c297bd26272384e955033493ca291c

From inspection, the superblock sb_inprogress check is done in the
verifier and triggered only for the primary superblock via a
"bp->b_bn == XFS_SB_DADDR" check.

Unfortunately, the primary superblock is an uncached buffer, and
hence it is configured by xfs_buf_read_uncached() with:

bp->b_bn = XFS_BUF_DADDR_NULL;  /* always null for uncached buffers */

And so this check never triggers. Fix it.

cc: <stable@vger.kernel.org>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
libxfs/libxfs_io.h
libxfs/rdwr.c
libxfs/xfs_sb.c