]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs: don't cast string literals
authorEric Sandeen <sandeen@redhat.com>
Sun, 31 May 2015 21:15:38 +0000 (07:15 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 24 Aug 2015 01:52:45 +0000 (11:52 +1000)
commitefb358200aed8193219d4e16bc48a83b81bdff76
tree277ff2ee7ee32775fb4ad3164909255fb53b0ba1
parent71a9bb1752e40bbd1f3a5e5817c35be137ac582d
xfs: don't cast string literals

The commit:

a9273ca5 xfs: convert attr to use unsigned names

added these (unsigned char *) casts, but then the _SIZE macros
return "7" - size of a pointer minus one - not the length of
the string.  This is harmless in the kernel, because the _SIZE
macros are not used, but as we sync up with userspace, this will
matter.

I don't think the cast is necessary; i.e. assigning the string
literal to an unsigned char *, or passing it to a function
expecting an unsigned char *, should be ok, right?

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
libxfs/xfs_format.h