]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_scrub: fix complaint about uninitialized ret
authorDarrick J. Wong <darrick.wong@oracle.com>
Mon, 11 Nov 2019 15:06:46 +0000 (10:06 -0500)
committerEric Sandeen <sandeen@sandeen.net>
Mon, 11 Nov 2019 15:06:46 +0000 (10:06 -0500)
Coverity complained about the uninitialized ret in run_scrub_phases.
It's not sophisticated enough to realize that phase 1 and 7 are both
marked mustrun and are never the repair or datascan dummies and that
therefore ret is always initialized by the end of the for loop, but
OTOH there's no reason not to fix a trivial logic bomb if that ever
changes.

Coverity-id: 1455255
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
scrub/xfs_scrub.c

index a792768c5de559762c0606199a0c67313ce115b3..014c54dd76b24dd914f4f0fb5198b74277dfe9d9 100644 (file)
@@ -422,7 +422,7 @@ run_scrub_phases(
        unsigned int            debug_phase = 0;
        unsigned int            phase;
        int                     rshift;
-       int                     ret;
+       int                     ret = 0;
 
        if (debug_tweak_on("XFS_SCRUB_PHASE"))
                debug_phase = atoi(getenv("XFS_SCRUB_PHASE"));