From 0c1d69102f6fdff233a58c9b8f0e1beb39c89386 Mon Sep 17 00:00:00 2001 From: Jorge Guerra Date: Fri, 3 May 2019 11:52:32 -0500 Subject: [PATCH] xfs_db: scan entire file system when using 'frag' While running the 'frag' command of 'xfs_db' we noticed that the tool is not scanning all the files in the file system. We noticed this when we modified the tool to print the inodes of all the files scanned. For example: $ find /mnt/xfsdisk -type f | wc -l 1782674 $ xfs_db -r -c frag /dev/sdXX | grep MB | awk '{print $5}' | paste -s -d+ | bc 656818 Upon inspecting the code we noticed that the scanfunc_ino function stops processing a given inode block once it encounters a free leaf. However, in practice we see that inodes are necessarily always layed out contiguously on the leaf node. This resulted in the 'frag' command skipping some valid inodes. In this change we modify the scanfunc_ino function to skip freed inodes. With the change in place we ran the same experiment again and noticed a more accurate file count: $ find /mnt/d0 -type f | wc -l 1810442 $ xfs_db -r -c frag /dev/sdXX | grep MB | awk '{print $5}' | paste -s -d+ | bc 1810442 Fixes: 2a5eb70c ("xfs_db: teach the frag command about sparse inode chunks") Signed-off-by: Jorge Guerra Reviewed-by: Eric Sandeen Reviewed-by: Darrick J. Wong Signed-off-by: Eric Sandeen --- db/frag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/frag.c b/db/frag.c index 51000d83a..af7ae9982 100644 --- a/db/frag.c +++ b/db/frag.c @@ -507,7 +507,7 @@ scanfunc_ino( for (j = 0; j < inodes_per_buf; j++) { if (XFS_INOBT_IS_FREE_DISK(&rp[i], ioff + j)) - goto next_buf; + continue; dip = (xfs_dinode_t *)((char *)iocur_top->data + ((off + j) << mp->m_sb.sb_inodelog)); process_inode(agf, agino + ioff + j, dip); -- 2.39.2