git.ipfire.org Git - thirdparty/openwrt.git/blob

   1 From 0396a8731efd17aec4719ad9981fefeaa13ffa56 Mon Sep 17 00:00:00 2001
   2 From: Gabor Juhos <j4g8y7@gmail.com>
   3 Date: Wed, 14 May 2025 21:18:34 +0200
   4 Subject: [PATCH 3/7] pinctrl: armada-37xx: propagate error from
   5  armada_37xx_gpio_direction_output()
   6
   7 The regmap_update_bits() function can fail, so propagate its error
   8 up to the stack instead of silently ignoring that.
   9
  10 Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
  11 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
  12 Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
  13 Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-3-07e9ac1ab737@gmail.com
  14 Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  15 ---
  16  drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 +---
  17  1 file changed, 1 insertion(+), 3 deletions(-)
  18
  19 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
  20 +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
  21 @@ -432,9 +432,7 @@ static int armada_37xx_gpio_direction_ou
  22         reg = OUTPUT_EN;
  23         armada_37xx_update_reg(&reg, &en_offset);
  24
  25 -       regmap_update_bits(info->regmap, reg, mask, mask);
  26 -
  27 -       return 0;
  28 +       return regmap_update_bits(info->regmap, reg, mask, mask);
  29  }
  30
  31  static int armada_37xx_gpio_get(struct gpio_chip *chip, unsigned int offset)