git.ipfire.org Git - thirdparty/openwrt.git/blob

   1 From 20e544f0dcb26bcd461e254b8e1641a5063c0584 Mon Sep 17 00:00:00 2001
   2 From: Maxime Ripard <maxime@cerno.tech>
   3 Date: Thu, 23 Feb 2023 19:44:32 +0100
   4 Subject: [PATCH 0579/1085] drm/vc4: hdmi: Warn if writing to an unknown HDMI
   5  register
   6
   7 The VC4 HDMI driver has a bunch of accessors to read from a register.
   8 The read accessor was warning when accessing an unknown register, but
   9 the write one was just returning silently.
  10
  11 Let's make sure we warn also when writing to an unknown register.
  12
  13 Signed-off-by: Maxime Ripard <maxime@cerno.tech>
  14 ---
  15  drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 5 ++++-
  16  1 file changed, 4 insertions(+), 1 deletion(-)
  17
  18 --- a/drivers/gpu/drm/vc4/vc4_hdmi_regs.h
  19 +++ b/drivers/gpu/drm/vc4/vc4_hdmi_regs.h
  20 @@ -498,8 +498,11 @@ static inline void vc4_hdmi_write(struct
  21
  22         field = &variant->registers[reg];
  23         base = __vc4_hdmi_get_field_base(hdmi, field->reg);
  24 -       if (!base)
  25 +       if (!base) {
  26 +               dev_warn(&hdmi->pdev->dev,
  27 +                        "Unknown register ID %u\n", reg);
  28                 return;
  29 +       }
  30
  31         writel(value, base + field->offset);
  32  }