1 From 71d88c7409b91c853d7f9c933f5e27933d656e5e Mon Sep 17 00:00:00 2001
2 From: "SkyLake.Huang" <skylake.huang@mediatek.com>
3 Date: Sat, 9 Nov 2024 00:34:52 +0800
4 Subject: [PATCH 05/20] net: phy: mediatek: Move LED helper functions into mtk
7 This patch creates mtk-phy-lib.c & mtk-phy.h and integrates mtk-ge-soc.c's
8 LED helper functions so that we can use those helper functions in other
9 MTK's ethernet phy driver.
11 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
12 Signed-off-by: SkyLake.Huang <skylake.huang@mediatek.com>
13 Signed-off-by: David S. Miller <davem@davemloft.net>
16 drivers/net/phy/mediatek/Kconfig | 4 +
17 drivers/net/phy/mediatek/Makefile | 1 +
18 drivers/net/phy/mediatek/mtk-ge-soc.c | 280 +++----------------------
19 drivers/net/phy/mediatek/mtk-phy-lib.c | 254 ++++++++++++++++++++++
20 drivers/net/phy/mediatek/mtk.h | 86 ++++++++
21 6 files changed, 372 insertions(+), 255 deletions(-)
22 create mode 100644 drivers/net/phy/mediatek/mtk-phy-lib.c
23 create mode 100644 drivers/net/phy/mediatek/mtk.h
27 @@ -14428,7 +14428,9 @@ M: SkyLake Huang <SkyLake.Huang@mediatek
28 L: netdev@vger.kernel.org
30 F: drivers/net/phy/mediatek/mtk-ge-soc.c
31 +F: drivers/net/phy/mediatek/mtk-phy-lib.c
32 F: drivers/net/phy/mediatek/mtk-ge.c
33 +F: drivers/net/phy/mediatek/mtk.h
34 F: drivers/phy/mediatek/phy-mtk-xfi-tphy.c
36 MEDIATEK I2C CONTROLLER DRIVER
37 --- a/drivers/net/phy/mediatek/Kconfig
38 +++ b/drivers/net/phy/mediatek/Kconfig
40 # SPDX-License-Identifier: GPL-2.0-only
41 +config MTK_NET_PHYLIB
44 config MEDIATEK_GE_PHY
45 tristate "MediaTek Gigabit Ethernet PHYs"
47 @@ -13,6 +16,7 @@ config MEDIATEK_GE_SOC_PHY
48 tristate "MediaTek SoC Ethernet PHYs"
49 depends on (ARM64 && ARCH_MEDIATEK) || COMPILE_TEST
50 depends on NVMEM_MTK_EFUSE
51 + select MTK_NET_PHYLIB
53 Supports MediaTek SoC built-in Gigabit Ethernet PHYs.
55 --- a/drivers/net/phy/mediatek/Makefile
56 +++ b/drivers/net/phy/mediatek/Makefile
58 # SPDX-License-Identifier: GPL-2.0
59 +obj-$(CONFIG_MTK_NET_PHYLIB) += mtk-phy-lib.o
60 obj-$(CONFIG_MEDIATEK_GE_PHY) += mtk-ge.o
61 obj-$(CONFIG_MEDIATEK_GE_SOC_PHY) += mtk-ge-soc.o
62 --- a/drivers/net/phy/mediatek/mtk-ge-soc.c
63 +++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
65 #include <linux/phy.h>
66 #include <linux/regmap.h>
70 #define MTK_GPHY_ID_MT7981 0x03a29461
71 #define MTK_GPHY_ID_MT7988 0x03a29481
74 #define MTK_PHY_DA_TX_R50_PAIR_D 0x540
76 /* Registers on MDIO_MMD_VEND2 */
77 -#define MTK_PHY_LED0_ON_CTRL 0x24
78 -#define MTK_PHY_LED1_ON_CTRL 0x26
79 -#define MTK_PHY_LED_ON_MASK GENMASK(6, 0)
80 -#define MTK_PHY_LED_ON_LINK1000 BIT(0)
81 -#define MTK_PHY_LED_ON_LINK100 BIT(1)
82 -#define MTK_PHY_LED_ON_LINK10 BIT(2)
83 -#define MTK_PHY_LED_ON_LINK (MTK_PHY_LED_ON_LINK10 |\
84 - MTK_PHY_LED_ON_LINK100 |\
85 - MTK_PHY_LED_ON_LINK1000)
86 -#define MTK_PHY_LED_ON_LINKDOWN BIT(3)
87 -#define MTK_PHY_LED_ON_FDX BIT(4) /* Full duplex */
88 -#define MTK_PHY_LED_ON_HDX BIT(5) /* Half duplex */
89 -#define MTK_PHY_LED_ON_FORCE_ON BIT(6)
90 -#define MTK_PHY_LED_ON_POLARITY BIT(14)
91 -#define MTK_PHY_LED_ON_ENABLE BIT(15)
93 -#define MTK_PHY_LED0_BLINK_CTRL 0x25
94 -#define MTK_PHY_LED1_BLINK_CTRL 0x27
95 -#define MTK_PHY_LED_BLINK_1000TX BIT(0)
96 -#define MTK_PHY_LED_BLINK_1000RX BIT(1)
97 -#define MTK_PHY_LED_BLINK_100TX BIT(2)
98 -#define MTK_PHY_LED_BLINK_100RX BIT(3)
99 -#define MTK_PHY_LED_BLINK_10TX BIT(4)
100 -#define MTK_PHY_LED_BLINK_10RX BIT(5)
101 -#define MTK_PHY_LED_BLINK_RX (MTK_PHY_LED_BLINK_10RX |\
102 - MTK_PHY_LED_BLINK_100RX |\
103 - MTK_PHY_LED_BLINK_1000RX)
104 -#define MTK_PHY_LED_BLINK_TX (MTK_PHY_LED_BLINK_10TX |\
105 - MTK_PHY_LED_BLINK_100TX |\
106 - MTK_PHY_LED_BLINK_1000TX)
107 -#define MTK_PHY_LED_BLINK_COLLISION BIT(6)
108 -#define MTK_PHY_LED_BLINK_RX_CRC_ERR BIT(7)
109 -#define MTK_PHY_LED_BLINK_RX_IDLE_ERR BIT(8)
110 -#define MTK_PHY_LED_BLINK_FORCE_BLINK BIT(9)
112 #define MTK_PHY_LED1_DEFAULT_POLARITIES BIT(1)
114 #define MTK_PHY_RG_BG_RASEL 0x115
115 @@ -299,14 +266,6 @@ enum CAL_MODE {
119 -#define MTK_PHY_LED_STATE_FORCE_ON 0
120 -#define MTK_PHY_LED_STATE_FORCE_BLINK 1
121 -#define MTK_PHY_LED_STATE_NETDEV 2
123 -struct mtk_socphy_priv {
124 - unsigned long led_state;
127 struct mtk_socphy_shared {
129 struct mtk_socphy_priv priv[4];
130 @@ -1172,76 +1131,23 @@ static int mt798x_phy_config_init(struct
131 return mt798x_phy_calibration(phydev);
134 -static int mt798x_phy_hw_led_on_set(struct phy_device *phydev, u8 index,
137 - unsigned int bit_on = MTK_PHY_LED_STATE_FORCE_ON + (index ? 16 : 0);
138 - struct mtk_socphy_priv *priv = phydev->priv;
142 - changed = !test_and_set_bit(bit_on, &priv->led_state);
144 - changed = !!test_and_clear_bit(bit_on, &priv->led_state);
146 - changed |= !!test_and_clear_bit(MTK_PHY_LED_STATE_NETDEV +
147 - (index ? 16 : 0), &priv->led_state);
149 - return phy_modify_mmd(phydev, MDIO_MMD_VEND2, index ?
150 - MTK_PHY_LED1_ON_CTRL :
151 - MTK_PHY_LED0_ON_CTRL,
152 - MTK_PHY_LED_ON_MASK,
153 - on ? MTK_PHY_LED_ON_FORCE_ON : 0);
158 -static int mt798x_phy_hw_led_blink_set(struct phy_device *phydev, u8 index,
161 - unsigned int bit_blink = MTK_PHY_LED_STATE_FORCE_BLINK +
163 - struct mtk_socphy_priv *priv = phydev->priv;
167 - changed = !test_and_set_bit(bit_blink, &priv->led_state);
169 - changed = !!test_and_clear_bit(bit_blink, &priv->led_state);
171 - changed |= !!test_bit(MTK_PHY_LED_STATE_NETDEV +
172 - (index ? 16 : 0), &priv->led_state);
174 - return phy_write_mmd(phydev, MDIO_MMD_VEND2, index ?
175 - MTK_PHY_LED1_BLINK_CTRL :
176 - MTK_PHY_LED0_BLINK_CTRL,
178 - MTK_PHY_LED_BLINK_FORCE_BLINK : 0);
183 static int mt798x_phy_led_blink_set(struct phy_device *phydev, u8 index,
184 unsigned long *delay_on,
185 unsigned long *delay_off)
187 bool blinking = false;
194 - if (delay_on && delay_off && (*delay_on > 0) && (*delay_off > 0)) {
199 + err = mtk_phy_led_num_dly_cfg(index, delay_on, delay_off, &blinking);
203 - err = mt798x_phy_hw_led_blink_set(phydev, index, blinking);
204 + err = mtk_phy_hw_led_blink_set(phydev, index, blinking);
208 - return mt798x_phy_hw_led_on_set(phydev, index, false);
209 + return mtk_phy_hw_led_on_set(phydev, index, MTK_GPHY_LED_ON_MASK,
213 static int mt798x_phy_led_brightness_set(struct phy_device *phydev,
214 @@ -1249,11 +1155,12 @@ static int mt798x_phy_led_brightness_set
218 - err = mt798x_phy_hw_led_blink_set(phydev, index, false);
219 + err = mtk_phy_hw_led_blink_set(phydev, index, false);
223 - return mt798x_phy_hw_led_on_set(phydev, index, (value != LED_OFF));
224 + return mtk_phy_hw_led_on_set(phydev, index, MTK_GPHY_LED_ON_MASK,
225 + (value != LED_OFF));
228 static const unsigned long supported_triggers =
229 @@ -1269,155 +1176,26 @@ static const unsigned long supported_tri
230 static int mt798x_phy_led_hw_is_supported(struct phy_device *phydev, u8 index,
236 - /* All combinations of the supported triggers are allowed */
237 - if (rules & ~supported_triggers)
238 - return -EOPNOTSUPP;
242 + return mtk_phy_led_hw_is_supported(phydev, index, rules,
243 + supported_triggers);
246 static int mt798x_phy_led_hw_control_get(struct phy_device *phydev, u8 index,
247 unsigned long *rules)
249 - unsigned int bit_blink = MTK_PHY_LED_STATE_FORCE_BLINK +
251 - unsigned int bit_netdev = MTK_PHY_LED_STATE_NETDEV + (index ? 16 : 0);
252 - unsigned int bit_on = MTK_PHY_LED_STATE_FORCE_ON + (index ? 16 : 0);
253 - struct mtk_socphy_priv *priv = phydev->priv;
259 - on = phy_read_mmd(phydev, MDIO_MMD_VEND2,
260 - index ? MTK_PHY_LED1_ON_CTRL : MTK_PHY_LED0_ON_CTRL);
265 - blink = phy_read_mmd(phydev, MDIO_MMD_VEND2,
266 - index ? MTK_PHY_LED1_BLINK_CTRL :
267 - MTK_PHY_LED0_BLINK_CTRL);
271 - if ((on & (MTK_PHY_LED_ON_LINK | MTK_PHY_LED_ON_FDX |
272 - MTK_PHY_LED_ON_HDX | MTK_PHY_LED_ON_LINKDOWN)) ||
273 - (blink & (MTK_PHY_LED_BLINK_RX | MTK_PHY_LED_BLINK_TX)))
274 - set_bit(bit_netdev, &priv->led_state);
276 - clear_bit(bit_netdev, &priv->led_state);
278 - if (on & MTK_PHY_LED_ON_FORCE_ON)
279 - set_bit(bit_on, &priv->led_state);
281 - clear_bit(bit_on, &priv->led_state);
283 - if (blink & MTK_PHY_LED_BLINK_FORCE_BLINK)
284 - set_bit(bit_blink, &priv->led_state);
286 - clear_bit(bit_blink, &priv->led_state);
291 - if (on & MTK_PHY_LED_ON_LINK)
292 - *rules |= BIT(TRIGGER_NETDEV_LINK);
294 - if (on & MTK_PHY_LED_ON_LINK10)
295 - *rules |= BIT(TRIGGER_NETDEV_LINK_10);
297 - if (on & MTK_PHY_LED_ON_LINK100)
298 - *rules |= BIT(TRIGGER_NETDEV_LINK_100);
300 - if (on & MTK_PHY_LED_ON_LINK1000)
301 - *rules |= BIT(TRIGGER_NETDEV_LINK_1000);
303 - if (on & MTK_PHY_LED_ON_FDX)
304 - *rules |= BIT(TRIGGER_NETDEV_FULL_DUPLEX);
306 - if (on & MTK_PHY_LED_ON_HDX)
307 - *rules |= BIT(TRIGGER_NETDEV_HALF_DUPLEX);
309 - if (blink & MTK_PHY_LED_BLINK_RX)
310 - *rules |= BIT(TRIGGER_NETDEV_RX);
312 - if (blink & MTK_PHY_LED_BLINK_TX)
313 - *rules |= BIT(TRIGGER_NETDEV_TX);
316 + return mtk_phy_led_hw_ctrl_get(phydev, index, rules,
317 + MTK_GPHY_LED_ON_SET,
318 + MTK_GPHY_LED_RX_BLINK_SET,
319 + MTK_GPHY_LED_TX_BLINK_SET);
322 static int mt798x_phy_led_hw_control_set(struct phy_device *phydev, u8 index,
325 - unsigned int bit_netdev = MTK_PHY_LED_STATE_NETDEV + (index ? 16 : 0);
326 - struct mtk_socphy_priv *priv = phydev->priv;
327 - u16 on = 0, blink = 0;
333 - if (rules & BIT(TRIGGER_NETDEV_FULL_DUPLEX))
334 - on |= MTK_PHY_LED_ON_FDX;
336 - if (rules & BIT(TRIGGER_NETDEV_HALF_DUPLEX))
337 - on |= MTK_PHY_LED_ON_HDX;
339 - if (rules & (BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK)))
340 - on |= MTK_PHY_LED_ON_LINK10;
342 - if (rules & (BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK)))
343 - on |= MTK_PHY_LED_ON_LINK100;
345 - if (rules & (BIT(TRIGGER_NETDEV_LINK_1000) | BIT(TRIGGER_NETDEV_LINK)))
346 - on |= MTK_PHY_LED_ON_LINK1000;
348 - if (rules & BIT(TRIGGER_NETDEV_RX)) {
349 - blink |= (on & MTK_PHY_LED_ON_LINK) ?
350 - (((on & MTK_PHY_LED_ON_LINK10) ?
351 - MTK_PHY_LED_BLINK_10RX : 0) |
352 - ((on & MTK_PHY_LED_ON_LINK100) ?
353 - MTK_PHY_LED_BLINK_100RX : 0) |
354 - ((on & MTK_PHY_LED_ON_LINK1000) ?
355 - MTK_PHY_LED_BLINK_1000RX : 0)) :
356 - MTK_PHY_LED_BLINK_RX;
359 - if (rules & BIT(TRIGGER_NETDEV_TX)) {
360 - blink |= (on & MTK_PHY_LED_ON_LINK) ?
361 - (((on & MTK_PHY_LED_ON_LINK10) ?
362 - MTK_PHY_LED_BLINK_10TX : 0) |
363 - ((on & MTK_PHY_LED_ON_LINK100) ?
364 - MTK_PHY_LED_BLINK_100TX : 0) |
365 - ((on & MTK_PHY_LED_ON_LINK1000) ?
366 - MTK_PHY_LED_BLINK_1000TX : 0)) :
367 - MTK_PHY_LED_BLINK_TX;
371 - set_bit(bit_netdev, &priv->led_state);
373 - clear_bit(bit_netdev, &priv->led_state);
375 - ret = phy_modify_mmd(phydev, MDIO_MMD_VEND2, index ?
376 - MTK_PHY_LED1_ON_CTRL :
377 - MTK_PHY_LED0_ON_CTRL,
378 - MTK_PHY_LED_ON_FDX |
379 - MTK_PHY_LED_ON_HDX |
380 - MTK_PHY_LED_ON_LINK,
386 - return phy_write_mmd(phydev, MDIO_MMD_VEND2, index ?
387 - MTK_PHY_LED1_BLINK_CTRL :
388 - MTK_PHY_LED0_BLINK_CTRL, blink);
389 + return mtk_phy_led_hw_ctrl_set(phydev, index, rules,
390 + MTK_GPHY_LED_ON_SET,
391 + MTK_GPHY_LED_RX_BLINK_SET,
392 + MTK_GPHY_LED_TX_BLINK_SET);
395 static bool mt7988_phy_led_get_polarity(struct phy_device *phydev, int led_num)
396 @@ -1492,14 +1270,6 @@ static int mt7988_phy_probe_shared(struc
400 -static void mt798x_phy_leds_state_init(struct phy_device *phydev)
404 - for (i = 0; i < 2; ++i)
405 - mt798x_phy_led_hw_control_get(phydev, i, NULL);
408 static int mt7988_phy_probe(struct phy_device *phydev)
410 struct mtk_socphy_shared *shared;
411 @@ -1525,7 +1295,7 @@ static int mt7988_phy_probe(struct phy_d
415 - mt798x_phy_leds_state_init(phydev);
416 + mtk_phy_leds_state_init(phydev);
418 err = mt7988_phy_fix_leds_polarities(phydev);
420 @@ -1552,7 +1322,7 @@ static int mt7981_phy_probe(struct phy_d
424 - mt798x_phy_leds_state_init(phydev);
425 + mtk_phy_leds_state_init(phydev);
427 return mt798x_phy_calibration(phydev);
430 +++ b/drivers/net/phy/mediatek/mtk-phy-lib.c
432 +// SPDX-License-Identifier: GPL-2.0
433 +#include <linux/phy.h>
434 +#include <linux/module.h>
436 +#include <linux/netdevice.h>
440 +int mtk_phy_led_hw_is_supported(struct phy_device *phydev, u8 index,
441 + unsigned long rules,
442 + unsigned long supported_triggers)
447 + /* All combinations of the supported triggers are allowed */
448 + if (rules & ~supported_triggers)
449 + return -EOPNOTSUPP;
453 +EXPORT_SYMBOL_GPL(mtk_phy_led_hw_is_supported);
455 +int mtk_phy_led_hw_ctrl_get(struct phy_device *phydev, u8 index,
456 + unsigned long *rules, u16 on_set,
457 + u16 rx_blink_set, u16 tx_blink_set)
459 + unsigned int bit_blink = MTK_PHY_LED_STATE_FORCE_BLINK +
461 + unsigned int bit_netdev = MTK_PHY_LED_STATE_NETDEV + (index ? 16 : 0);
462 + unsigned int bit_on = MTK_PHY_LED_STATE_FORCE_ON + (index ? 16 : 0);
463 + struct mtk_socphy_priv *priv = phydev->priv;
469 + on = phy_read_mmd(phydev, MDIO_MMD_VEND2,
470 + index ? MTK_PHY_LED1_ON_CTRL : MTK_PHY_LED0_ON_CTRL);
475 + blink = phy_read_mmd(phydev, MDIO_MMD_VEND2,
476 + index ? MTK_PHY_LED1_BLINK_CTRL :
477 + MTK_PHY_LED0_BLINK_CTRL);
481 + if ((on & (on_set | MTK_PHY_LED_ON_FDX |
482 + MTK_PHY_LED_ON_HDX | MTK_PHY_LED_ON_LINKDOWN)) ||
483 + (blink & (rx_blink_set | tx_blink_set)))
484 + set_bit(bit_netdev, &priv->led_state);
486 + clear_bit(bit_netdev, &priv->led_state);
488 + if (on & MTK_PHY_LED_ON_FORCE_ON)
489 + set_bit(bit_on, &priv->led_state);
491 + clear_bit(bit_on, &priv->led_state);
493 + if (blink & MTK_PHY_LED_BLINK_FORCE_BLINK)
494 + set_bit(bit_blink, &priv->led_state);
496 + clear_bit(bit_blink, &priv->led_state);
502 + *rules |= BIT(TRIGGER_NETDEV_LINK);
504 + if (on & MTK_PHY_LED_ON_LINK10)
505 + *rules |= BIT(TRIGGER_NETDEV_LINK_10);
507 + if (on & MTK_PHY_LED_ON_LINK100)
508 + *rules |= BIT(TRIGGER_NETDEV_LINK_100);
510 + if (on & MTK_PHY_LED_ON_LINK1000)
511 + *rules |= BIT(TRIGGER_NETDEV_LINK_1000);
513 + if (on & MTK_PHY_LED_ON_LINK2500)
514 + *rules |= BIT(TRIGGER_NETDEV_LINK_2500);
516 + if (on & MTK_PHY_LED_ON_FDX)
517 + *rules |= BIT(TRIGGER_NETDEV_FULL_DUPLEX);
519 + if (on & MTK_PHY_LED_ON_HDX)
520 + *rules |= BIT(TRIGGER_NETDEV_HALF_DUPLEX);
522 + if (blink & rx_blink_set)
523 + *rules |= BIT(TRIGGER_NETDEV_RX);
525 + if (blink & tx_blink_set)
526 + *rules |= BIT(TRIGGER_NETDEV_TX);
530 +EXPORT_SYMBOL_GPL(mtk_phy_led_hw_ctrl_get);
532 +int mtk_phy_led_hw_ctrl_set(struct phy_device *phydev, u8 index,
533 + unsigned long rules, u16 on_set,
534 + u16 rx_blink_set, u16 tx_blink_set)
536 + unsigned int bit_netdev = MTK_PHY_LED_STATE_NETDEV + (index ? 16 : 0);
537 + struct mtk_socphy_priv *priv = phydev->priv;
538 + u16 on = 0, blink = 0;
544 + if (rules & BIT(TRIGGER_NETDEV_FULL_DUPLEX))
545 + on |= MTK_PHY_LED_ON_FDX;
547 + if (rules & BIT(TRIGGER_NETDEV_HALF_DUPLEX))
548 + on |= MTK_PHY_LED_ON_HDX;
550 + if (rules & (BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK)))
551 + on |= MTK_PHY_LED_ON_LINK10;
553 + if (rules & (BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK)))
554 + on |= MTK_PHY_LED_ON_LINK100;
556 + if (rules & (BIT(TRIGGER_NETDEV_LINK_1000) | BIT(TRIGGER_NETDEV_LINK)))
557 + on |= MTK_PHY_LED_ON_LINK1000;
559 + if (rules & (BIT(TRIGGER_NETDEV_LINK_2500) | BIT(TRIGGER_NETDEV_LINK)))
560 + on |= MTK_PHY_LED_ON_LINK2500;
562 + if (rules & BIT(TRIGGER_NETDEV_RX)) {
563 + blink |= (on & on_set) ?
564 + (((on & MTK_PHY_LED_ON_LINK10) ?
565 + MTK_PHY_LED_BLINK_10RX : 0) |
566 + ((on & MTK_PHY_LED_ON_LINK100) ?
567 + MTK_PHY_LED_BLINK_100RX : 0) |
568 + ((on & MTK_PHY_LED_ON_LINK1000) ?
569 + MTK_PHY_LED_BLINK_1000RX : 0) |
570 + ((on & MTK_PHY_LED_ON_LINK2500) ?
571 + MTK_PHY_LED_BLINK_2500RX : 0)) :
575 + if (rules & BIT(TRIGGER_NETDEV_TX)) {
576 + blink |= (on & on_set) ?
577 + (((on & MTK_PHY_LED_ON_LINK10) ?
578 + MTK_PHY_LED_BLINK_10TX : 0) |
579 + ((on & MTK_PHY_LED_ON_LINK100) ?
580 + MTK_PHY_LED_BLINK_100TX : 0) |
581 + ((on & MTK_PHY_LED_ON_LINK1000) ?
582 + MTK_PHY_LED_BLINK_1000TX : 0) |
583 + ((on & MTK_PHY_LED_ON_LINK2500) ?
584 + MTK_PHY_LED_BLINK_2500TX : 0)) :
589 + set_bit(bit_netdev, &priv->led_state);
591 + clear_bit(bit_netdev, &priv->led_state);
593 + ret = phy_modify_mmd(phydev, MDIO_MMD_VEND2, index ?
594 + MTK_PHY_LED1_ON_CTRL : MTK_PHY_LED0_ON_CTRL,
595 + MTK_PHY_LED_ON_FDX | MTK_PHY_LED_ON_HDX | on_set,
601 + return phy_write_mmd(phydev, MDIO_MMD_VEND2, index ?
602 + MTK_PHY_LED1_BLINK_CTRL :
603 + MTK_PHY_LED0_BLINK_CTRL, blink);
605 +EXPORT_SYMBOL_GPL(mtk_phy_led_hw_ctrl_set);
607 +int mtk_phy_led_num_dly_cfg(u8 index, unsigned long *delay_on,
608 + unsigned long *delay_off, bool *blinking)
613 + if (delay_on && delay_off && (*delay_on > 0) && (*delay_off > 0)) {
621 +EXPORT_SYMBOL_GPL(mtk_phy_led_num_dly_cfg);
623 +int mtk_phy_hw_led_on_set(struct phy_device *phydev, u8 index,
624 + u16 led_on_mask, bool on)
626 + unsigned int bit_on = MTK_PHY_LED_STATE_FORCE_ON + (index ? 16 : 0);
627 + struct mtk_socphy_priv *priv = phydev->priv;
631 + changed = !test_and_set_bit(bit_on, &priv->led_state);
633 + changed = !!test_and_clear_bit(bit_on, &priv->led_state);
635 + changed |= !!test_and_clear_bit(MTK_PHY_LED_STATE_NETDEV +
636 + (index ? 16 : 0), &priv->led_state);
638 + return phy_modify_mmd(phydev, MDIO_MMD_VEND2, index ?
639 + MTK_PHY_LED1_ON_CTRL :
640 + MTK_PHY_LED0_ON_CTRL,
642 + on ? MTK_PHY_LED_ON_FORCE_ON : 0);
646 +EXPORT_SYMBOL_GPL(mtk_phy_hw_led_on_set);
648 +int mtk_phy_hw_led_blink_set(struct phy_device *phydev, u8 index, bool blinking)
650 + unsigned int bit_blink = MTK_PHY_LED_STATE_FORCE_BLINK +
652 + struct mtk_socphy_priv *priv = phydev->priv;
656 + changed = !test_and_set_bit(bit_blink, &priv->led_state);
658 + changed = !!test_and_clear_bit(bit_blink, &priv->led_state);
660 + changed |= !!test_bit(MTK_PHY_LED_STATE_NETDEV +
661 + (index ? 16 : 0), &priv->led_state);
663 + return phy_write_mmd(phydev, MDIO_MMD_VEND2, index ?
664 + MTK_PHY_LED1_BLINK_CTRL :
665 + MTK_PHY_LED0_BLINK_CTRL,
667 + MTK_PHY_LED_BLINK_FORCE_BLINK : 0);
671 +EXPORT_SYMBOL_GPL(mtk_phy_hw_led_blink_set);
673 +void mtk_phy_leds_state_init(struct phy_device *phydev)
677 + for (i = 0; i < 2; ++i)
678 + phydev->drv->led_hw_control_get(phydev, i, NULL);
680 +EXPORT_SYMBOL_GPL(mtk_phy_leds_state_init);
682 +MODULE_DESCRIPTION("MediaTek Ethernet PHY driver common");
683 +MODULE_AUTHOR("Sky Huang <SkyLake.Huang@mediatek.com>");
684 +MODULE_AUTHOR("Daniel Golle <daniel@makrotopia.org>");
685 +MODULE_LICENSE("GPL");
687 +++ b/drivers/net/phy/mediatek/mtk.h
689 +/* SPDX-License-Identifier: GPL-2.0
691 + * Common definition for Mediatek Ethernet PHYs
692 + * Author: SkyLake Huang <SkyLake.Huang@mediatek.com>
693 + * Copyright (c) 2024 MediaTek Inc.
696 +#ifndef _MTK_EPHY_H_
697 +#define _MTK_EPHY_H_
699 +#define MTK_EXT_PAGE_ACCESS 0x1f
701 +/* Registers on MDIO_MMD_VEND2 */
702 +#define MTK_PHY_LED0_ON_CTRL 0x24
703 +#define MTK_PHY_LED1_ON_CTRL 0x26
704 +#define MTK_GPHY_LED_ON_MASK GENMASK(6, 0)
705 +#define MTK_2P5GPHY_LED_ON_MASK GENMASK(7, 0)
706 +#define MTK_PHY_LED_ON_LINK1000 BIT(0)
707 +#define MTK_PHY_LED_ON_LINK100 BIT(1)
708 +#define MTK_PHY_LED_ON_LINK10 BIT(2)
709 +#define MTK_PHY_LED_ON_LINKDOWN BIT(3)
710 +#define MTK_PHY_LED_ON_FDX BIT(4) /* Full duplex */
711 +#define MTK_PHY_LED_ON_HDX BIT(5) /* Half duplex */
712 +#define MTK_PHY_LED_ON_FORCE_ON BIT(6)
713 +#define MTK_PHY_LED_ON_LINK2500 BIT(7)
714 +#define MTK_PHY_LED_ON_POLARITY BIT(14)
715 +#define MTK_PHY_LED_ON_ENABLE BIT(15)
717 +#define MTK_PHY_LED0_BLINK_CTRL 0x25
718 +#define MTK_PHY_LED1_BLINK_CTRL 0x27
719 +#define MTK_PHY_LED_BLINK_1000TX BIT(0)
720 +#define MTK_PHY_LED_BLINK_1000RX BIT(1)
721 +#define MTK_PHY_LED_BLINK_100TX BIT(2)
722 +#define MTK_PHY_LED_BLINK_100RX BIT(3)
723 +#define MTK_PHY_LED_BLINK_10TX BIT(4)
724 +#define MTK_PHY_LED_BLINK_10RX BIT(5)
725 +#define MTK_PHY_LED_BLINK_COLLISION BIT(6)
726 +#define MTK_PHY_LED_BLINK_RX_CRC_ERR BIT(7)
727 +#define MTK_PHY_LED_BLINK_RX_IDLE_ERR BIT(8)
728 +#define MTK_PHY_LED_BLINK_FORCE_BLINK BIT(9)
729 +#define MTK_PHY_LED_BLINK_2500TX BIT(10)
730 +#define MTK_PHY_LED_BLINK_2500RX BIT(11)
732 +#define MTK_GPHY_LED_ON_SET (MTK_PHY_LED_ON_LINK1000 | \
733 + MTK_PHY_LED_ON_LINK100 | \
734 + MTK_PHY_LED_ON_LINK10)
735 +#define MTK_GPHY_LED_RX_BLINK_SET (MTK_PHY_LED_BLINK_1000RX | \
736 + MTK_PHY_LED_BLINK_100RX | \
737 + MTK_PHY_LED_BLINK_10RX)
738 +#define MTK_GPHY_LED_TX_BLINK_SET (MTK_PHY_LED_BLINK_1000RX | \
739 + MTK_PHY_LED_BLINK_100RX | \
740 + MTK_PHY_LED_BLINK_10RX)
742 +#define MTK_2P5GPHY_LED_ON_SET (MTK_PHY_LED_ON_LINK2500 | \
743 + MTK_GPHY_LED_ON_SET)
744 +#define MTK_2P5GPHY_LED_RX_BLINK_SET (MTK_PHY_LED_BLINK_2500RX | \
745 + MTK_GPHY_LED_RX_BLINK_SET)
746 +#define MTK_2P5GPHY_LED_TX_BLINK_SET (MTK_PHY_LED_BLINK_2500RX | \
747 + MTK_GPHY_LED_TX_BLINK_SET)
749 +#define MTK_PHY_LED_STATE_FORCE_ON 0
750 +#define MTK_PHY_LED_STATE_FORCE_BLINK 1
751 +#define MTK_PHY_LED_STATE_NETDEV 2
753 +struct mtk_socphy_priv {
754 + unsigned long led_state;
757 +int mtk_phy_led_hw_is_supported(struct phy_device *phydev, u8 index,
758 + unsigned long rules,
759 + unsigned long supported_triggers);
760 +int mtk_phy_led_hw_ctrl_set(struct phy_device *phydev, u8 index,
761 + unsigned long rules, u16 on_set,
762 + u16 rx_blink_set, u16 tx_blink_set);
763 +int mtk_phy_led_hw_ctrl_get(struct phy_device *phydev, u8 index,
764 + unsigned long *rules, u16 on_set,
765 + u16 rx_blink_set, u16 tx_blink_set);
766 +int mtk_phy_led_num_dly_cfg(u8 index, unsigned long *delay_on,
767 + unsigned long *delay_off, bool *blinking);
768 +int mtk_phy_hw_led_on_set(struct phy_device *phydev, u8 index,
769 + u16 led_on_mask, bool on);
770 +int mtk_phy_hw_led_blink_set(struct phy_device *phydev, u8 index,
772 +void mtk_phy_leds_state_init(struct phy_device *phydev);
774 +#endif /* _MTK_EPHY_H_ */