git.ipfire.org Git - thirdparty/openwrt.git/blob

   1 From 4af523551d876ab8b8057d1e5303a860fd736fcb Mon Sep 17 00:00:00 2001
   2 From: Jonas Gorski <jonas.gorski@gmail.com>
   3 Date: Mon, 2 Jun 2025 21:39:50 +0200
   4 Subject: [PATCH] net: dsa: b53: do not enable RGMII delay on bcm63xx
   5
   6 bcm63xx's RGMII ports are always in MAC mode, never in PHY mode, so we
   7 shouldn't enable any delays and let the PHY handle any delays as
   8 necessary.
   9
  10 This fixes using RGMII ports with normal PHYs like BCM54612E, which will
  11 handle the delay in the PHY.
  12
  13 Fixes: ce3bf94871f7 ("net: dsa: b53: add support for BCM63xx RGMIIs")
  14 Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
  15 Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
  16 Link: https://patch.msgid.link/20250602193953.1010487-3-jonas.gorski@gmail.com
  17 Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  18 ---
  19  drivers/net/dsa/b53/b53_common.c | 19 +------------------
  20  1 file changed, 1 insertion(+), 18 deletions(-)
  21
  22 --- a/drivers/net/dsa/b53/b53_common.c
  23 +++ b/drivers/net/dsa/b53/b53_common.c
  24 @@ -1330,24 +1330,7 @@ static void b53_adjust_63xx_rgmii(struct
  25                 off = B53_RGMII_CTRL_P(port);
  26
  27         b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl);
  28 -
  29 -       switch (interface) {
  30 -       case PHY_INTERFACE_MODE_RGMII_ID:
  31 -               rgmii_ctrl |= (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
  32 -               break;
  33 -       case PHY_INTERFACE_MODE_RGMII_RXID:
  34 -               rgmii_ctrl &= ~(RGMII_CTRL_DLL_TXC);
  35 -               rgmii_ctrl |= RGMII_CTRL_DLL_RXC;
  36 -               break;
  37 -       case PHY_INTERFACE_MODE_RGMII_TXID:
  38 -               rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC);
  39 -               rgmii_ctrl |= RGMII_CTRL_DLL_TXC;
  40 -               break;
  41 -       case PHY_INTERFACE_MODE_RGMII:
  42 -       default:
  43 -               rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
  44 -               break;
  45 -       }
  46 +       rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
  47
  48         if (port != dev->imp_port) {
  49                 if (is63268(dev))