]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/dp_mst: Verify request type in the corresponding down message reply
authorImre Deak <imre.deak@intel.com>
Tue, 3 Dec 2024 16:02:18 +0000 (18:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2025 12:28:41 +0000 (13:28 +0100)
commit002668bfd4162259282965cb6d36b401effd33ff
tree7d980c92dac9b651d92c958e5e472ecc66dfd259
parent3bc0d083177750fbc9462d96cb22b5e68f592ce4
drm/dp_mst: Verify request type in the corresponding down message reply

[ Upstream commit 4d49e77a973d3b5d1881663c3f122906a0702940 ]

After receiving the response for an MST down request message, the
response should be accepted/parsed only if the response type matches
that of the request. Ensure this by checking if the request type code
stored both in the request and the reply match, dropping the reply in
case of a mismatch.

This fixes the topology detection for an MST hub, as described in the
Closes link below, where the hub sends an incorrect reply message after
a CLEAR_PAYLOAD_TABLE -> LINK_ADDRESS down request message sequence.

Cc: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org>
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12804
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241203160223.2926014-3-imre.deak@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/drm_dp_mst_topology.c