]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: validate: Run global device definition validation before callbacks
authorPeter Krempa <pkrempa@redhat.com>
Tue, 7 Sep 2021 08:55:06 +0000 (10:55 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 9 Sep 2021 08:17:28 +0000 (10:17 +0200)
commit002de683c6f7fb7a96d213d0fbf896f7e7a60263
tree4d69c9852f174a009ef0fca54d55677c9f2109ff
parent7dee442677e8365de3e9d976c338be5da0481dd9
conf: validate: Run global device definition validation before callbacks

The validation infrastructure doesn't modify the definition and
additionally it makes sense to run the global code first as it's
validating certain corner cases.

The changed error messages from qemuxml2argvtest show that this is
indeed the proper ordering as all changed messages are actually better
describing the error.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
12 files changed:
src/conf/domain_validate.c
tests/qemuxml2argvdata/default-video-type-x86_64-caps-test-0.err
tests/qemuxml2argvdata/disk-fdc-incompatible-address.err
tests/qemuxml2argvdata/disk-ide-incompatible-address.err
tests/qemuxml2argvdata/disk-sata-incompatible-address.err
tests/qemuxml2argvdata/disk-scsi-incompatible-address.err
tests/qemuxml2argvdata/pseries-default-phb-numa-node.err
tests/qemuxml2argvdata/pseries-phb-invalid-target-index-1.err
tests/qemuxml2argvdata/pseries-phb-invalid-target-index-2.err
tests/qemuxml2argvdata/pseries-phb-invalid-target-index-3.err
tests/qemuxml2argvdata/video-invalid-multiple-devices.err
tests/qemuxml2argvdata/video-ramfb-display-device-pci-address.x86_64-latest.err