]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: only stop external devices after the domain
authorJán Tomko <jtomko@redhat.com>
Tue, 12 May 2020 10:59:07 +0000 (12:59 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 13 May 2020 13:29:37 +0000 (15:29 +0200)
commit006782a8bc5a27125211946fcb12a40f7d4ed12a
treed13166803da61017694f39a98ded54054b1e9265
parent9d190efc85a9c1c407512de4707acb4ffbbc04a4
qemu: only stop external devices after the domain

A failure in qemuProcessLaunch would lead to qemuExtDevicesStop
being called twice - once in the cleanup section and then again
in qemuProcessStop.

However, the first one is called while the QEMU process is
still running, which is too soon for the swtpm process, because
the swtmp_ioctl command can lock up:

https://bugzilla.redhat.com/show_bug.cgi?id=1822523

Remove the first call and only leave the one in qemuProcessStop,
which is called after the QEMU process is killed.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_process.c