]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kvm: don't take vcpu mutex for obviously invalid vcpu ioctls
authorDavid Matlack <dmatlack@google.com>
Fri, 19 Sep 2014 23:03:25 +0000 (16:03 -0700)
committerJiri Slaby <jslaby@suse.cz>
Fri, 31 Oct 2014 14:11:09 +0000 (15:11 +0100)
commit007a4d98f9814eed5d6d14c658b73fe2b60f13b6
treeafa06cccf7eb7236fbd159b0e589c2777da8fac2
parentdc17be89b79e769835935762f62e7d25c903e7ba
kvm: don't take vcpu mutex for obviously invalid vcpu ioctls

commit 2ea75be3219571d0ec009ce20d9971e54af96e09 upstream.

vcpu ioctls can hang the calling thread if issued while a vcpu is running.
However, invalid ioctls can happen when userspace tries to probe the kind
of file descriptors (e.g. isatty() calls ioctl(TCGETS)); in that case,
we know the ioctl is going to be rejected as invalid anyway and we can
fail before trying to take the vcpu mutex.

This patch does not change functionality, it just makes invalid ioctls
fail faster.

Signed-off-by: David Matlack <dmatlack@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
virt/kvm/kvm_main.c