]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: saa7146: fix array overflow in vidioc_s_audio()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 17 Nov 2020 07:23:40 +0000 (08:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Dec 2020 12:42:38 +0000 (13:42 +0100)
commit00878cbb011470834b150bed8afbb91bcd73fddc
tree41ae71207a1b8988fb0ced1c815c88a15719f319
parent93f556c6f9ac4dc44601c15e29254702daee44ef
media: saa7146: fix array overflow in vidioc_s_audio()

[ Upstream commit 8e4d86e241cf035d6d3467cd346e7ce490681937 ]

The "a->index" value comes from the user via the ioctl.  The problem is
that the shift can wrap resulting in setting "mxb->cur_audinput" to an
invalid value, which later results in an array overflow.

Fixes: 6680427791c9 ("[media] mxb: fix audio handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/pci/saa7146/mxb.c