]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: crct10dif-generic - fix use via crypto_shash_digest()
authorEric Biggers <ebiggers@google.com>
Sun, 31 Mar 2019 20:04:12 +0000 (13:04 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:39 +0000 (21:11 +0100)
commit00c649ff2e87add15d293ca6c52180b215b8a4bd
tree078fb6c401395e33643783c788bf40980e9c9f6b
parent4b0b903e98c56574420b6c460aefbbf66f3ce31c
crypto: crct10dif-generic - fix use via crypto_shash_digest()

commit 307508d1072979f4435416f87936f87eaeb82054 upstream.

The ->digest() method of crct10dif-generic reads the current CRC value
from the shash_desc context.  But this value is uninitialized, causing
crypto_shash_digest() to compute the wrong result.  Fix it.

Probably this wasn't noticed before because lib/crc-t10dif.c only uses
crypto_shash_update(), not crypto_shash_digest().  Likewise,
crypto_shash_digest() is not yet tested by the crypto self-tests because
those only test the ahash API which only uses shash init/update/final.

This bug was detected by my patches that improve testmgr to fuzz
algorithms against their generic implementation.

Fixes: 2d31e518a428 ("crypto: crct10dif - Wrap crc_t10dif function all to use crypto transform framework")
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
crypto/crct10dif_generic.c