]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amdkfd: Unwind debug trap enable on copy_to_user failure
authorYongqiang Sun <Yongqiang.Sun@amd.com>
Tue, 2 Jun 2026 13:59:44 +0000 (09:59 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 4 Jun 2026 19:25:55 +0000 (15:25 -0400)
commit01112e241e37f9ac98b6f418d93ce2e0b87b7ee0
tree16f9f0ca535c0093b1c1aa2321f649ffb359a90c
parentbfc6042540b7795d2f96a6ddc71442f74438dc73
drm/amdkfd: Unwind debug trap enable on copy_to_user failure

If kfd_dbg_trap_enable() fails while copying runtime_info to userspace,
it had already activated the trap, set debug_trap_enabled, taken an extra
process reference, and opened the debug event file. Return -EFAULT without
unwinding that state, leaving inconsistent trap state and a refcount
imbalance that could break later DISABLE/ENABLE.

On copy_to_user failure, deactivate the trap and undo the rest of the
enable setup before returning.

Signed-off-by: Yongqiang Sun <Yongqiang.Sun@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_debug.c