]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hid: cp2112: Fix duplicate workqueue initialization
authorDanny Kaehn <danny.kaehn@plexus.com>
Tue, 19 Sep 2023 21:22:45 +0000 (16:22 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:08:23 +0000 (11:08 +0100)
commit012d0c66f9392a99232ac28217229f32dd3a70cf
tree8055567c7ea87e4bb698c2981ccbe9f4c046c62a
parent1ce09238e8e8a4996fb1d96ee22f579e2a7e7b0f
hid: cp2112: Fix duplicate workqueue initialization

[ Upstream commit e3c2d2d144c082dd71596953193adf9891491f42 ]

Previously the cp2112 driver called INIT_DELAYED_WORK within
cp2112_gpio_irq_startup, resulting in duplicate initilizations of the
workqueue on subsequent IRQ startups following an initial request. This
resulted in a warning in set_work_data in workqueue.c, as well as a rare
NULL dereference within process_one_work in workqueue.c.

Initialize the workqueue within _probe instead.

Fixes: 13de9cca514e ("HID: cp2112: add IRQ chip handling")
Signed-off-by: Danny Kaehn <danny.kaehn@plexus.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-cp2112.c