]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: subpage: fix the bitmap dump which can cause bitmap corruption
authorQu Wenruo <wqu@suse.com>
Fri, 30 Aug 2024 07:05:48 +0000 (16:35 +0930)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:59 +0000 (16:29 +0200)
commit0131bf19a141d57ccd1f158df5be24baec5f8d99
tree03ece630afb42e9a5a66fbb19e6647ee51fd323e
parent459b724c3c31b80b13256e51bd917b7ea7282a7a
btrfs: subpage: fix the bitmap dump which can cause bitmap corruption

[ Upstream commit 77b0b98bb743f5d04d8f995ba1936e1143689d4a ]

In commit 75258f20fb70 ("btrfs: subpage: dump extra subpage bitmaps for
debug") an internal macro GET_SUBPAGE_BITMAP() is introduced to grab the
bitmap of each attribute.

But that commit is using bitmap_cut() which will do the left shift of
the larger bitmap, causing incorrect values.

Thankfully this bitmap_cut() is only called for debug usage, and so far
it's not yet causing problem.

Fix it to use bitmap_read() to only grab the desired sub-bitmap.

Fixes: 75258f20fb70 ("btrfs: subpage: dump extra subpage bitmaps for debug")
CC: stable@vger.kernel.org # 6.6+
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/subpage.c