]> git.ipfire.org Git - thirdparty/gcc.git/commit
tree-optimization/109002 - partial PRE miscompilation
authorRichard Biener <rguenther@suse.de>
Fri, 3 Mar 2023 09:41:29 +0000 (10:41 +0100)
committerRichard Biener <rguenther@suse.de>
Fri, 3 Mar 2023 11:06:49 +0000 (12:06 +0100)
commit0132acc03cada2c3b47c48a205e821563153fc80
tree1af54b446514c41ab16f50bb93821fe4ccc23e5c
parent59bc2b68de8041adf5eeb5bd18e5921f8a1f9567
tree-optimization/109002 - partial PRE miscompilation

Partial PRE ends up miscompiling the testcase in PR109002, likely
involving a corner case when inifinite loops are involved.  The
following avoids the miscompilation by addressing a long-standing
oddity that manifests in odd partial partial redundancies eliminated
that are full redundancies.  The oddity is that while we properly
PHI translate the PA_IN set from the successors when computing
PA_OUT but we fail to do the same for ANTIC_IN which is supposed
to be unioned.  That results in expressions with wrong virtual
operands being placed in the PA_OUT/IN sets and the pruning
machinery to go wrong because it assumes the expressions in the
sets have virtual operands that are valid in the respective blocks.

PR tree-optimization/109002
* tree-ssa-pre.cc (compute_partial_antic_aux): Properly
PHI-translate ANTIC_IN.

* gcc.dg/torture/pr109002.c: New testcase.
gcc/testsuite/gcc.dg/torture/pr109002.c [new file with mode: 0644]
gcc/tree-ssa-pre.cc