]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mdiobus: Fix potential out-of-bounds read/write access
authorJakub Raczynski <j.raczynski@samsung.com>
Mon, 9 Jun 2025 15:31:46 +0000 (17:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:05:20 +0000 (11:05 +0100)
commit014ad9210373d2104f6ef10e6bb999a7a0a4c50e
tree50d9af0d360cef8b5019e376dcefec65840ad1de
parent694456462ed63a06adbb0b7f2396a2eb5cc153c0
net/mdiobus: Fix potential out-of-bounds read/write access

[ Upstream commit 0e629694126ca388916f059453a1c36adde219c4 ]

When using publicly available tools like 'mdio-tools' to read/write data
from/to network interface and its PHY via mdiobus, there is no verification of
parameters passed to the ioctl and it accepts any mdio address.
Currently there is support for 32 addresses in kernel via PHY_MAX_ADDR define,
but it is possible to pass higher value than that via ioctl.
While read/write operation should generally fail in this case,
mdiobus provides stats array, where wrong address may allow out-of-bounds
read/write.

Fix that by adding address verification before read/write operation.
While this excludes this access from any statistics, it improves security of
read/write operation.

Fixes: 080bb352fad00 ("net: phy: Maintain MDIO device and bus statistics")
Signed-off-by: Jakub Raczynski <j.raczynski@samsung.com>
Reported-by: Wenjing Shan <wenjing.shan@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/phy/mdio_bus.c