]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ksmbd: validate session id and tree id in compound request
authorNamjae Jeon <linkinjeon@kernel.org>
Mon, 18 Dec 2023 15:34:16 +0000 (00:34 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Dec 2023 09:41:57 +0000 (10:41 +0100)
commit017d85c94f02090a87f4a473dbe0d6ee0da72693
tree7af698d13c1a1a44deecc14424440876aba0f59f
parent4a027b96515e30e831047cf5cc1f8bd80ea55050
ksmbd: validate session id and tree id in compound request

[ Upstream commit 3df0411e132ee74a87aa13142dfd2b190275332e ]

`smb2_get_msg()` in smb2_get_ksmbd_tcon() and smb2_check_user_session()
will always return the first request smb2 header in a compound request.
if `SMB2_TREE_CONNECT_HE` is the first command in compound request, will
return 0, i.e. The tree id check is skipped.
This patch use ksmbd_req_buf_next() to get current command in compound.

Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-21506
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ksmbd/smb2pdu.c