]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
leds: leds-lp50xx: Handle reg to get correct multi_index
authorJohan Adolfsson <johan.adolfsson@axis.com>
Tue, 17 Jun 2025 10:23:54 +0000 (12:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:28:26 +0000 (16:28 +0200)
commit01c412e31d9838cbc71c66dc03569e66ab00bb53
tree9b6539ade858953203908ef5288c9731654951a5
parent07cba8891f2c7c03f2eff45e8c5edf86dbab8347
leds: leds-lp50xx: Handle reg to get correct multi_index

[ Upstream commit 2e84a5e5374232e6f356ce5c079a5658d7e4af2c ]

mc_subled used for multi_index needs well defined array indexes,
to guarantee the desired result, use reg for that.

If devicetree child nodes is processed in random or reverse order
you may end up with multi_index "blue green red" instead of the expected
"red green blue".
If user space apps uses multi_index to deduce how to control the leds
they would most likely be broken without this patch if devicetree
processing is reversed (which it appears to be).

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-fuji.dts has reg set
but I don't see how it can have worked without this change.

If reg is not set, an error is returned,
If reg is out of range, an error is returned.
reg within led child nodes starts with 0, to map to the iout in each bank.

Signed-off-by: Johan Adolfsson <johan.adolfsson@axis.com>
Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Link: https://lore.kernel.org/r/20250617-led-fix-v7-1-cdbe8efc88fa@axis.com
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/leds/leds-lp50xx.c