]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: cdns3: cdnsp-pci: remove redundant pci_disable_device() call
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 3 Sep 2025 14:16:13 +0000 (22:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Oct 2025 09:56:41 +0000 (11:56 +0200)
commit01ffce6960ee1bdfdf29d4c2c8e0d26598b24234
tree85c9a8fad9090aad19c47a69a75ef58a60725ecc
parent9548742358d2604be216ee851d270cfd056862c8
usb: cdns3: cdnsp-pci: remove redundant pci_disable_device() call

commit e9c206324eeb213957a567a9d066bdeb355c7491 upstream.

The cdnsp-pci driver uses pcim_enable_device() to enable a PCI device,
which means the device will be automatically disabled on driver detach
through the managed device framework. The manual pci_disable_device()
call in the error path is therefore redundant.

Found via static anlaysis and this is similar to commit 99ca0b57e49f
("thermal: intel: int340x: processor: Fix warning during module unload").

Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20250903141613.2535472-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdnsp-pci.c