]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
phy: rockchip: inno-usb2: Fix a double free bug in rockchip_usb2phy_probe()
authorWentao Liang <vulab@iscas.ac.cn>
Wed, 21 Jan 2026 01:38:56 +0000 (20:38 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jan 2026 10:18:51 +0000 (11:18 +0100)
commit027d42b97e6eb827c3438ebc09bab7efaee9270d
treeb63259aa6e68fee407179688e4dffa7b96203f5d
parent10f07114483d6d39516da26daa57b237c14db31a
phy: rockchip: inno-usb2: Fix a double free bug in rockchip_usb2phy_probe()

[ Upstream commit e07dea3de508cd6950c937cec42de7603190e1ca ]

The for_each_available_child_of_node() calls of_node_put() to
release child_np in each success loop. After breaking from the
loop with the child_np has been released, the code will jump to
the put_child label and will call the of_node_put() again if the
devm_request_threaded_irq() fails. These cause a double free bug.

Fix by returning directly to avoid the duplicate of_node_put().

Fixes: ed2b5a8e6b98 ("phy: phy-rockchip-inno-usb2: support muxed interrupts")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260109154626.2452034-1-vulab@iscas.ac.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c