]> git.ipfire.org Git - thirdparty/libvirt.git/commit
meson: add -Wall and -Wextra explicitly
authorPavel Hrdina <phrdina@redhat.com>
Tue, 1 Sep 2020 12:54:27 +0000 (14:54 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Thu, 3 Sep 2020 12:47:09 +0000 (14:47 +0200)
commit028d6c051363dded1c5509c9f3e11d66cde0078d
treef6f31d8002f52be71e2fa73f22b0b1c10e0a3329
parentb196f8fcdddd08194f267b7a02d8541a653d894a
meson: add -Wall and -Wextra explicitly

If someone runs `meson setup --buildtype plain` meson ignores
warning_level=2 that is in our meson.build file. The implication is
that Meson will not automatically add -Wall which enables -Wformat.

This breaks building libvirt from git with the buildtype set to plain.

There is an issue reported [1] to not ignore warning_level silently
and the change to ignore it was done by upstream commit [2].

This change makes Meson print warnings about using warning_level which
as described above doesn't work for all build types.

[1] <https://github.com/mesonbuild/meson/issues/7399>
[2] <https://github.com/mesonbuild/meson/commit/8ee1c9a07a3a35e3ed262fbc358fd86c257a966e>

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
meson.build