]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
powerpc/powernv: Switch off MMU before entering nap/sleep/rvwinkle mode
authorPaul Mackerras <paulus@samba.org>
Tue, 9 Dec 2014 18:56:50 +0000 (00:26 +0530)
committerJiri Slaby <jslaby@suse.cz>
Mon, 26 Jan 2015 13:38:43 +0000 (14:38 +0100)
commit02b586bfc1eb8a7a6153c684f1b52a4db15a49c2
treedf5e6ba44ed3d9ac28bbd983bee5b77dc1657b2b
parentc6fdf6dc5e74d008ca8db8c4f7a579a94186c85f
powerpc/powernv: Switch off MMU before entering nap/sleep/rvwinkle mode

commit 8117ac6a6c2fa0f847ff6a21a1f32c8d2c8501d0 upstream.

Currently, when going idle, we set the flag indicating that we are in
nap mode (paca->kvm_hstate.hwthread_state) and then execute the nap
(or sleep or rvwinkle) instruction, all with the MMU on.  This is bad
for two reasons: (a) the architecture specifies that those instructions
must be executed with the MMU off, and in fact with only the SF, HV, ME
and possibly RI bits set, and (b) this introduces a race, because as
soon as we set the flag, another thread can switch the MMU to a guest
context.  If the race is lost, this thread will typically start looping
on relocation-on ISIs at 0xc...4400.

This fixes it by setting the MSR as required by the architecture before
setting the flag or executing the nap/sleep/rvwinkle instruction.

[ shreyas@linux.vnet.ibm.com: Edited to handle LE ]
Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/powerpc/include/asm/reg.h
arch/powerpc/kernel/idle_power7.S