]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Skip SUBSCRIPTION TABLE TOC entries with --no-subscriptions.
authorAmit Kapila <akapila@postgresql.org>
Thu, 30 Jul 2026 06:23:06 +0000 (11:53 +0530)
committerAmit Kapila <akapila@postgresql.org>
Thu, 30 Jul 2026 06:23:06 +0000 (11:53 +0530)
commit02decf9a9abc76f04a8117aba524dbe561cb720e
tree3d4495f724942abe58e6bbdda63e860446afbdc6
parent8f191a79617d906e34d041382e6ecfbf78166a65
Skip SUBSCRIPTION TABLE TOC entries with --no-subscriptions.

pg_dump in --binary-upgrade mode emits "SUBSCRIPTION TABLE" TOC entries to
preserve pg_subscription_rel state across pg_upgrade.  When such a dump
was restored with --no-subscriptions, _tocEntryRequired() skipped the
"SUBSCRIPTION" entry but not the associated "SUBSCRIPTION TABLE" entries,
so the restore would try to apply subscription-relation state for a
subscription that was never created.

Skip "SUBSCRIPTION TABLE" entries as well when no_subscriptions is set.

This can happen when pg_subscription_rel has entries, the dump is taken
with --binary-upgrade, and it is restored with --no-subscriptions.

Reported-by: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 17, where it was introduced
Discussion: https://postgr.es/m/OS9PR01MB121493DA4C1A7748B11A646D8F5C02@OS9PR01MB12149.jpnprd01.prod.outlook.com
src/bin/pg_dump/pg_backup_archiver.c