]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid crash in rare case of concurrent DROP
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 5 Nov 2021 15:29:35 +0000 (12:29 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 5 Nov 2021 15:29:35 +0000 (12:29 -0300)
commit02e20bb2dcaa523782a8fe7de1c2ddfefaeff033
tree04030780903792d35bccc91d6cd99f8fc7b13bcd
parentc829fbc3dc93d43bc499499164ac42c4edb1cb70
Avoid crash in rare case of concurrent DROP

When a role being dropped contains is referenced by catalog objects that
are concurrently also being dropped, a crash can result while trying to
construct the string that describes the objects.  Suppress that by
ignoring objects whose descriptions are returned as NULL.

The majority of relevant codesites were already cautious about this
already; we had just missed a couple.

This is an old bug, so backpatch all the way back.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17126-21887f04508cb5c8@postgresql.org
src/backend/catalog/dependency.c
src/backend/catalog/pg_shdepend.c