]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
target: Fix virtual LUN=0 target_configure_device failure OOPs
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 5 Mar 2015 03:28:24 +0000 (03:28 +0000)
committerJiri Slaby <jslaby@suse.cz>
Thu, 9 Apr 2015 11:14:19 +0000 (13:14 +0200)
commit033acbf6a597707356691d0621c1496bc5a610b1
tree14bda2b2c4256c98179c8ee484fb08a7edff11cd
parent64e6cd75c18e03a26efad817ec3ee8c0405c9660
target: Fix virtual LUN=0 target_configure_device failure OOPs

commit 5f7da044f8bc1cfb21c962edf34bd5699a76e7ae upstream.

This patch fixes a NULL pointer dereference triggered by a late
target_configure_device() -> alloc_workqueue() failure that results
in target_free_device() being called with DF_CONFIGURED already set,
which subsequently OOPses in destroy_workqueue() code.

Currently this only happens at modprobe target_core_mod time when
core_dev_setup_virtual_lun0() -> target_configure_device() fails,
and the explicit target_free_device() gets called.

To address this bug originally introduced by commit 0fd97ccf45, go
ahead and move DF_CONFIGURED to end of target_configure_device()
code to handle this special failure case.

Reported-by: Claudio Fleiner <cmf@daterainc.com>
Cc: Claudio Fleiner <cmf@daterainc.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/target/target_core_device.c