]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Pass URL object, not the string, to on_connect_url
authorMike Bayer <mike_mp@zzzcomputing.com>
Sun, 6 Jun 2021 14:12:05 +0000 (10:12 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sun, 6 Jun 2021 14:12:05 +0000 (10:12 -0400)
commit03633a6462ee16a1348acb98fe0323c74eb9ba85
tree04621e773c0de3c4b93f2b6774b604132cfe204c
parent3874d2576dc536b54af9f5525aff1fe59f4f00d3
Pass URL object, not the string, to on_connect_url

The fix for pysqlcipher released in version 1.4.3 :ticket:`5848` was
unfortunately non-working, in that the new ``on_connect_url`` hook was
erroneously not receiving a ``URL`` object under normal usage of
:func:`_sa.create_engine` and instead received a string that was unhandled;
the test suite failed to fully set up the actual conditions under which
this hook is called. This has been fixed.

Fixes: #6586
Change-Id: I3bf738daec35877a10fdad740f08dca9e7420829
doc/build/changelog/unreleased_14/6586.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/sqlite/pysqlcipher.py
lib/sqlalchemy/engine/create.py
test/dialect/test_sqlite.py
test/engine/test_parseconnect.py