]> git.ipfire.org Git - thirdparty/linux.git/commit
xfs: fix unreachable BIGTIME check in dquot flush validation
authorAlexey Nepomnyashih <sdl@nppct.ru>
Wed, 3 Jun 2026 20:41:47 +0000 (20:41 +0000)
committerCarlos Maiolino <cem@kernel.org>
Tue, 9 Jun 2026 07:14:41 +0000 (09:14 +0200)
commit03866d130ed33ab68cc7faaf4bf2c4abef96d42e
treebf3295b6dd9306dca888b8465637822ce9a5f7ac
parent0a5213bbff62b51c7d4999ac8c7e11ea57d00d45
xfs: fix unreachable BIGTIME check in dquot flush validation

The dqp->q_id == 0 check inside the XFS_DQTYPE_BIGTIME block is
unreachable because root dquots return successfully earlier. Reject root
dquots with XFS_DQTYPE_BIGTIME before that early return, preserving the
intended validation and removing the unreachable condition.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 4ea1ff3b4968 ("xfs: widen ondisk quota expiration timestamps to handle y2038+")
Cc: stable@vger.kernel.org # v5.10+
Signed-off-by: Alexey Nepomnyashih <sdl@nppct.ru>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Allison Henderson <achender@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_dquot.c