]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Bluetooth: Fix SSP acceptor just-works confirmation without MITM
authorJohan Hedberg <johan.hedberg@intel.com>
Mon, 9 Jun 2014 10:58:14 +0000 (13:58 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jul 2014 18:21:27 +0000 (11:21 -0700)
commit039da39a616103ec7ab8ac351bfb317854e5507c
tree8367996bc79de1a577cb69d58de0e68737cf3fd8
parent035f657a1668eaf7999909d6bb7cf293b56cedba
Bluetooth: Fix SSP acceptor just-works confirmation without MITM

commit ba15a58b179ed76a7e887177f2b06de12c58ec8f upstream.

From the Bluetooth Core Specification 4.1 page 1958:

"if both devices have set the Authentication_Requirements parameter to
one of the MITM Protection Not Required options, authentication stage 1
shall function as if both devices set their IO capabilities to
DisplayOnly (e.g., Numeric comparison with automatic confirmation on
both devices)"

So far our implementation has done user confirmation for all just-works
cases regardless of the MITM requirements, however following the
specification to the word means that we should not be doing confirmation
when neither side has the MITM flag set.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Tested-by: Szymon Janc <szymon.janc@tieto.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bluetooth/hci_event.c