]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: wacom: fix kobject reference count leak
authorQasim Ijaz <qasdev00@gmail.com>
Fri, 6 Jun 2025 18:49:59 +0000 (19:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jul 2025 13:57:40 +0000 (15:57 +0200)
commit03b68435fbe3d37f3bc57d5deaa4fd38a9632fa3
treed5c98f0bc8c5da89a06d94405510b3354cbd17ce
parent796abf9f710ae008674936ab499a70f535d8324c
HID: wacom: fix kobject reference count leak

commit 85a720f4337f0ddf1603c8b75a8f1ffbbe022ef9 upstream.

When sysfs_create_files() fails in wacom_initialize_remotes() the error
is returned and the cleanup action will not have been registered yet.

As a result the kobject???s refcount is never dropped, so the
kobject can never be freed leading to a reference leak.

Fix this by calling kobject_put() before returning.

Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated")
Acked-by: Ping Cheng <ping.cheng@wacom.com>
Cc: stable@vger.kernel.org
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/wacom_sys.c