]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ieee802154: do not leave a dangling sk pointer in ieee802154_create()
authorIgnat Korchagin <ignat@cloudflare.com>
Mon, 14 Oct 2024 15:38:04 +0000 (16:38 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:47 +0000 (20:03 +0100)
commit03caa9bfb9fde97fb53d33decd7364514e6825cb
tree3a74afaf8115dbef6df303d8bafb8841ea76c51c
parent8df832e6b945e1ba61467d7f1c9305e314ae92fe
net: ieee802154: do not leave a dangling sk pointer in ieee802154_create()

[ Upstream commit b4fcd63f6ef79c73cafae8cf4a114def5fc3d80d ]

sock_init_data() attaches the allocated sk object to the provided sock
object. If ieee802154_create() fails later, the allocated sk object is
freed, but the dangling pointer remains in the provided sock object, which
may allow use-after-free.

Clear the sk pointer in the sock object on error.

Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241014153808.51894-6-ignat@cloudflare.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/ieee802154/socket.c