]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
crypto: drbg - Fix ineffective sanity check
authorEric Biggers <ebiggers@kernel.org>
Mon, 20 Apr 2026 06:33:47 +0000 (23:33 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 7 May 2026 08:09:59 +0000 (16:09 +0800)
commit040ad83b0e8aa065fd2fc641cacba8491a8b186d
tree904dd0a531c0f87ea341d78486215abd691dd924
parentddc4dedb9ba3c8eecbc8c050fffd46d1b7e75c21
crypto: drbg - Fix ineffective sanity check

Fix drbg_healthcheck_sanity() to correctly check the return value of
drbg_generate().  drbg_generate() returns 0 on success, or a negative
errno value on failure.  drbg_healthcheck_sanity() incorrectly assumed
that it returned a positive value on success.

This didn't make the sanity check fail, but it made it ineffective.

Fixes: cde001e4c3c3 ("crypto: rng - RNGs must return 0 in success case")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/drbg.c