]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Bluetooth: Fix incorrect strncpy() in hidp_setup_hid()
authorAnderson Lizardo <anderson.lizardo@openbossa.org>
Sun, 6 Jan 2013 22:28:53 +0000 (18:28 -0400)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 10 Feb 2014 21:11:16 +0000 (16:11 -0500)
commit0410beec773e5ea9c97486dda67620fbbb9e7189
treece32a89453c864e78c15f482189224fe2c3e5270
parent90162eab0fd28b731d67b0b83db3cf434583bcdf
Bluetooth: Fix incorrect strncpy() in hidp_setup_hid()

commit 0a9ab9bdb3e891762553f667066190c1d22ad62b upstream.

The length parameter should be sizeof(req->name) - 1 because there is no
guarantee that string provided by userspace will contain the trailing
'\0'.

Can be easily reproduced by manually setting req->name to 128 non-zero
bytes prior to ioctl(HIDPCONNADD) and checking the device name setup on
input subsystem:

$ cat /sys/devices/pnp0/00\:04/tty/ttyS0/hci0/hci0\:1/input8/name
AAAAAA[...]AAAAAAAAf0:af:f0:af:f0:af

("f0:af:f0:af:f0:af" is the device bluetooth address, taken from "phys"
field in struct hid_device due to overflow.)

Signed-off-by: Anderson Lizardo <anderson.lizardo@openbossa.org>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/bluetooth/hidp/core.c