]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
wifi: rtw89: phy: fix uninitialized variable access in rtw89_phy_cfo_set_crystal_cap()
authorAlexey Velichayshiy <a.velichayshiy@ispras.ru>
Mon, 23 Mar 2026 14:05:53 +0000 (17:05 +0300)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 30 Mar 2026 01:48:10 +0000 (09:48 +0800)
commit047cddf88c611e616d49a00311d4722e46286234
tree4d89011102a3c995b89fcf5dc8964091e5b53dd9
parentaefb20749074731c4f35444761e730991f1b8c77
wifi: rtw89: phy: fix uninitialized variable access in rtw89_phy_cfo_set_crystal_cap()

In the rtw89_phy_cfo_set_crystal_cap() function, for chips other than
RTL8852A/RTL8851B, the values read by rtw89_mac_read_xtal_si() are
stored into the local variables sc_xi_val and sc_xo_val. If either
read fails, these variables remain uninitialized, they are later
used to update cfo->crystal_cap and in debug print statements. This
can lead to undefined behavior.

Fix the issue by initializing sc_xi_val and sc_xo_val to zero,
like is implemented in vendor driver.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 8379fa611536 ("rtw89: 8852c: add write/read crystal function in CFO tracking")
Signed-off-by: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20260323140613.1615574-1-a.velichayshiy@ispras.ru
drivers/net/wireless/realtek/rtw89/phy.c