]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
coredump: Fixes core_pipe_limit sysctl proc_handler
authorNicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
Wed, 15 Jan 2025 13:22:08 +0000 (14:22 +0100)
committerJoel Granados <joel.granados@kernel.org>
Mon, 17 Feb 2025 10:33:46 +0000 (11:33 +0100)
commit049439e22825507a90d4dedf3934e24fd0a8ff62
tree6a0c94cd8fbdc31d357039dedc175e25dcd708ab
parentdccf3c99febf09890d7fa99b8529f021d46787f9
coredump: Fixes core_pipe_limit sysctl proc_handler

proc_dointvec converts a string to a vector of signed int, which is
stored in the unsigned int .data core_pipe_limit.
It was thus authorized to write a negative value to core_pipe_limit
sysctl which once stored in core_pipe_limit, leads to the signed int
dump_count check against core_pipe_limit never be true. The same can be
achieved with core_pipe_limit set to INT_MAX.

Any negative write or >= to INT_MAX in core_pipe_limit sysctl would
hypothetically allow a user to create very high load on the system by
running processes that produces a coredump in case the core_pattern
sysctl is configured to pipe core files to user space helper.
Memory or PID exhaustion should happen before but it anyway breaks the
core_pipe_limit semantic.

This commit fixes this by changing core_pipe_limit sysctl's proc_handler
to proc_dointvec_minmax and bound checking between SYSCTL_ZERO and
SYSCTL_INT_MAX.

Fixes: a293980c2e26 ("exec: let do_coredump() limit the number of concurrent dumps to pipes")
Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Kees Cook <kees@kernel.org>
Signed-off-by: Joel Granados <joel.granados@kernel.org>
fs/coredump.c