]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: hisi_sas: Fix setting of hisi_sas_slot.is_internal
authorJohn Garry <john.garry@huawei.com>
Mon, 31 Jan 2022 11:13:27 +0000 (19:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:44:07 +0000 (07:44 +0200)
commit04bbb1b72b556770143ad4f8efaf4839fbceb26e
tree9ae4e7989bea7700f2ca5f698babe5a5db84cb93
parent8b8e6d433bd9039772567677be33abec15c48003
scsi: hisi_sas: Fix setting of hisi_sas_slot.is_internal

[ Upstream commit c763ec4c10f78678d6d4415646237f07109a5a5f ]

The hisi_sas_slot.is_internal member is not set properly for ATA commands
which the driver sends directly. A TMF struct pointer is normally used as a
test to set this, but it is NULL for those commands. It's not ideal, but
pass an empty TMF struct to set that member properly.

Link: https://lore.kernel.org/r/1643627607-138785-1-git-send-email-john.garry@huawei.com
Fixes: dc313f6b125b ("scsi: hisi_sas: Factor out task prep and delivery code")
Reported-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Stable-dep-of: 8aa580cd9284 ("scsi: hisi_sas: Enable force phy when SATA disk directly connected")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/hisi_sas/hisi_sas_main.c