]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: hda: Relax __free() variable declarations
authorTakashi Iwai <tiwai@suse.de>
Tue, 16 Dec 2025 14:06:31 +0000 (15:06 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 17 Dec 2025 09:08:30 +0000 (10:08 +0100)
commit04c654624f41d3c3eee48e9837a52d8a2bbc7332
treede289f2d29b00c613893d8b121078755e5951bb5
parent3b7c7bda39e1e48f926fb3d280a5f5d20a939857
ALSA: hda: Relax __free() variable declarations

We used to have a variable declaration with __free() initialized with
NULL.  This was to keep the old coding style rule, but recently it's
relaxed and rather recommends to follow the new rule to declare in
place of use for __free() -- which avoids potential deadlocks or UAFs
with nested cleanups.

Although the current code has no bug, per se, let's follow the new
standard and move the declaration to the place of assignment (or
directly assign the allocated result) instead of NULL initializations.

Fixes: ee0b0f5d32fe ("ALSA: hda/generic: Use auto cleanup for temporary buffers")
Fixes: 03c5c350e38d ("ALSA: hda/realtek: Add support for new HP G12 laptops")
Fixes: b0550d4c2dd8 ("ALSA: hda/common: Use auto cleanup for temporary buffers")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20251216140634.171890-10-tiwai@suse.de
sound/hda/codecs/generic.c
sound/hda/codecs/realtek/alc269.c
sound/hda/codecs/realtek/realtek.c
sound/hda/common/codec.c
sound/hda/common/sysfs.c