]> git.ipfire.org Git - thirdparty/vim.git/commit
patch 9.1.1055: make install fails because of a missing dependency v9.1.1055
authorSergei Trofimovich <slyich@gmail.com>
Tue, 28 Jan 2025 10:37:52 +0000 (11:37 +0100)
committerChristian Brabandt <cb@256bit.org>
Tue, 28 Jan 2025 10:37:52 +0000 (11:37 +0100)
commit04cc8975930b7b2c5d6753d3eddf57dab2816518
treeb0a4bcef7a39ad64ea403a9ef4d8e3c6db211c3b
parentdb23436b92a1b08e91146ef462482f2c1a79dfe8
patch 9.1.1055: make install fails because of a missing dependency

Problem:  make install fails because of a missing dependency
Solution: add explicit dependencies for tutor/{en,it}
          (Sergei Trofimovich)

Without the change `make install -j16` fails
sometimes due to race condition to create a directory.

It's best reproducible with `make --shuffle`:

    $ make install --shuffle
    ...
    bash install-sh -c -d /vim-9.1.0990/share/vim/vim91/tutor
    chmod 755 /vim-9.1.0990/share/vim/vim91/tutor
    cp ../runtime/tutor/README* ../runtime/tutor/tutor* /vim-9.1.0990/share/vim/vim91/tutor
    cp ../runtime/tutor/en/* /vim-9.1.0990/share/vim/vim91/tutor/en/
    cp: target '/vim-9.1.0990/share/vim/vim91/tutor/en/': No such file or directory
    make[1]: [Makefile:2487: installtutor] Error 1 (ignored) shuffle=2340321974
    cp ../runtime/tutor/it/* /vim-9.1.0990/share/vim/vim91/tutor/it/
    cp: target '/vim-9.1.0990/share/vim/vim91/tutor/it/': No such file or directory
    make[1]: [Makefile:2488: installtutor] Error 1 (ignored) shuffle=2340321974

The fix adds a dependency on targeted directories used to install tutor.

Before the change it too 2-3 attempts to reproduce the install failure.
After the change `vim` survives 150 install attempts without failures.

closes: #16531

Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
src/Makefile
src/version.c